dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-12-18T18:03:55Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1423Feature/improve handbook discretization2018-12-18T18:03:55ZMartin SchneiderFeature/improve handbook discretization3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1419Feature/opm newest version2018-12-18T11:06:56ZMartin SchneiderFeature/opm newest version3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1399Feature/multidomain with soldep params2018-12-20T17:05:30ZDennis GläserFeature/multidomain with soldep paramsNumerical differentation together with solution-dependent spatial parameters didn't work properly, because the flux variables cache was not reset adequately after the deflection of primary variables. This introduces the necessary resets ...Numerical differentation together with solution-dependent spatial parameters didn't work properly, because the flux variables cache was not reset adequately after the deflection of primary variables. This introduces the necessary resets of the flux variables caches such that at the beginning of each derivative computation it is in its undeflected state.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1370Streamline folder/include structure in discretization2018-12-03T11:03:19ZTimo Kochtimokoch@math.uio.noStreamline folder/include structure in discretization3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1368Feature/improve md traits2018-11-30T09:17:23ZTimo Kochtimokoch@math.uio.noFeature/improve md traitsFix #625 -> necessary preparation for !1350 Fix #625 -> necessary preparation for !1350 3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1365[fvproblem] Resize the solution vector before applying initial solution2018-11-29T10:23:20ZTimo Kochtimokoch@math.uio.no[fvproblem] Resize the solution vector before applying initial solution* The solution was assumed to be resized before applying the initial solution. I don't think this is safe.
* Resizing has no effect if the size is already the same* The solution was assumed to be resized before applying the initial solution. I don't think this is safe.
* Resizing has no effect if the size is already the same3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1359[params] Improve handling of parameter files2018-11-28T16:43:15ZTimo Kochtimokoch@math.uio.no[params] Improve handling of parameter filesFix #623.
If no parameter file is given look for
* executbale.input
* params.intput
If none are found, try it without parameter file.
If a parameter file is given, let Dune do the error handling,
and check if the file exists....Fix #623.
If no parameter file is given look for
* executbale.input
* params.intput
If none are found, try it without parameter file.
If a parameter file is given, let Dune do the error handling,
and check if the file exists.
Messages are now:
* no parameter file found:
```
No parameter file found. Continuing without parameter file.
ParameterException [init:../dumux/io/grid/gridmanager.hh:407]: Please supply one of the parameters Grid.UpperRight, or a grid file in Grid.File ---> Abort!
```
* parameter file doesn't exist:
```
Reading parameters from file bla.inpuit.
Dune reported error: Dune::IOError [readINITree:../dune/common/parametertreeparser.cc:49]: Could not open configuration file bla.inpuit ---> Abort!
```
which I find better than before. In particular if a program doesn't need a parameter file, there is no error now.3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1353[common] Implement partial function for referencing parts of a tuple2018-11-28T09:35:14ZTimo Kochtimokoch@math.uio.no[common] Implement partial function for referencing parts of a tuple3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1350Multidomain wrappers to easier write main files2018-11-30T11:07:46ZTimo Kochtimokoch@math.uio.noMultidomain wrappers to easier write main files* wrapper for grid variables for multidomain (when it's more than two it already gets nasty in the main file)
* wrapper for vtk output module
The same could be done for problems, grid geometry. I think, there is more such classes it ...* wrapper for grid variables for multidomain (when it's more than two it already gets nasty in the main file)
* wrapper for vtk output module
The same could be done for problems, grid geometry. I think, there is more such classes it would get even shorter as all the type aliases are hidden too.
It gives nasty compiler errors though, if e.g. you put in the wrong type the message is crazy long because of those Hybrid::forEaches.
!1365 should be merged first.
!1368 should be merged first.3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1330Feature/improve privar switch2018-11-26T16:13:43ZTimo Kochtimokoch@math.uio.noFeature/improve privar switchFix #580.
todo:
- [x] Check all models/tests
- [x] Check/adapt dumux-lecture main files (see dumux-lecture!50)Fix #580.
todo:
- [x] Check all models/tests
- [x] Check/adapt dumux-lecture main files (see dumux-lecture!50)3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1325Feature/mpfa-scv-gradient-reconstruction2018-12-04T16:24:44ZDennis GläserFeature/mpfa-scv-gradient-reconstructionIntroduces functionality to reconstruct gradients and velocities on the mpfa dual grid sub-control volumes.
Has to wait for !1286 Introduces functionality to reconstruct gradients and velocities on the mpfa dual grid sub-control volumes.
Has to wait for !1286 3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1320Feature/velocity output with mpfa2018-11-23T15:56:03ZDennis GläserFeature/velocity output with mpfaTODO:
- [x] There seems to be an issue at corners where Dirichlet and Neumann Bcs meet
TODO:
- [x] There seems to be an issue at corners where Dirichlet and Neumann Bcs meet
3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1318[brine] Remove default for constant salinty2018-11-27T23:56:15ZTimo Kochtimokoch@math.uio.no[brine] Remove default for constant salintyFixes #607Fixes #6073.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1315[component] Remove defaults from constant component2018-11-26T14:12:37ZTimo Kochtimokoch@math.uio.no[component] Remove defaults from constant componentFix #579 where is was noted that 1.0 as default is more a disadvantage
than an advantage. Just specify 1.0 in the input file explicitly
instead. For examples typos in the input files could be unnoticed.
* Remove the default for cons...Fix #579 where is was noted that 1.0 as default is more a disadvantage
than an advantage. Just specify 1.0 in the input file explicitly
instead. For examples typos in the input files could be unnoticed.
* Remove the default for constant component
* Do not set molar density if it's not used and not returned in any interface (fixes #608)
* Do not output molar density in navierstokes non-compositional models (fixes #608), adjust references (remove rhoMolar)
* Fuelcellni test had the wrong solid phase properties -> fixed parameters and adjusted reference solution
* Sagd test had a typo in the input file -> fixed typo and adjusted reference solution3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1306[gridvars] Unify for stationary and instationary problems2018-11-21T14:20:17ZTimo Kochtimokoch@math.uio.no[gridvars] Unify for stationary and instationary problems* Always initialize prevGridVolVars
* Means memory overhead for stationary problems with caching (but caching means I have enough memory anyway)
* Greatly simplifies usage
* Deprecate for now and can be implemented on dumux day
* Fix...* Always initialize prevGridVolVars
* Means memory overhead for stationary problems with caching (but caching means I have enough memory anyway)
* Greatly simplifies usage
* Deprecate for now and can be implemented on dumux day
* Fixes md facet explicit transport test3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1300Provide a script that replaces property macro usages2018-11-19T18:10:43ZBernd FlemischProvide a script that replaces property macro usagesFixes #593.Fixes #593.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1298Restructure mpfa flux caches2018-11-22T17:01:29ZDennis GläserRestructure mpfa flux cachesThe main improvement is that the process-dependent flux variable caches are much smaller now, only storing a pointer to the respective interaction volume data handle class. From there, all necessary information can be obtained. Also, thi...The main improvement is that the process-dependent flux variable caches are much smaller now, only storing a pointer to the respective interaction volume data handle class. From there, all necessary information can be obtained. Also, this data now also comprises everything necessary for face unknown reconstruction and gradient evaluations on scvs.
Todo:
- [x] use correct sol-dependence flag in heat conduction filler
- [x] store omegas in data handle as well (required for gradient reconstruction)
- [x] use static interaction volume in some test
Possibility of including Neumann boundary conditions into the local system of equations as well as face unknown & gradients reconstruction will be done in the near future on a separate branch.3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1290Feature/fvgeometry boundary2018-11-18T21:15:54ZKilian WeishauptFeature/fvgeometry boundary3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1288Feature/md explicit assembler2018-11-15T23:02:44ZDennis GläserFeature/md explicit assemblerSteps to do:
- [x] cleanup of md-cc-localassembler
- [x] add documentation
- [x] introduce explicit local assembler
- [x] implement tpfa test
- [x] try to reuse cc-explicit-local assembler (assembly routine is essentially the same) -> __...Steps to do:
- [x] cleanup of md-cc-localassembler
- [x] add documentation
- [x] introduce explicit local assembler
- [x] implement tpfa test
- [x] try to reuse cc-explicit-local assembler (assembly routine is essentially the same) -> __discarded__
- [x] implement box-explicit multidomain local assembler
- [x] implement test for box
- [x] use new namings/folders according to !1284
- [x] add reference files to tests
Fixes #521 3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1283Feature/test facetcoupling xi2018-12-04T15:30:32ZDennis GläserFeature/test facetcoupling xiHas to wait for !1284 and !1285 and adapt the test names/implementations accordingly.
TODO:
- [x] Implement gravity handling for xi != 1.0
- [x] add tests for gravity and various xis
Implementation of gravity handling on surface ...Has to wait for !1284 and !1285 and adapt the test names/implementations accordingly.
TODO:
- [x] Implement gravity handling for xi != 1.0
- [x] add tests for gravity and various xis
Implementation of gravity handling on surface grids will be done separately at one point towards Milestone 3.1 (see #591).3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no