dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-02-25T15:34:18Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2208Feature/pore network model2021-02-25T15:34:18ZKilian WeishauptFeature/pore network modelThis MR implements pore-network models in Dumux.
__TODO__
- [x] remove deprecated warnings
- [x] discuss folder structure
- [x] discuss caching and transmissibility laws
- [x] discuss grid data
- [x] discuss tests
- [x] check docu
- [x...This MR implements pore-network models in Dumux.
__TODO__
- [x] remove deprecated warnings
- [x] discuss folder structure
- [x] discuss caching and transmissibility laws
- [x] discuss grid data
- [x] discuss tests
- [x] check docu
- [x] clean up
- [x] use script in `bin/util/create_cmakelists.py` to create CMakeLists.txt files
- [x] change license headers to GPL v3
- [x] put flux-related header into `dumux/flux`
- [x] revise and check ps-Sw curve
- [x] discuss and find a solution for the 2p and 2pni tests, which are very sensitive to the chosen regularization method and the parameter Swmax.
- [x] Add description in changelog (+ backwards-compatibility policy)3.4Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2230Feature/install script generator2021-01-27T13:17:38ZDennis GläserFeature/install script generatorThis MR introduces a python script that generates an install script for a selected module, together with python functionality to get the dependencies of a module and the currenlty used versions, as well as automatic patch creation for un...This MR introduces a python script that generates an install script for a selected module, together with python functionality to get the dependencies of a module and the currenlty used versions, as well as automatic patch creation for unpublished commits and uncommitted changes.
These functionalities were originally contained in `getusedversions.sh` and `extractmodulepart.sh`. The first should not be needed anymore, while the latter has been reduced to not generate an install script anymore.
The generator script expects the module (for which an installation script is to be generated) to already be a git repository with a defined remote origin.
Relates #912, #9213.4Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2231Feature/python createdockerimage script2021-05-11T15:18:16ZDennis GläserFeature/python createdockerimage scriptThis MR is based on !2222 using the implementation made be @utz, but it modifies the `createdockerimage.py` script such that it expects an install script in the form as introduced in !2230, i.e., it expects everything to be installed by ...This MR is based on !2222 using the implementation made be @utz, but it modifies the `createdockerimage.py` script such that it expects an install script in the form as introduced in !2230, i.e., it expects everything to be installed by it. If we like this, we can close !2222.
This has the advantage that the script does not have to be called from within the module, but can be called from anywhere.
This is WIP because it depends on !2230, especially on the question if we want to restrict ourselves to this type of install scripts.
Relates #912, #921
part of #8833.4Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2243[shallowwater][diffusion] add turbulent diffusion to shallow water2021-06-07T12:47:16ZFrank Platzek[shallowwater][diffusion] add turbulent diffusion to shallow water**Adding (turbulent) diffusion to the shallow water model (part of freeflow)**:
The implementation basically contains three parts:
1. computation of a horzontal diffusion flux (shear stress)
2. computation of possible wall-shear stress
...**Adding (turbulent) diffusion to the shallow water model (part of freeflow)**:
The implementation basically contains three parts:
1. computation of a horzontal diffusion flux (shear stress)
2. computation of possible wall-shear stress
3. computation of a turbulent viscosity from a very basic turbulence model (mixing-length based, kept as local as possible)
For now using either a constant eddy-viscosity (turbulence model 0) or a horizontal mixing-length based appraoch (turbulence model 1). Other turbulence models might be added in later. The implementation contains 2 wall shear stress implementations:
1. no-slip implementation
2. law-of-the-wall implementation
One test has been added: Poiseuille flow test: for flow in a channel with rough side walls. This test has an analytical solution.
**Which issue this MR fixes**
Fixes #706
**Special notes for your reviewer**: The Poiseuille flow test only tests two of the three added functionalities:
the horizontal diffusion and the wall shear stress implementations, with constant eddy viscosity. The turbulence model 1 implementation where the eddy viscosity is computed algebraically based on the local bottom shear stress and velocity gradients is not tested in this test case. A number of test cases was, however, performed to test this. Among others, a test case for the flow around a thin wall. Should this test also be added?
Moreover, the present Poiseuille test uses a structured rectangular grid. The same test was also set up and performed on an unstructured triangular grid. Is this test also required? Thank you very much!3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2252Rewrite Install external with Python2021-05-19T11:06:19ZFelix WeinhardtRewrite Install external with Python
Fixes #866
Fixes #8663.4Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2285Feature/new gridvars concept2021-04-29T07:00:08ZDennis GläserFeature/new gridvars concept**What this MR does / why does DuMux need it**:
Introduces a new grid variables concept, where the grid variables represent the entire state of a current solution. That is, they define both primary & secondary variables and, once implem...**What this MR does / why does DuMux need it**:
Introduces a new grid variables concept, where the grid variables represent the entire state of a current solution. That is, they define both primary & secondary variables and, once implemented in the future, the time level on which the solution is defined.
Mentions #9403.4Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2291Feature/newton variables backend2021-06-07T13:11:56ZDennis GläserFeature/newton variables backend<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Introduces a backend for classes like `NewtonSolver` such tha...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Introduces a backend for classes like `NewtonSolver` such that it can operate on both solution vectors or more generic variables (primary&secondary variables) objects. `NewtonSolver` is then modified to use the backend.
<!--
**Which issue this MR fixes** *(optional - uncomment and add issue)*:
fixes #
-->
mentions #9403.4Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2296Feature/timestep methods2021-04-29T07:00:08ZDennis GläserFeature/timestep methodsIntroduces a multistage time stepper for time integration.
This addresses part of #940Introduces a multistage time stepper for time integration.
This addresses part of #9403.4Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2312treat offdiagonal blocks2020-11-10T13:34:21ZBernd Flemischtreat offdiagonal blocks3.4Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2393Fix norm calculation in the Newton solver2020-11-16T13:55:05ZBernd FlemischFix norm calculation in the Newton solverUse the norm provided by the linear solver also for the initial
residual. In subsequent steps, the linear solver calculated the
norm of the solution instead of the residual. Fix this.Use the norm provided by the linear solver also for the initial
residual. In subsequent steps, the linear solver calculated the
norm of the solution instead of the residual. Fix this.3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2395Fix multidomain residual norm in parallel2020-12-14T16:22:09ZBernd FlemischFix multidomain residual norm in parallelMake the residual parts resulting from box consistent.Make the residual parts resulting from box consistent.3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2399[cleanup][test] Remove Python 2 compatibility2020-11-18T07:39:08ZTimo Kochtimokoch@math.uio.no[cleanup][test] Remove Python 2 compatibility3.4Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2410Improve yasp- and subgridmanager2020-12-03T19:26:34ZKilian WeishauptImprove yasp- and subgridmanager3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2414Feature/upwind interface2021-04-29T07:00:09ZMartin SchneiderFeature/upwind interfaceMore general interface for upwind schemes such that for example forchheimerlaw uses the correct scheme and does not implemented its own upwinding.
- [x] think about better names for `upwindTerm`, `multiplier`More general interface for upwind schemes such that for example forchheimerlaw uses the correct scheme and does not implemented its own upwinding.
- [x] think about better names for `upwindTerm`, `multiplier`3.4Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2416[io] Fix bug in rasterimagereader2020-12-07T16:44:10ZKilian Weishaupt[io] Fix bug in rasterimagereader3.4Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2417Feature/tokenize2021-04-29T07:00:09ZTimo Kochtimokoch@math.uio.noFeature/tokenize3.4Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2419[python] Make DuMux installable via pip2021-04-29T07:00:09ZSamuel Burbullasamuel.burbulla@mathematik.uni-stuttgart.de[python] Make DuMux installable via pipThis adds the files necessary for publishing DuMux as python package.
I have uploaded a first development release to PyPI: https://pypi.org/project/dumux/
Feel free to try `pip install dumux`.This adds the files necessary for publishing DuMux as python package.
I have uploaded a first development release to PyPI: https://pypi.org/project/dumux/
Feel free to try `pip install dumux`.3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2422[flux][tpfa][fickslaw] Add flux overload taking inside/outside volVars explicitly2021-04-29T07:00:09ZTimo Kochtimokoch@math.uio.no[flux][tpfa][fickslaw] Add flux overload taking inside/outside volVars explicitly3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2424Fix/fvassembler include2021-01-11T19:06:59ZDennis GläserFix/fvassembler includeOn minimal setups without MPI installed, the box tests failed to compile
as the FVAssembler uses the ParallelVectorHelper class, which itself was
hidden behind a HAVE_MPI guard. Tests with setups where MPI is not
installed showed that th...On minimal setups without MPI installed, the box tests failed to compile
as the FVAssembler uses the ParallelVectorHelper class, which itself was
hidden behind a HAVE_MPI guard. Tests with setups where MPI is not
installed showed that the tests compile and run also without the guard3.4Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2430[bugfix][fickslaw] Add missing return in getRho helper2021-01-04T14:55:14ZTimo Kochtimokoch@math.uio.no[bugfix][fickslaw] Add missing return in getRho helperFixes bug introduced in !2422.Fixes bug introduced in !2422.3.4Dennis GläserDennis Gläser