dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-09-30T17:31:42Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2837Consistent naming in test/references2021-09-30T17:31:42ZFarid MohammadiConsistent naming in test/referencesCloses #1077Closes #10773.5Farid MohammadiFarid Mohammadihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2851Feature/test detection cmakelists2021-09-30T14:52:33ZTimo Kochtimokoch@math.uio.noFeature/test detection cmakelistsMark tests as affected if the CMakeLists.txt file changedMark tests as affected if the CMakeLists.txt file changed3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2850Fix switching between isothermal and nonisothermal model in freeflow channel ...2021-09-30T13:05:00ZBernd FlemischFix switching between isothermal and nonisothermal model in freeflow channel testA preprocessor variable ISOTHERMAL was set to 0 per default in main.cc
while for switching, the variable NONISOTHERMAL was evaluated.
To fix, set NONISOTHERMAL instead of ISOTHERMAL in main.cc.A preprocessor variable ISOTHERMAL was set to 0 per default in main.cc
while for switching, the variable NONISOTHERMAL was evaluated.
To fix, set NONISOTHERMAL instead of ISOTHERMAL in main.cc.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2814fix/mpfa-fluxvars-caching-for-diffusion2021-09-22T11:29:52ZDennis Gläserfix/mpfa-fluxvars-caching-for-diffusionFixes #1047Fixes #10473.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2832[component] Allow specifying dynamic _or_ kinematic viscosity for constant co...2021-09-20T07:20:56ZTimo Kochtimokoch@math.uio.no[component] Allow specifying dynamic _or_ kinematic viscosity for constant components3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2827Feature/freeflow periodic2021-09-16T14:38:44ZTimo Kochtimokoch@math.uio.noFeature/freeflow periodic3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2831[material] Add option to PengRobinson::computeMolarVolume2021-09-16T11:22:20ZTimo Kochtimokoch@math.uio.no[material] Add option to PengRobinson::computeMolarVolume- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
o...- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
or the number of roots is 2 or more than 3
(no check was in place)
- Throwing NumericalProblem if the found molar volume turned
out to be zero, negative, or NaN. (Replacing assert)
- Added handleUnphysicalPhase flag (true by default). If false, the
single-root case is not checked for critical state of
the fluid (otherwise, Michelsen test for a mix of
hydrocarbons does not work).3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2823[freeflow] Add mass/energy model and donea/channel/sincos test with new stagg...2021-09-15T14:58:27ZTimo Kochtimokoch@math.uio.no[freeflow] Add mass/energy model and donea/channel/sincos test with new staggeredPart of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> impl...Part of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> implements same style as for pm models where non-isothermal version is also included in base model version. I don't see harm in adding this here already....
* [x] But maybe we should also add a NI test then.
* [x] Print error to analytical solution in Donea3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2828[io] Check if grid can communicate when loading solution2021-09-14T15:18:20ZMartin Schneider[io] Check if grid can communicate when loading solution3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2779Feature/freeflow momentum new staggered2021-09-10T08:55:21ZTimo Kochtimokoch@math.uio.noFeature/freeflow momentum new staggered* Add momentum model for fcstaggered
* Add a Donea test solving the momentum part of the Stokes equations with given pressure
Part of merging !2201 in smaller parts
Closes #896* Add momentum model for fcstaggered
* Add a Donea test solving the momentum part of the Stokes equations with given pressure
Part of merging !2201 in smaller parts
Closes #8963.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2780Fix/staggered fcdiscretization2021-09-10T08:55:21ZTimo Kochtimokoch@math.uio.noFix/staggered fcdiscretizationSome followup fixes for bugs overlooked in !2766Some followup fixes for bugs overlooked in !27663.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2825[multidomain][couplingmanager] Store tuple of share_ptr's for SolutionVector2021-09-09T07:36:19ZTimo Kochtimokoch@math.uio.no[multidomain][couplingmanager] Store tuple of share_ptr's for SolutionVector* add new function curSol(domainIdx) and deprecate curSol()
* allow to set externally stored solution vector without taking ownership* add new function curSol(domainIdx) and deprecate curSol()
* allow to set externally stored solution vector without taking ownership3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2806Feature/1d3d projection2021-09-07T10:22:20ZTimo Kochtimokoch@math.uio.noFeature/1d3d projection* Add a 1D-3D coupling manager for the method introduced in Koch 2021
* Add a test derived from the existing 1p_richards test but with a smaller root system (to limit mesh file size for testing)
<img width=500px src="/uploads/f9efeb46bc...* Add a 1D-3D coupling manager for the method introduced in Koch 2021
* Add a test derived from the existing 1p_richards test but with a smaller root system (to limit mesh file size for testing)
<img width=500px src="/uploads/f9efeb46bca21d37d58e856bcb02f908/Screenshot_2021-08-29_at_02.07.19.png"></img>3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2822[test][md] Use new error helper in convergence test2021-09-06T23:02:03ZTimo Kochtimokoch@math.uio.no[test][md] Use new error helper in convergence test3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2819[ci] Make triggered dumux-lecture branch a variable2021-09-06T13:37:26ZTimo Kochtimokoch@math.uio.no[ci] Make triggered dumux-lecture branch a variableAFAIK the release dumux branch currently triggers the dumux-lecture master branch. While this might be an interesting combination, this curretnly leaves the lecture rlease branch untested. With this variable, we can configure the nightly...AFAIK the release dumux branch currently triggers the dumux-lecture master branch. While this might be an interesting combination, this curretnly leaves the lecture rlease branch untested. With this variable, we can configure the nightly schedule to use release rbanches in both dumux and dumux-lecture3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2818Add PengRobinson::criticalTemperature()2021-09-05T14:45:03ZDmitry PavlovAdd PengRobinson::criticalTemperature()It is useful for determining whether the fluid is in supercritical state.It is useful for determining whether the fluid is in supercritical state.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2817remove unused local variable in MPNC nonequilibrium volume variables2021-09-03T10:23:21ZBernd Flemischremove unused local variable in MPNC nonequilibrium volume variablesleftover from the equilibrium variantleftover from the equilibrium variant3.5Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2816Feature/bin common affirmative filter2021-09-03T06:00:11ZDennis GläserFeature/bin common affirmative filterdepends on !2758depends on !27583.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2758Feature/python scipts formatting linting2021-09-02T21:40:02ZTimo Kochtimokoch@math.uio.noFeature/python scipts formatting lintingFixes #1050
TODO
* [x] Make all the linters happy (`pylint` is the most difficult but has good suggestions)
* [x] Make sure the scripts are still working (some changes are at least somewhat non-trivial)
- [x] `bin/testing` (can be...Fixes #1050
TODO
* [x] Make all the linters happy (`pylint` is the most difficult but has good suggestions)
* [x] Make sure the scripts are still working (some changes are at least somewhat non-trivial)
- [x] `bin/testing` (can be decently tested by running CI with some fake change)
- [x] `bin/postprocessing` -> manual testing (partially tested)
- [x] `extract_module` -> manual testing
- [x] `create_docker` -> manual testing (partially tested)3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2815[gridgeometry][bugfix] Reinitialize maps in update2021-09-02T12:46:06ZTimo Kochtimokoch@math.uio.no[gridgeometry][bugfix] Reinitialize maps in updateIf update is called twice the connectivity map is wrong sinnce
we push additional entries in there, i.e. each node in the stencil
will appear twice.
This makes sure all vectors are correctly reinitalized in every updateIf update is called twice the connectivity map is wrong sinnce
we push additional entries in there, i.e. each node in the stencil
will appear twice.
This makes sure all vectors are correctly reinitalized in every update3.5Dennis GläserDennis Gläser