dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-08-21T16:13:16Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2766New staggered facecentered discretization2021-08-21T16:13:16ZKilian WeishauptNew staggered facecentered discretizationThis MR only contains the discretization parts of !2201 in order to simplify the review.
I would suggest to merge this one here first and rebase !2201 afterwards.
@nedc @martins @timok I think it would be good if all of you have a look.This MR only contains the discretization parts of !2201 in order to simplify the review.
I would suggest to merge this one here first and rebase !2201 afterwards.
@nedc @martins @timok I think it would be good if all of you have a look.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2778[navierstokes][iofields] Fix for non-staggered models2021-08-20T19:57:42ZTimo Kochtimokoch@math.uio.no[navierstokes][iofields] Fix for non-staggered models3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2776Feature/component is const visco2021-08-20T19:19:53ZTimo Kochtimokoch@math.uio.noFeature/component is const visco* implement `gasViscosityIsConstant()` for `Air`
* add `viscosityIsConstant()` for `1pgas`* implement `gasViscosityIsConstant()` for `Air`
* add `viscosityIsConstant()` for `1pgas`3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2736Feature/simplify local view2021-08-20T16:04:14ZNed ColtmanFeature/simplify local viewFixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] ...Fixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] Go through all dumux/ headers and replace useage
- [x] Go through all test/ headers and replace useage
- [x] Add a note to the change log
- [x] Perform Benchmark to evaluate cost localview call within or outside of a element loop
- [x] Make changes according to the Benchmark results:
> Policy here:
> 1\.) If `bind(element)` is called within an `element` loop, call `auto fvGeometry = localView(gridGeometry)` before the loop.
> 2\.) If `bind(element)` is only called once (e.g. in certain functions), use the convenience syntax.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2770[io][bugfix] Enable parallel grids from cake grid creator2021-08-19T15:03:49ZTimo Kochtimokoch@math.uio.no[io][bugfix] Enable parallel grids from cake grid creatorFill the factory on rank 0 and then distribute to the other ranks.
This uses the same method used for Dune::GmshReader.
Add some parallel test to make sure this works
Closes #1070Fill the factory on rank 0 and then distribute to the other ranks.
This uses the same method used for Dune::GmshReader.
Add some parallel test to make sure this works
Closes #10703.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2759[cleanup] Remove 'sequential' code2021-08-16T12:18:43ZTimo Kochtimokoch@math.uio.no[cleanup] Remove 'sequential' codeSupport is discontinued after release 3.4.
TODOs
* [x] Merge dumux-lecture!156
* [x] Add entry to changelog
* [x] Check and fix handbook and other doc for sequential
Fixes #869Support is discontinued after release 3.4.
TODOs
* [x] Merge dumux-lecture!156
* [x] Add entry to changelog
* [x] Check and fix handbook and other doc for sequential
Fixes #8693.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2737[disc] New update functions for GridGeometry classes2021-08-15T18:53:20ZMartin Schneider[disc] New update functions for GridGeometry classesTodos:
- [x] think about how md facet updates (see comment below)
- [x] Update md files of examples after changes
- [x] ~~Fix MultiDomainGG~~ -> seperate MR
Closes #1056Todos:
- [x] think about how md facet updates (see comment below)
- [x] Update md files of examples after changes
- [x] ~~Fix MultiDomainGG~~ -> seperate MR
Closes #10563.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2722[geomtry][distance] Add distancePointTriangle2021-07-29T15:40:18ZKilian Weishaupt[geomtry][distance] Add distancePointTriangle3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2735[parameters] Compile as separate library2021-07-29T03:52:47ZTimo Kochtimokoch@math.uio.no[parameters] Compile as separate library3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2681Feature/python main file2021-07-28T18:15:52ZKilian WeishauptFeature/python main fileAdds more Python bindings to the `dumux` Python module. In particular the property system, parameters (from cmd line, file, or dictionary), the assembler, problem & spatial parameters are wrapped. This allows running an entire simulation...Adds more Python bindings to the `dumux` Python module. In particular the property system, parameters (from cmd line, file, or dictionary), the assembler, problem & spatial parameters are wrapped. This allows running an entire simulation (using the dune istl solver bindings directly).
Known issues/unsolved challenges:
- Currently the only way to create problem/spatial params is by writing these classes in Python. This offers full runtime flexibility but also has a strong runtime penalty. Other methods to construct more efficient problems/spatialparams need to be investigated in the future.
- The property system mechanism may not be able to fully capture circular dependencies. For example the problem depends on the coupling manager type but the couplingmanager also needs the problem type. How do I inject that knowledge to the problem?
__TODO__
- [x] Add spatialParams similar to problem
- [x] Add proper test
- [x] Make CI work (test & lint Python)
- [x] Fix issue with Parameters (`-DBUILD_SHARED_LIBS=TRUE`, i.e. using shared libraries instead of static libraries is necessary with Python code. Linking has to be done at runtime so that the parameters singleton is correctly linked in all generated libraries. This worked on macOS which builds shared libs by default but for Linux we need to explicitly enable it, see dumux-docker-ci!11)3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1822Feature/box forchheimer2021-07-23T13:53:51ZMartin SchneiderFeature/box forchheimerThe following points needs to be discussed
* [x] Code duplication for velocity calculation (same in darcyslaw and forchheimerslaw)
* [x] The upwind scheme is currently implemented in forchheimerslaw, this should be avoided by changing t...The following points needs to be discussed
* [x] Code duplication for velocity calculation (same in darcyslaw and forchheimerslaw)
* [x] The upwind scheme is currently implemented in forchheimerslaw, this should be avoided by changing the existing `upwindscheme.hh` class3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2724[disc] Add toString function for discretization method2021-07-22T11:00:06ZTimo Kochtimokoch@math.uio.no[disc] Add toString function for discretization methodThis came up for the Python bindings
!2681 but it also useful otherwise I think.This came up for the Python bindings
!2681 but it also useful otherwise I think.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2719[components] Remove unused bool argument from gasViscosity2021-07-20T16:19:57ZKilian Weishaupt[components] Remove unused bool argument from gasViscosity3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2637[md][box] Internal Dirichlet2021-05-22T10:17:38ZMartin Schneider[md][box] Internal Dirichlet* Set off-diagonal matrix blocks to zero if internal Dirichlet is set
* use correct problem() function in md framework* Set off-diagonal matrix blocks to zero if internal Dirichlet is set
* use correct problem() function in md framework3.5Martin SchneiderMartin Schneider