dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-09-30T18:37:36Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2781[ci] Test with dune 2.8 instead of dune 2.72021-09-30T18:37:36ZTimo Kochtimokoch@math.uio.no[ci] Test with dune 2.8 instead of dune 2.73.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2780Fix/staggered fcdiscretization2021-09-10T08:55:21ZTimo Kochtimokoch@math.uio.noFix/staggered fcdiscretizationSome followup fixes for bugs overlooked in !2766Some followup fixes for bugs overlooked in !27663.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2779Feature/freeflow momentum new staggered2021-09-10T08:55:21ZTimo Kochtimokoch@math.uio.noFeature/freeflow momentum new staggered* Add momentum model for fcstaggered
* Add a Donea test solving the momentum part of the Stokes equations with given pressure
Part of merging !2201 in smaller parts
Closes #896* Add momentum model for fcstaggered
* Add a Donea test solving the momentum part of the Stokes equations with given pressure
Part of merging !2201 in smaller parts
Closes #8963.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2778[navierstokes][iofields] Fix for non-staggered models2021-08-20T19:57:42ZTimo Kochtimokoch@math.uio.no[navierstokes][iofields] Fix for non-staggered models3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2776Feature/component is const visco2021-08-20T19:19:53ZTimo Kochtimokoch@math.uio.noFeature/component is const visco* implement `gasViscosityIsConstant()` for `Air`
* add `viscosityIsConstant()` for `1pgas`* implement `gasViscosityIsConstant()` for `Air`
* add `viscosityIsConstant()` for `1pgas`3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2773SST Turbulence model2022-02-23T09:17:17ZNed ColtmanSST Turbulence modelDirectly based on the @IvBu did in his Masters thesis. (Reference solutions are copied from dumux-pub/buntic2021a)
This would allow for use of the SST model in dumux.
- [x] Import SST and BSL models and add a test
- [x] Import the com...Directly based on the @IvBu did in his Masters thesis. (Reference solutions are copied from dumux-pub/buntic2021a)
This would allow for use of the SST model in dumux.
- [x] Import SST and BSL models and add a test
- [x] Import the compositional models and add a test3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2770[io][bugfix] Enable parallel grids from cake grid creator2021-08-19T15:03:49ZTimo Kochtimokoch@math.uio.no[io][bugfix] Enable parallel grids from cake grid creatorFill the factory on rank 0 and then distribute to the other ranks.
This uses the same method used for Dune::GmshReader.
Add some parallel test to make sure this works
Closes #1070Fill the factory on rank 0 and then distribute to the other ranks.
This uses the same method used for Dune::GmshReader.
Add some parallel test to make sure this works
Closes #10703.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2766New staggered facecentered discretization2021-08-21T16:13:16ZKilian WeishauptNew staggered facecentered discretizationThis MR only contains the discretization parts of !2201 in order to simplify the review.
I would suggest to merge this one here first and rebase !2201 afterwards.
@nedc @martins @timok I think it would be good if all of you have a look.This MR only contains the discretization parts of !2201 in order to simplify the review.
I would suggest to merge this one here first and rebase !2201 afterwards.
@nedc @martins @timok I think it would be good if all of you have a look.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2759[cleanup] Remove 'sequential' code2021-08-16T12:18:43ZTimo Kochtimokoch@math.uio.no[cleanup] Remove 'sequential' codeSupport is discontinued after release 3.4.
TODOs
* [x] Merge dumux-lecture!156
* [x] Add entry to changelog
* [x] Check and fix handbook and other doc for sequential
Fixes #869Support is discontinued after release 3.4.
TODOs
* [x] Merge dumux-lecture!156
* [x] Add entry to changelog
* [x] Check and fix handbook and other doc for sequential
Fixes #8693.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2758Feature/python scipts formatting linting2021-09-02T21:40:02ZTimo Kochtimokoch@math.uio.noFeature/python scipts formatting lintingFixes #1050
TODO
* [x] Make all the linters happy (`pylint` is the most difficult but has good suggestions)
* [x] Make sure the scripts are still working (some changes are at least somewhat non-trivial)
- [x] `bin/testing` (can be...Fixes #1050
TODO
* [x] Make all the linters happy (`pylint` is the most difficult but has good suggestions)
* [x] Make sure the scripts are still working (some changes are at least somewhat non-trivial)
- [x] `bin/testing` (can be decently tested by running CI with some fake change)
- [x] `bin/postprocessing` -> manual testing (partially tested)
- [x] `extract_module` -> manual testing
- [x] `create_docker` -> manual testing (partially tested)3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2737[disc] New update functions for GridGeometry classes2021-08-15T18:53:20ZMartin Schneider[disc] New update functions for GridGeometry classesTodos:
- [x] think about how md facet updates (see comment below)
- [x] Update md files of examples after changes
- [x] ~~Fix MultiDomainGG~~ -> seperate MR
Closes #1056Todos:
- [x] think about how md facet updates (see comment below)
- [x] Update md files of examples after changes
- [x] ~~Fix MultiDomainGG~~ -> seperate MR
Closes #10563.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2736Feature/simplify local view2021-08-20T16:04:14ZNed ColtmanFeature/simplify local viewFixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] ...Fixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] Go through all dumux/ headers and replace useage
- [x] Go through all test/ headers and replace useage
- [x] Add a note to the change log
- [x] Perform Benchmark to evaluate cost localview call within or outside of a element loop
- [x] Make changes according to the Benchmark results:
> Policy here:
> 1\.) If `bind(element)` is called within an `element` loop, call `auto fvGeometry = localView(gridGeometry)` before the loop.
> 2\.) If `bind(element)` is only called once (e.g. in certain functions), use the convenience syntax.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2735[parameters] Compile as separate library2021-07-29T03:52:47ZTimo Kochtimokoch@math.uio.no[parameters] Compile as separate library3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2734Draft: Resolve "extrusionFactor should be a spatial parameter interface"2022-02-22T15:00:08ZFelix WeinhardtDraft: Resolve "extrusionFactor should be a spatial parameter interface"Closes #1001Closes #10013.5Felix WeinhardtFelix Weinhardthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2733Draft: Resolve "extrusionFactor should be a spatial parameter interface"2021-07-28T10:17:47ZFelix WeinhardtDraft: Resolve "extrusionFactor should be a spatial parameter interface"Closes #1001Closes #10013.5Felix WeinhardtFelix Weinhardthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2724[disc] Add toString function for discretization method2021-07-22T11:00:06ZTimo Kochtimokoch@math.uio.no[disc] Add toString function for discretization methodThis came up for the Python bindings
!2681 but it also useful otherwise I think.This came up for the Python bindings
!2681 but it also useful otherwise I think.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2722[geomtry][distance] Add distancePointTriangle2021-07-29T15:40:18ZKilian Weishaupt[geomtry][distance] Add distancePointTriangle3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2719[components] Remove unused bool argument from gasViscosity2021-07-20T16:19:57ZKilian Weishaupt[components] Remove unused bool argument from gasViscosity3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2708Add new class for calculating wall distance2021-11-09T09:47:38ZKilian WeishauptAdd new class for calculating wall distance* Add geometry utilities for constructing spheres / bounding spheres / circumspheres (these are acutally not used by the wall distance but might be useful in the future now that they are implemented.)
* Add `closestEntity` and `distance`...* Add geometry utilities for constructing spheres / bounding spheres / circumspheres (these are acutally not used by the wall distance but might be useful in the future now that they are implemented.)
* Add `closestEntity` and `distance` queries for point and AABB trees
* Add `DistanceField` a function-like wrapper around a set of geometries to make distance queries at a given sample point
* Add `WallDistance` a class that evaluates discrete distance-to-the-mesh-boundary field at either vertex or element centers
__TODO__
- [x] better test
- [x] Maybe use in existing RANS model
- [x] fix check for UG or ALU in test
- [x] check parallelism? maybe throw
![Screenshot_2021-08-26_at_16.06.13](/uploads/66e7098269e3030b6edd0dcff95c0364/Screenshot_2021-08-26_at_16.06.13.png)3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2683[pnm][util] Add convenience python script to run poreSpy2022-04-18T19:46:40ZKilian Weishaupt[pnm][util] Add convenience python script to run poreSpy3.5Kilian WeishauptKilian Weishaupt