dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-09-16T11:22:20Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2831[material] Add option to PengRobinson::computeMolarVolume2021-09-16T11:22:20ZTimo Kochtimokoch@math.uio.no[material] Add option to PengRobinson::computeMolarVolume- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
o...- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
or the number of roots is 2 or more than 3
(no check was in place)
- Throwing NumericalProblem if the found molar volume turned
out to be zero, negative, or NaN. (Replacing assert)
- Added handleUnphysicalPhase flag (true by default). If false, the
single-root case is not checked for critical state of
the fluid (otherwise, Michelsen test for a mix of
hydrocarbons does not work).3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2827Feature/freeflow periodic2021-09-16T14:38:44ZTimo Kochtimokoch@math.uio.noFeature/freeflow periodic3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2832[component] Allow specifying dynamic _or_ kinematic viscosity for constant co...2021-09-20T07:20:56ZTimo Kochtimokoch@math.uio.no[component] Allow specifying dynamic _or_ kinematic viscosity for constant components3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2814fix/mpfa-fluxvars-caching-for-diffusion2021-09-22T11:29:52ZDennis Gläserfix/mpfa-fluxvars-caching-for-diffusionFixes #1047Fixes #10473.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2850Fix switching between isothermal and nonisothermal model in freeflow channel ...2021-09-30T13:05:00ZBernd FlemischFix switching between isothermal and nonisothermal model in freeflow channel testA preprocessor variable ISOTHERMAL was set to 0 per default in main.cc
while for switching, the variable NONISOTHERMAL was evaluated.
To fix, set NONISOTHERMAL instead of ISOTHERMAL in main.cc.A preprocessor variable ISOTHERMAL was set to 0 per default in main.cc
while for switching, the variable NONISOTHERMAL was evaluated.
To fix, set NONISOTHERMAL instead of ISOTHERMAL in main.cc.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2851Feature/test detection cmakelists2021-09-30T14:52:33ZTimo Kochtimokoch@math.uio.noFeature/test detection cmakelistsMark tests as affected if the CMakeLists.txt file changedMark tests as affected if the CMakeLists.txt file changed3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2837Consistent naming in test/references2021-09-30T17:31:42ZFarid MohammadiConsistent naming in test/referencesCloses #1077Closes #10773.5Farid MohammadiFarid Mohammadihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2781[ci] Test with dune 2.8 instead of dune 2.72021-09-30T18:37:36ZTimo Kochtimokoch@math.uio.no[ci] Test with dune 2.8 instead of dune 2.73.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2841[ff/channel/pipe] Port ff-channel-pipe case to staggered grid2021-10-01T22:07:48ZHanchuan Wu[ff/channel/pipe] Port ff-channel-pipe case to staggered grid#1081#10813.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2858Remove template argument PrimaryVariables from ShallowWaterViscousFlux2021-10-02T11:01:08ZMartin UtzRemove template argument PrimaryVariables from ShallowWaterViscousFluxThe template argument PrimaryVariables is not needed and can be therefore
removed as discussed with @timok in !2824The template argument PrimaryVariables is not needed and can be therefore
removed as discussed with @timok in !28243.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2845[port] channel/1d to new staggered2021-10-02T11:17:04ZRoman Winter[port] channel/1d to new staggeredPorted channel/1d to new staggeredPorted channel/1d to new staggered3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2870[navierstokes][problem] Do not expose discretization methods in problem2021-10-16T16:11:14ZTimo Kochtimokoch@math.uio.no[navierstokes][problem] Do not expose discretization methods in problemThis created some unresolved dependenices due to the cyclic interdependency
of problem and coupling manager. This worked before because the discretizaiton
method was always one specific type. With tags the actual type has to be known,
so...This created some unresolved dependenices due to the cyclic interdependency
of problem and coupling manager. This worked before because the discretizaiton
method was always one specific type. With tags the actual type has to be known,
so both problems and the coupling manager have to be instatiated before this
information can be accessed.3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2871Feature/new staggered small fixes2021-10-17T17:49:44ZTimo Kochtimokoch@math.uio.noFeature/new staggered small fixes3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2872[couplingmanager] Use raw pointer to sub-problems2021-10-18T20:59:11ZTimo Kochtimokoch@math.uio.no[couplingmanager] Use raw pointer to sub-problemsThe pointer were previously managed by weak_ptr. As it turns out,
the interface obtaining the sub-problems is called very often in typical applications,
and can impact runtime. We therefore make it more efficient by using raw pointers
an...The pointer were previously managed by weak_ptr. As it turns out,
the interface obtaining the sub-problems is called very often in typical applications,
and can impact runtime. We therefore make it more efficient by using raw pointers
and refrain from using exception handling. In the case that the sub-problem pointers are not set,
an assert will be triggered in debug mode.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2874[md][couplingmanager] Fix nullptr initialization of problem2021-10-18T16:28:31ZTimo Kochtimokoch@math.uio.no[md][couplingmanager] Fix nullptr initialization of problemRemove unncessary capture for init lambda functionsRemove unncessary capture for init lambda functions3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2842Cleanup/port angeli test2021-10-18T19:28:14ZKatharina HeckCleanup/port angeli testthis is related to #1081.
useNeumann is added but not currently testedthis is related to #1081.
useNeumann is added but not currently tested3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2876[fcstaggered] Use reference element for index mapping2021-10-18T19:49:37ZTimo Kochtimokoch@math.uio.no[fcstaggered] Use reference element for index mappingSome grid managers only support subIndex for elements.
Using the reference element we obtain the vertex indices
via local index maps.Some grid managers only support subIndex for elements.
Using the reference element we obtain the vertex indices
via local index maps.3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2879[flux] Add headers with declarations/primary templates/alias only2021-10-19T11:12:47ZTimo Kochtimokoch@math.uio.no[flux] Add headers with declarations/primary templates/alias only3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2882[momentum][fluxhelper][cleanup] Use naming scheme conforming variable names2021-10-19T11:17:57ZTimo Kochtimokoch@math.uio.no[momentum][fluxhelper][cleanup] Use naming scheme conforming variable names3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2826[md][ff-pm] Add freeflow porous medium coupling managers and test2021-10-19T12:06:20ZTimo Kochtimokoch@math.uio.no[md][ff-pm] Add freeflow porous medium coupling managers and testPart of merging !2201 in smaller parts.
Improvement in comparison to old convergence test:
* Add stress tensor for analytical solutions
* add tests for dirichlet, neumann and mixed dirichlet-neumann boundaries in both domains
* test al...Part of merging !2201 in smaller parts.
Improvement in comparison to old convergence test:
* Add stress tensor for analytical solutions
* add tests for dirichlet, neumann and mixed dirichlet-neumann boundaries in both domains
* test all implemented analytical solutions
TODO
* [x] Coupling manager: Make interface smaller (private) whereever possible
* [x] Fix updateCouplingContext3.5Dennis GläserDennis Gläser