dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-10-26T16:20:45Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2903[cmake] Several smaller cleanups2021-10-26T16:20:45ZTimo Kochtimokoch@math.uio.no[cmake] Several smaller cleanupsMake CMake slightly less verbose and fix some warningsMake CMake slightly less verbose and fix some warnings3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2832[component] Allow specifying dynamic _or_ kinematic viscosity for constant co...2021-09-20T07:20:56ZTimo Kochtimokoch@math.uio.no[component] Allow specifying dynamic _or_ kinematic viscosity for constant components3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3012Component-aware dispersion2022-03-31T14:16:48ZDmitry PavlovComponent-aware dispersionIt will be useful to allow different dispersion parameters for different components, even when they are in one phase. For instance, single-well chemical tracer tests are usually modeled in one phase (oil is immobile), but dispersion coef...It will be useful to allow different dispersion parameters for different components, even when they are in one phase. For instance, single-well chemical tracer tests are usually modeled in one phase (oil is immobile), but dispersion coefficients for different components are different.
See e.g. [this article](
https://doi.org/10.2118/129724-MS
): "Dispersivity is taken to be a history match parameter and can be different for each tracer".
Fixes #11043.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2719[components] Remove unused bool argument from gasViscosity2021-07-20T16:19:57ZKilian Weishaupt[components] Remove unused bool argument from gasViscosity3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2837Consistent naming in test/references2021-09-30T17:31:42ZFarid MohammadiConsistent naming in test/referencesCloses #1077Closes #10773.5Farid MohammadiFarid Mohammadihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2872[couplingmanager] Use raw pointer to sub-problems2021-10-18T20:59:11ZTimo Kochtimokoch@math.uio.no[couplingmanager] Use raw pointer to sub-problemsThe pointer were previously managed by weak_ptr. As it turns out,
the interface obtaining the sub-problems is called very often in typical applications,
and can impact runtime. We therefore make it more efficient by using raw pointers
an...The pointer were previously managed by weak_ptr. As it turns out,
the interface obtaining the sub-problems is called very often in typical applications,
and can impact runtime. We therefore make it more efficient by using raw pointers
and refrain from using exception handling. In the case that the sub-problem pointers are not set,
an assert will be triggered in debug mode.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2905Deprecate the shell scripts2021-10-28T08:45:56ZFarid MohammadiDeprecate the shell scriptsCloses #883
TODO:
- [x] Deprecation warning in python for `bin/util/test_dumux.sh`
- [x] Deprecate the following scripts:
1. [compareparameters.sh](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/doc/comp...Closes #883
TODO:
- [x] Deprecation warning in python for `bin/util/test_dumux.sh`
- [x] Deprecate the following scripts:
1. [compareparameters.sh](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/doc/compareparameters.sh)
2. [replace_property_macros.sh](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/util/replace_property_macros.sh)
- [x] Add changes in the `CHANGELOG.md`3.5Farid MohammadiFarid Mohammadihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2724[disc] Add toString function for discretization method2021-07-22T11:00:06ZTimo Kochtimokoch@math.uio.no[disc] Add toString function for discretization methodThis came up for the Python bindings
!2681 but it also useful otherwise I think.This came up for the Python bindings
!2681 but it also useful otherwise I think.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2737[disc] New update functions for GridGeometry classes2021-08-15T18:53:20ZMartin Schneider[disc] New update functions for GridGeometry classesTodos:
- [x] think about how md facet updates (see comment below)
- [x] Update md files of examples after changes
- [x] ~~Fix MultiDomainGG~~ -> seperate MR
Closes #1056Todos:
- [x] think about how md facet updates (see comment below)
- [x] Update md files of examples after changes
- [x] ~~Fix MultiDomainGG~~ -> seperate MR
Closes #10563.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2921Dispersion2021-11-24T10:35:59ZNed ColtmanDispersionaddresses #320
Only existing dispersion test is on dumux-lecture (Henry Problem)
- [x] Implement compositional dispersion
- [x] Implement thermal dispersion
- [x] Scheidegger dispersion tensor
- [x] FullTensor dispersion tensor
- [x]...addresses #320
Only existing dispersion test is on dumux-lecture (Henry Problem)
- [x] Implement compositional dispersion
- [x] Implement thermal dispersion
- [x] Scheidegger dispersion tensor
- [x] FullTensor dispersion tensor
- [x] guard against multiphase and non-box methods
- [x] Add for tracer models compositional, and isothermal models
- [x] Add compiler time catches for missing properties, and add warnings
- [x] update dumux-lecture!170
- [x] Implement and test for TPFA constvelocity
- [x] Add changelog entry for this new feature
To test:
- [x] Thermal dispersion
- [x] Compositional dispersion flux
- [x] Scheidegger tensor from box velocity
- [x] Scheidegger tensor from tracer velocity (constant)
- [x] Open Tensor from input file vector
- [x] Open Tensor from input file scalar3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3042[doc] add equations of geomechanics models in doxygen2022-04-26T11:20:35ZYue Wangyue.wang@iws.uni-stuttgart.de[doc] add equations of geomechanics models in doxygenFixes #1139Fixes #11393.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3029[doc][doxygen] Cleanup, especially of modules.txt and ingroups.2022-03-02T08:05:38ZMelanie Lipp[doc][doxygen] Cleanup, especially of modules.txt and ingroups.Introduces new groups in modules.txt according to the changed folder structure.
Corrects some ingroups.
Removes some superfluous \file.
Corrects other small doxygen issues (some missing documentation and some wrong copydoc reference).
...Introduces new groups in modules.txt according to the changed folder structure.
Corrects some ingroups.
Removes some superfluous \file.
Corrects other small doxygen issues (some missing documentation and some wrong copydoc reference).
Closes #11313.5Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3061[doc][doxygen] Improve documentation2022-04-25T12:00:49ZMelanie Lipp[doc][doxygen] Improve documentation- Reduces doxyerr.log
- Improves formulae in `dumux/material/components/simpleh2o.hh`- Reduces doxyerr.log
- Improves formulae in `dumux/material/components/simpleh2o.hh`3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3027Doc/reduce doxyerr log2022-02-23T17:50:52ZMelanie LippDoc/reduce doxyerr log**What this MR does / why does DuMux need it**: Reduces error messages in doxyerr.log to only two lines:
```
/temp1/melaniel/dumux1/dumux/dumux/discretization/cellcentered/elementsolution.hh:144: warning: Member documentation for element...**What this MR does / why does DuMux need it**: Reduces error messages in doxyerr.log to only two lines:
```
/temp1/melaniel/dumux1/dumux/dumux/discretization/cellcentered/elementsolution.hh:144: warning: Member documentation for elementSolution found several times in @ingroup groups!
/temp1/melaniel/dumux1/dumux/dumux/discretization/staggered/elementsolution.hh:62: The member will remain in group CCDiscretization, and won't be put into group StaggeredDiscretization
```
which are lines that we already have not been able to get rid of in previous releases.3.5Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3128[docs] Update Python setup2022-05-27T10:25:33ZTimo Kochtimokoch@math.uio.no[docs] Update Python setup3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3088[doc] update license2022-05-03T17:06:05ZYue Wangyue.wang@iws.uni-stuttgart.de[doc] update licenseUpdate the licenseUpdate the license3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3062[example][biomineralization][material][co2] use new type of CO2 tables,...2022-04-25T13:49:05ZJohannes Hommel[example][biomineralization][material][co2] use new type of CO2 tables,...[example][biomineralization][material][co2] use new type of CO2 tables, generated from NIST homepage
Fixes #1143[example][biomineralization][material][co2] use new type of CO2 tables, generated from NIST homepage
Fixes #11433.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3030Examples for Dumux 3.52022-03-28T09:53:54ZSina AckermannExamples for Dumux 3.5- [x] update READMEs according to latest commits (code changes)
- [x] check if everything compiles and runs (tests)- [x] update READMEs according to latest commits (code changes)
- [x] check if everything compiles and runs (tests)3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3112[examples/liddriven] update doc2022-05-13T08:27:17ZYue Wangyue.wang@iws.uni-stuttgart.de[examples/liddriven] update doc3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3154[facecentered][convexcorner] fix the local Index logic2024-01-31T10:44:58ZNed Coltman[facecentered][convexcorner] fix the local Index logic<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
I've come across an error whil...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
I've come across an error while using the new face centered staggered scheme. For convex corner geometries, `localIndexOutsideScvfWithSameIntegrationPoint(scvf)` is called from the `outsideScvfWithSameIntegrationPoint(scvf) ` in the `fluxvariables`. The logic doesn't seem to be fool proof, in particular for the scvf with the local index 10.
As 10 is an even number, the function returns an index of 13, which does not typically exist, outside of elements with 2+ boundary faces.
This change should fix this for the local index of 10.
As a reference, here is a confusing quick drawing with all of the local scvf indexes.
![temp_localscvfidx](/uploads/26ec6ff585f142d3bf8fa9bc516c9b07/temp_localscvfidx.png)
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
I believe that this has not been identified yet because we do not have many new freeflow tests with convex corner geometries, especially where the scvf with local index 10 would be involved.
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.de