dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-05-03T17:07:17Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3094Merge branch 'bugfix/gridgeometry-thread-safe-lazy-initializer' into 'master'2022-05-03T17:07:17ZDennis GläserMerge branch 'bugfix/gridgeometry-thread-safe-lazy-initializer' into 'master'Bugfix/gridgeometry thread safe lazy initializer
Closes #1148
See merge request dumux-repositories/dumux!3087
(cherry picked from commit 2e85f7b164d540d402ed284d44ef0acbff90c231)
74a66846 [doc][gridgeometry] Fix typos in code doc
a63...Bugfix/gridgeometry thread safe lazy initializer
Closes #1148
See merge request dumux-repositories/dumux!3087
(cherry picked from commit 2e85f7b164d540d402ed284d44ef0acbff90c231)
74a66846 [doc][gridgeometry] Fix typos in code doc
a63f1f40 [bugfix][gridgeometry] Make lazy initializer of elementMap/bBoxTree thread-safe3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3091Merge branch 'feature/spatialparams_python' into 'master'2022-05-02T19:49:07ZYue Wangyue.wang@iws.uni-stuttgart.deMerge branch 'feature/spatialparams_python' into 'master'Spatial parameters for Python bindings
Closes #1145
See merge request dumux-repositories/dumux!3069
(cherry picked from commit 790bdaeeea272a72c94facb388db0f462a54b498)
8e464d6c [dumux][python][spatialparams] update the problem and s...Spatial parameters for Python bindings
Closes #1145
See merge request dumux-repositories/dumux!3069
(cherry picked from commit 790bdaeeea272a72c94facb388db0f462a54b498)
8e464d6c [dumux][python][spatialparams] update the problem and spatialparams classes
2e25f728 [python][material] remove old spatial params files
56a3c69b [python] Make spatialparams optional and make separate modules in python/common
97d568bb [python] Make spatial params const again3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3090Merge branch 'fix/install-cmake-module-files' into 'master'2022-05-03T17:06:54ZDennis GläserMerge branch 'fix/install-cmake-module-files' into 'master'[cmake] install all modules
See merge request dumux-repositories/dumux!3086
(cherry picked from commit ce04073336b11f43fac4a85a36c41e024ec1ca9d)
2baf1cf0 [cmake] install all modules[cmake] install all modules
See merge request dumux-repositories/dumux!3086
(cherry picked from commit ce04073336b11f43fac4a85a36c41e024ec1ca9d)
2baf1cf0 [cmake] install all modules3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3089Merge branch 'doc/update-license' into 'master'2022-05-04T14:25:25ZTimo Kochtimokoch@math.uio.noMerge branch 'doc/update-license' into 'master'[doc] update license
See merge request dumux-repositories/dumux!3088
(cherry picked from commit 29888d4f27c38cc5f5c6e58d7a35bada8a9a0f00)
5d05bb2b [doc] update license[doc] update license
See merge request dumux-repositories/dumux!3088
(cherry picked from commit 29888d4f27c38cc5f5c6e58d7a35bada8a9a0f00)
5d05bb2b [doc] update license3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3085Merge branch 'feature/improve-2p2c-doc' into 'master'2022-05-02T13:43:51ZYue Wangyue.wang@iws.uni-stuttgart.deMerge branch 'feature/improve-2p2c-doc' into 'master'[2p2c][doc] rewrite model documentation
See merge request dumux-repositories/dumux!3056
(cherry picked from commit 6a70b718e702eb971798a7b9e0d788e5280ca97c)
fcec69e3 [doc][2p2c] rephrase/rearrange docu[2p2c][doc] rewrite model documentation
See merge request dumux-repositories/dumux!3056
(cherry picked from commit 6a70b718e702eb971798a7b9e0d788e5280ca97c)
fcec69e3 [doc][2p2c] rephrase/rearrange docu3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3084Merge branch 'feature/update-install-script' into 'master'2022-05-02T15:53:20ZYue Wangyue.wang@iws.uni-stuttgart.deMerge branch 'feature/update-install-script' into 'master'[script/handbook] update release branch in script
See merge request dumux-repositories/dumux!3082
(cherry picked from commit 1510b4c1c6c4e87e37b3e55a6c72b063822487f1)
82b763ba [script/handbook] update release branch in script[script/handbook] update release branch in script
See merge request dumux-repositories/dumux!3082
(cherry picked from commit 1510b4c1c6c4e87e37b3e55a6c72b063822487f1)
82b763ba [script/handbook] update release branch in script3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3079Merge branch 'fix/tpfa-grid-geom-update' into 'master'2022-04-29T13:16:18ZTimo Kochtimokoch@math.uio.noMerge branch 'fix/tpfa-grid-geom-update' into 'master'[tpfa][gg] Make sure hasBoundaryScvf_ is properly reinitialized in update
See merge request dumux-repositories/dumux!3078
(cherry picked from commit c3d34b76df1e8c68d8c2166528969f070d60123c)
8290dd27 [tpfa][gg] Make sure hasBoundarySc...[tpfa][gg] Make sure hasBoundaryScvf_ is properly reinitialized in update
See merge request dumux-repositories/dumux!3078
(cherry picked from commit c3d34b76df1e8c68d8c2166528969f070d60123c)
8290dd27 [tpfa][gg] Make sure hasBoundaryScvf_ is properly reinitialized in update
6f62f830 [tpfa][gg] Fix typos3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3075Merge branch 'feature/headercheck' into 'master'2022-04-29T11:04:52ZTimo Kochtimokoch@math.uio.noMerge branch 'feature/headercheck' into 'master'Feature/headercheck
See merge request dumux-repositories/dumux!3064
(cherry picked from commit 5d0f02e01cd3e3a0351bc4446b1dcf48cf662072)
50208e7a [headercheck] add missing headersFeature/headercheck
See merge request dumux-repositories/dumux!3064
(cherry picked from commit 5d0f02e01cd3e3a0351bc4446b1dcf48cf662072)
50208e7a [headercheck] add missing headers3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3074Merge branch 'update/changelog' into 'master'2022-04-29T09:12:27ZTimo Kochtimokoch@math.uio.noMerge branch 'update/changelog' into 'master'Update changelog
See merge request dumux-repositories/dumux!3073
(cherry picked from commit 837c929b383a5408fe25da58703e887fc1ee337b)
f1ffe1da Update changelogUpdate changelog
See merge request dumux-repositories/dumux!3073
(cherry picked from commit 837c929b383a5408fe25da58703e887fc1ee337b)
f1ffe1da Update changelog3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3072Merge branch 'fix/deprecated-attribute' into 'master'2022-04-27T10:43:24ZTimo Kochtimokoch@math.uio.noMerge branch 'fix/deprecated-attribute' into 'master'[material][pnm] Fix position of deprecated attribute
See merge request dumux-repositories/dumux!3071
(cherry picked from commit ff1dc267196a4a3d5fa5586e19f994dd04028856)
6697fb50 [material][pnm] Fix position of deprecated attribute[material][pnm] Fix position of deprecated attribute
See merge request dumux-repositories/dumux!3071
(cherry picked from commit ff1dc267196a4a3d5fa5586e19f994dd04028856)
6697fb50 [material][pnm] Fix position of deprecated attribute3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3154[facecentered][convexcorner] fix the local Index logic2024-01-31T10:44:58ZNed Coltman[facecentered][convexcorner] fix the local Index logic<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
I've come across an error whil...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
I've come across an error while using the new face centered staggered scheme. For convex corner geometries, `localIndexOutsideScvfWithSameIntegrationPoint(scvf)` is called from the `outsideScvfWithSameIntegrationPoint(scvf) ` in the `fluxvariables`. The logic doesn't seem to be fool proof, in particular for the scvf with the local index 10.
As 10 is an even number, the function returns an index of 13, which does not typically exist, outside of elements with 2+ boundary faces.
This change should fix this for the local index of 10.
As a reference, here is a confusing quick drawing with all of the local scvf indexes.
![temp_localscvfidx](/uploads/26ec6ff585f142d3bf8fa9bc516c9b07/temp_localscvfidx.png)
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
I believe that this has not been identified yet because we do not have many new freeflow tests with convex corner geometries, especially where the scvf with local index 10 would be involved.
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3146[richards][fluidsystems] Fix static assert in Richards and implement...2022-06-01T18:51:46ZTimo Kochtimokoch@math.uio.no[richards][fluidsystems] Fix static assert in Richards and implement...[richards][fluidsystems] Fix static assert in Richards and implement H2OAir::viscosityIsConstant interface[richards][fluidsystems] Fix static assert in Richards and implement H2OAir::viscosityIsConstant interface3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3135[fix] conditional return type in function outsideScvfWithSameIntegrationPoint2022-05-31T17:04:30ZYue Wangyue.wang@iws.uni-stuttgart.de[fix] conditional return type in function outsideScvfWithSameIntegrationPointfixes #1159fixes #11593.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3134Fix/velocity output2022-05-31T07:40:58ZYue Wangyue.wang@iws.uni-stuttgart.deFix/velocity outputfixes #1161fixes #11613.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3124[box][localfiniteelementcache] Use thread-safe version of the local finite el...2022-05-27T08:31:04ZTimo Kochtimokoch@math.uio.no[box][localfiniteelementcache] Use thread-safe version of the local finite element cacheTODO:
- [x] get rid of the construction of `FECache` in box-eval-solution (@DennisGlaeser)
Fixes #1153TODO:
- [x] get rid of the construction of `FECache` in box-eval-solution (@DennisGlaeser)
Fixes #11533.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3106[fix] correct the type and value in getParam2022-05-11T09:13:47ZYue Wangyue.wang@iws.uni-stuttgart.de[fix] correct the type and value in getParamfixes the some default value and paramter type in getParamfixes the some default value and paramter type in getParam3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3104[material] Fix parameter type in spline material law2022-05-10T13:03:35ZTimo Kochtimokoch@math.uio.no[material] Fix parameter type in spline material law3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3099Move fmt to Dumux namespace2022-05-11T07:18:30ZBernd FlemischMove fmt to Dumux namespaceBy moving the fmt implementation to the namespace Dumux, clashes with existing upstream and downstream implementations can be avoided. This way it can be used e.g. together with OPM which defines symbols in the fmt namespace.
Fixes #1150.By moving the fmt implementation to the namespace Dumux, clashes with existing upstream and downstream implementations can be avoided. This way it can be used e.g. together with OPM which defines symbols in the fmt namespace.
Fixes #1150.3.5Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3095[bugfix][gridgeometry] Always construct bboxtree and element map2022-05-04T11:01:48ZTimo Kochtimokoch@math.uio.no[bugfix][gridgeometry] Always construct bboxtree and element mapA thread-safe implementation with double-checked lock needs atomic load/store
operations to update the pointer to be thread-safe. Alternatively, a lock
has to be acquired every time when the function is called. Both implementations
impai...A thread-safe implementation with double-checked lock needs atomic load/store
operations to update the pointer to be thread-safe. Alternatively, a lock
has to be acquired every time when the function is called. Both implementations
impair the scalability of the multihreaded assembly (in the case of tpfa, or
any simulation that uses element maps or bounding box tree on an element level).
This changes the beahviour to always build the tree and the element map. This
usually occurs little runtime overhead in cases where the features are unused.
It is the most performant version as soon as one of the features is used.
There is however some memory overhead in the order of one or more ints per
element (seeds) and a bounding box hierarchy.
Fixes #11513.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3087Bugfix/gridgeometry thread safe lazy initializer2022-05-04T11:01:47ZTimo Kochtimokoch@math.uio.noBugfix/gridgeometry thread safe lazy initializerFixes #1148Fixes #11483.5Dennis GläserDennis Gläser