dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-04-07T11:17:20Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3031Modify the bed shear stress calculation within the shallow water friction laws.2022-04-07T11:17:20ZMartin UtzModify the bed shear stress calculation within the shallow water friction laws.The function `shearStress` returns the bed shear stress normalized by the water density. This normalisation is unfavourable, since the name of the function (and also the documentation) does not reflect it. Also the name `shearStress` its...The function `shearStress` returns the bed shear stress normalized by the water density. This normalisation is unfavourable, since the name of the function (and also the documentation) does not reflect it. Also the name `shearStress` itself is confusing, since the bed shear stress is not a classical shear stress tensor. The name `bedShearStress` is more clear, since it points to the context of shallow water equations.
TODOs:
- [x] Modify the function `shearStress` to return the bed shear stress and not the bed shear stress normalized by the water density.
- [x] Return the positive shear stress
- [x] Rename `shearStress` to `bedShearStress`
- [x] Improve docs3.5Martin UtzMartin Utzhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3030Examples for Dumux 3.52022-03-28T09:53:54ZSina AckermannExamples for Dumux 3.5- [x] update READMEs according to latest commits (code changes)
- [x] check if everything compiles and runs (tests)- [x] update READMEs according to latest commits (code changes)
- [x] check if everything compiles and runs (tests)3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3029[doc][doxygen] Cleanup, especially of modules.txt and ingroups.2022-03-02T08:05:38ZMelanie Lipp[doc][doxygen] Cleanup, especially of modules.txt and ingroups.Introduces new groups in modules.txt according to the changed folder structure.
Corrects some ingroups.
Removes some superfluous \file.
Corrects other small doxygen issues (some missing documentation and some wrong copydoc reference).
...Introduces new groups in modules.txt according to the changed folder structure.
Corrects some ingroups.
Removes some superfluous \file.
Corrects other small doxygen issues (some missing documentation and some wrong copydoc reference).
Closes #11313.5Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3026Fix/extract module script missing macro2022-02-23T20:26:33ZHanchuan WuFix/extract module script missing macroFixes #1064Fixes #10643.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3025[cleanup] Remove unused header2022-02-22T16:31:27ZTimo Kochtimokoch@math.uio.no[cleanup] Remove unused header3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3022Update/freeflow spatialparams2022-02-17T14:26:51ZNed ColtmanUpdate/freeflow spatialparamsfixes #1125fixes #11253.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3021[cleanup] Remove outdated and falsified comment2022-02-15T15:24:24ZTimo Kochtimokoch@math.uio.no[cleanup] Remove outdated and falsified commentFixes #1124Fixes #11243.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3020[ffpm][coupling] Use problem reference directly2022-02-10T17:05:01ZTimo Kochtimokoch@math.uio.no[ffpm][coupling] Use problem reference directlyThe base class no longer uses weak_ptr so this is just directly accessing the problem pointerThe base class no longer uses weak_ptr so this is just directly accessing the problem pointer3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3018[pnm][fluxcache] Improve readability2022-02-10T16:36:04ZTimo Kochtimokoch@math.uio.no[pnm][fluxcache] Improve readabilityRemove warning, this consistency check makes always sense. I don't think we need to issue a warning here.Remove warning, this consistency check makes always sense. I don't think we need to issue a warning here.3.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3013[cleanup] Remove deprecated and unused heatpipelawparams.hh2022-02-07T12:54:13ZTimo Kochtimokoch@math.uio.no[cleanup] Remove deprecated and unused heatpipelawparams.hh3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3012Component-aware dispersion2022-03-31T14:16:48ZDmitry PavlovComponent-aware dispersionIt will be useful to allow different dispersion parameters for different components, even when they are in one phase. For instance, single-well chemical tracer tests are usually modeled in one phase (oil is immobile), but dispersion coef...It will be useful to allow different dispersion parameters for different components, even when they are in one phase. For instance, single-well chemical tracer tests are usually modeled in one phase (oil is immobile), but dispersion coefficients for different components are different.
See e.g. [this article](
https://doi.org/10.2118/129724-MS
): "Dispersivity is taken to be a history match parameter and can be different for each tracer".
Fixes #11043.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3011Surfactant test2022-02-23T22:19:46ZDmitry PavlovSurfactant testTest of surfactant injection in porous medium (2p2c). Surfactant model is loosely based on the one described [here](https://www.sintef.no/contentassets/0d97862cef164d1c965d268ce5e4e082/surfactant_model.pdf). (Also see [here](https://ntnu...Test of surfactant injection in porous medium (2p2c). Surfactant model is loosely based on the one described [here](https://www.sintef.no/contentassets/0d97862cef164d1c965d268ce5e4e082/surfactant_model.pdf). (Also see [here](https://ntnuopen.ntnu.no/ntnu-xmlui/handle/11250/240038) for a longer version). This test will not work without [MR 2914](!2914).3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3005Add graph partitioning via Scotch2022-04-18T11:53:26ZLarissa BrencherAdd graph partitioning via ScotchTask: Implement graph partitioning via PT-Scotch package and use the resulting partitioning for UG's load balancer
Fixes #812, fixes #1110
- [x] ~~parallelization (change graph to dgraph)~~ -> #1141
- [x] extract as header file
- [x] ...Task: Implement graph partitioning via PT-Scotch package and use the resulting partitioning for UG's load balancer
Fixes #812, fixes #1110
- [x] ~~parallelization (change graph to dgraph)~~ -> #1141
- [x] extract as header file
- [x] write tests3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3004Feature/geomechanics fluid props in spatial params2022-02-13T12:00:26ZDennis GläserFeature/geomechanics fluid props in spatial paramsTODO:
- [x] adjust all poroelastic tests to avoid compiler warnings
- [x] changelog entry
Fixes #1113TODO:
- [x] adjust all poroelastic tests to avoid compiler warnings
- [x] changelog entry
Fixes #11133.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3003Suppress RANS compiler warnings for clang2022-01-28T14:25:15ZNed ColtmanSuppress RANS compiler warnings for clangThis should clean up the compiler warnings that occur with the rans tests when compiled with Clang.
Based on:
https://stackoverflow.com/questions/14065844/how-to-suppress-the-deprecation-warning-dispatch-get-current-queue-is-depreca
an...This should clean up the compiler warnings that occur with the rans tests when compiled with Clang.
Based on:
https://stackoverflow.com/questions/14065844/how-to-suppress-the-deprecation-warning-dispatch-get-current-queue-is-depreca
and !2888
Not sure if there is a neater way to do this. Macros are always pretty ugly, and these are particularly gnarly looking.3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3000Update the employed OPM version to 2021.102022-02-23T16:57:47ZBernd FlemischUpdate the employed OPM version to 2021.10An interface change requires the adaptation of the OPM grid manager. On some systems, opm-common needs to be patched. The adaption is documented in the changelog and the installexternal script.An interface change requires the adaptation of the OPM grid manager. On some systems, opm-common needs to be patched. The adaption is documented in the changelog and the installexternal script.3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2999[mpnc] include a dune throw for zero fugacity coefficients as the mpnc model ...2022-04-14T07:51:48ZKatharina Heck[mpnc] include a dune throw for zero fugacity coefficients as the mpnc model does not work with zero fugacity coefficientsfixes #1084
This includes a check for all fugacity coefficients that they are not 0.fixes #1084
This includes a check for all fugacity coefficients that they are not 0.3.5Theresa SchollenbergerTheresa Schollenbergerhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2998Update parallel computation section in handbook2022-02-03T15:52:47ZMartin UtzUpdate parallel computation section in handbookCloses #1120Closes #11203.5Martin UtzMartin Utzhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2996Improve PNM grid creator2022-04-05T09:11:16ZKilian WeishauptImprove PNM grid creator3.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2994Cleanup: Rans velocity gradient function and IO fields2022-02-24T16:42:48ZNed ColtmanCleanup: Rans velocity gradient function and IO fields@anna_m_kostelecky pointed the following issues out yesterday during a meeting.
- The indices in the `velocityGradient(elementIdx, velIdx, dimIdx)` function within the rans problem were backwards
- The IO fields for the rans problem li...@anna_m_kostelecky pointed the following issues out yesterday during a meeting.
- The indices in the `velocityGradient(elementIdx, velIdx, dimIdx)` function within the rans problem were backwards
- The IO fields for the rans problem list the velocity gradients for all directions as "dv/dx_" with a trailing index (0,1,2). An "s", for spatial, rather than the "x" would be more fitting.
@tschol, I wouldn't blame you if you had ignored that part of conversation, but as you were there during the meeting I would assign you? Otherwise after the pipeline passes, anyone could merge this.3.5Sina AckermannSina Ackermann