dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-09-10T08:55:21Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2780Fix/staggered fcdiscretization2021-09-10T08:55:21ZTimo Kochtimokoch@math.uio.noFix/staggered fcdiscretizationSome followup fixes for bugs overlooked in !2766Some followup fixes for bugs overlooked in !27663.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2778[navierstokes][iofields] Fix for non-staggered models2021-08-20T19:57:42ZTimo Kochtimokoch@math.uio.no[navierstokes][iofields] Fix for non-staggered models3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2770[io][bugfix] Enable parallel grids from cake grid creator2021-08-19T15:03:49ZTimo Kochtimokoch@math.uio.no[io][bugfix] Enable parallel grids from cake grid creatorFill the factory on rank 0 and then distribute to the other ranks.
This uses the same method used for Dune::GmshReader.
Add some parallel test to make sure this works
Closes #1070Fill the factory on rank 0 and then distribute to the other ranks.
This uses the same method used for Dune::GmshReader.
Add some parallel test to make sure this works
Closes #10703.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2600Fix/tabulated2dfunction2021-06-28T11:57:12ZDmitry PavlovFix/tabulated2dfunctionThere are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That ...There are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That needs to be fixed.
The second issue is the following code in get():
```c++
int i = max(0, min(m_, static_cast<int>(alpha)));
int j = max(0, min(n_, static_cast<int>(beta)));
```
With `x == xMax`, alpha will be as big as (`m_- 1`) even after the proposed fix to `xToI`. But we need an interval number here, not a point number, and there is no (`m_- 1`)-th interval (not to mention `_m`-th). So we need to cut `i` at (`m_ - 2`). Similarly with `j`.
Without the fix, the assertions in `getSamplePoint`
```c++
assert(0 <= i && i < m_);
assert(0 <= j && j < n_);
```
rightfully fail when `x` is close to `xMax` or `y` is close to `yMax`.
TODO:
* [ ] Check which tests are affected3.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3157reorder changelog2022-06-02T11:50:52ZBernd Flemischreorder changelogReorder the changes from 3.4 to 3.5 in the changelog.Reorder the changes from 3.4 to 3.5 in the changelog.3.5Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3147[python][linter] Fix pylint warning appearing with newer version2022-06-01T16:57:36ZTimo Kochtimokoch@math.uio.no[python][linter] Fix pylint warning appearing with newer version3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3145[test][1pnc] Improve Maxwell-Stefan test2022-06-01T19:54:38ZTimo Kochtimokoch@math.uio.no[test][1pnc] Improve Maxwell-Stefan testMake test more robust by
* fixing output interval so always the same number of outputs are written
* use fixed time step size
Decrease runtime by only using 1 cell in y-direction.
We test in 2D to test the model in 2D but the specific ...Make test more robust by
* fixing output interval so always the same number of outputs are written
* use fixed time step size
Decrease runtime by only using 1 cell in y-direction.
We test in 2D to test the model in 2D but the specific setup is
one-dimensional so the added cells can be spared.
The new reference solution was created with a timestep
of 5s. The test uses a timestep of 25s which still
reproduces and accurate enough solution so the
comparison passes.
Fixes #11583.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3144[1pnc] Remove delp from default output2022-06-01T18:00:18ZTimo Kochtimokoch@math.uio.no[1pnc] Remove delp from default outputdelp is not generally a useful output in particular since -1e5 is hard-coded as offset.
In case of small pressure changes this output also suffers from possible large rounding errors
since p is the primary variables and -1e5 might result...delp is not generally a useful output in particular since -1e5 is hard-coded as offset.
In case of small pressure changes this output also suffers from possible large rounding errors
since p is the primary variables and -1e5 might result in 5 insifgnificant digits.
No other model has this default output field. Hence, this makes
output more consistent across models.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3131[intersectingentities] Return const& to corner storage2022-05-30T09:20:40ZTimo Kochtimokoch@math.uio.no[intersectingentities] Return const& to corner storageThis avoids making a copy of the vectorThis avoids making a copy of the vector3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3130[fix] use referece instead of copy in loop2022-05-25T18:23:22ZYue Wang[fix] use referece instead of copy in loop3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3128[docs] Update Python setup2022-05-27T10:25:33ZTimo Kochtimokoch@math.uio.no[docs] Update Python setup3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3126Use reference instead of copy in for loop in coupling manager2022-05-25T23:10:29ZBernd FlemischUse reference instead of copy in for loop in coupling managerAvoid a compiler warning from gcc 11 in test_md_boundary_ff1p_pnm1p.Avoid a compiler warning from gcc 11 in test_md_boundary_ff1p_pnm1p.3.5Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3112[examples/liddriven] update doc2022-05-13T08:27:17ZYue Wang[examples/liddriven] update doc3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3103Fix some compiler warnings2022-05-13T11:39:36ZYue WangFix some compiler warnings3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3098[README] add badge for install script test ci2022-05-09T09:07:54ZDennis Gläser[README] add badge for install script test ci3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3088[doc] update license2022-05-03T17:06:05ZYue Wang[doc] update licenseUpdate the licenseUpdate the license3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3082[script/handbook] update release branch in script2022-04-29T15:10:18ZYue Wang[script/handbook] update release branch in script3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3073Update changelog2022-04-27T12:20:29ZTimo Kochtimokoch@math.uio.noUpdate changelog3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3067Feature/parameterlist2022-06-01T11:42:23ZYue WangFeature/parameterlistFixes #1101Fixes #11013.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3066Cleanup/cmakelists2022-04-26T12:26:57ZTimo Kochtimokoch@math.uio.noCleanup/cmakelists3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no