dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-05-11T09:13:47Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3106[fix] correct the type and value in getParam2022-05-11T09:13:47ZYue Wang[fix] correct the type and value in getParamfixes the some default value and paramter type in getParamfixes the some default value and paramter type in getParam3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3050Fix doxygen modules formatting2022-04-20T08:23:46ZMartin UtzFix doxygen modules formattingCloses #1142Closes #11423.5Martin UtzMartin Utzhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2918Fix/epsilon 2d 2d intersections2021-11-02T23:29:00ZDennis GläserFix/epsilon 2d 2d intersections3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2922Fix extractline data script to work with more pvpython versions2021-12-16T10:47:41ZHanchuan WuFix extractline data script to work with more pvpython versionsCloses #1086Closes #10863.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3026Fix/extract module script missing macro2022-02-23T20:26:33ZHanchuan WuFix/extract module script missing macroFixes #1064Fixes #10643.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2867Fix/make install script2021-10-19T17:44:54ZDennis GläserFix/make install script3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2814fix/mpfa-fluxvars-caching-for-diffusion2021-09-22T11:29:52ZDennis Gläserfix/mpfa-fluxvars-caching-for-diffusionFixes #1047Fixes #10473.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3033[fix][richards] Extended richards: Fix balancequationoptions and do porosity ...2022-04-01T09:59:00ZKatharina Heck[fix][richards] Extended richards: Fix balancequationoptions and do porosity update before evaluating effective diffusion coefficients<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
The richards model never overwrote the balancequation options...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
The richards model never overwrote the balancequation options, which is why, although diffusion was calculated (for the extendend Richards model that considers water diffusion in the gas phase), it was immediatly also substracted, leading to a net diffusive flux of 0. With the richards-specific balancequationopts it depends on the phase index if diffusion is balanced or not. Additionally, the porosity in the volumevariables was updated at the wrong place, now it is updated before the effective diffusion coefficient.
This correction also made it necessary to change the boundary condition in the richards evaporation tests. a fixed value does not work if the liquid phase actually disappears.
fixes #11343.5Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3103Fix some compiler warnings2022-05-13T11:39:36ZYue WangFix some compiler warnings3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2780Fix/staggered fcdiscretization2021-09-10T08:55:21ZTimo Kochtimokoch@math.uio.noFix/staggered fcdiscretizationSome followup fixes for bugs overlooked in !2766Some followup fixes for bugs overlooked in !27663.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2850Fix switching between isothermal and nonisothermal model in freeflow channel ...2021-09-30T13:05:00ZBernd FlemischFix switching between isothermal and nonisothermal model in freeflow channel testA preprocessor variable ISOTHERMAL was set to 0 per default in main.cc
while for switching, the variable NONISOTHERMAL was evaluated.
To fix, set NONISOTHERMAL instead of ISOTHERMAL in main.cc.A preprocessor variable ISOTHERMAL was set to 0 per default in main.cc
while for switching, the variable NONISOTHERMAL was evaluated.
To fix, set NONISOTHERMAL instead of ISOTHERMAL in main.cc.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2600Fix/tabulated2dfunction2021-06-28T11:57:12ZDmitry PavlovFix/tabulated2dfunctionThere are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That ...There are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That needs to be fixed.
The second issue is the following code in get():
```c++
int i = max(0, min(m_, static_cast<int>(alpha)));
int j = max(0, min(n_, static_cast<int>(beta)));
```
With `x == xMax`, alpha will be as big as (`m_- 1`) even after the proposed fix to `xToI`. But we need an interval number here, not a point number, and there is no (`m_- 1`)-th interval (not to mention `_m`-th). So we need to cut `i` at (`m_ - 2`). Similarly with `j`.
Without the fix, the assertions in `getSamplePoint`
```c++
assert(0 <= i && i < m_);
assert(0 <= j && j < n_);
```
rightfully fail when `x` is close to `xMax` or `y` is close to `yMax`.
TODO:
* [ ] Check which tests are affected3.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3130[fix] use referece instead of copy in loop2022-05-25T18:23:22ZYue Wang[fix] use referece instead of copy in loop3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3134Fix/velocity output2022-05-31T07:40:58ZYue WangFix/velocity outputfixes #1161fixes #11613.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2879[flux] Add headers with declarations/primary templates/alias only2021-10-19T11:12:47ZTimo Kochtimokoch@math.uio.no[flux] Add headers with declarations/primary templates/alias only3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2823[freeflow] Add mass/energy model and donea/channel/sincos test with new stagg...2021-09-15T14:58:27ZTimo Kochtimokoch@math.uio.no[freeflow] Add mass/energy model and donea/channel/sincos test with new staggeredPart of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> impl...Part of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> implements same style as for pm models where non-isothermal version is also included in base model version. I don't see harm in adding this here already....
* [x] But maybe we should also add a NI test then.
* [x] Print error to analytical solution in Donea3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2722[geomtry][distance] Add distancePointTriangle2021-07-29T15:40:18ZKilian Weishaupt[geomtry][distance] Add distancePointTriangle3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2815[gridgeometry][bugfix] Reinitialize maps in update2021-09-02T12:46:06ZTimo Kochtimokoch@math.uio.no[gridgeometry][bugfix] Reinitialize maps in updateIf update is called twice the connectivity map is wrong sinnce
we push additional entries in there, i.e. each node in the stencil
will appear twice.
This makes sure all vectors are correctly reinitalized in every updateIf update is called twice the connectivity map is wrong sinnce
we push additional entries in there, i.e. each node in the stencil
will appear twice.
This makes sure all vectors are correctly reinitalized in every update3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3038[handbook] change the version of supported compilers2022-03-31T08:34:37ZYue Wang[handbook] change the version of supported compilersUpdate the version of compilers in handbook.Update the version of compilers in handbook.3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2900Implement new mobility treatment for case of disconnected water columns2021-12-13T20:51:15ZLeopold StadlerImplement new mobility treatment for case of disconnected water columnsCloses #1088Closes #10883.5Leopold StadlerLeopold Stadler