dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-05-22T10:17:38Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2637[md][box] Internal Dirichlet2021-05-22T10:17:38ZMartin Schneider[md][box] Internal Dirichlet* Set off-diagonal matrix blocks to zero if internal Dirichlet is set
* use correct problem() function in md framework* Set off-diagonal matrix blocks to zero if internal Dirichlet is set
* use correct problem() function in md framework3.5Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3104[material] Fix parameter type in spline material law2022-05-10T13:03:35ZTimo Kochtimokoch@math.uio.no[material] Fix parameter type in spline material law3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2856[material][components] add temperature dependent vaporization enthalpy to gas enthalpy of simpleh2o2022-03-30T18:41:30ZKatharina Heck[material][components] add temperature dependent vaporization enthalpy to gas enthalpy of simpleh2o<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This adds the vaporization enthalpy to the gas enthalpy. This...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This adds the vaporization enthalpy to the gas enthalpy. This is needed for components that can have a phase change. A temperature dependence on tRef is introduced according to a simple formula found in literature.
Remark: This is consistent with constant component as both calculate the gas enthalpy as
```gasHeatCapacity(temperature, pressure)*(temperature - tRef) + vaporizationEnthalpy()```. However, for constant component the vaporization enthalpy is an input value (constant) while simpleh2o uses the calculation based on literature.
**Which issue this MR fixes**:
fixes #1013
Todo:
- [x] check if any test is influenced by this. so far i could not find one3.5Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2831[material] Add option to PengRobinson::computeMolarVolume2021-09-16T11:22:20ZTimo Kochtimokoch@math.uio.no[material] Add option to PengRobinson::computeMolarVolume- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
o...- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
or the number of roots is 2 or more than 3
(no check was in place)
- Throwing NumericalProblem if the found molar volume turned
out to be zero, negative, or NaN. (Replacing assert)
- Added handleUnphysicalPhase flag (true by default). If false, the
single-root case is not checked for critical state of
the fluid (otherwise, Michelsen test for a mix of
hydrocarbons does not work).3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2828[io] Check if grid can communicate when loading solution2021-09-14T15:18:20ZMartin Schneider[io] Check if grid can communicate when loading solution3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2770[io][bugfix] Enable parallel grids from cake grid creator2021-08-19T15:03:49ZTimo Kochtimokoch@math.uio.no[io][bugfix] Enable parallel grids from cake grid creatorFill the factory on rank 0 and then distribute to the other ranks.
This uses the same method used for Dune::GmshReader.
Add some parallel test to make sure this works
Closes #1070Fill the factory on rank 0 and then distribute to the other ranks.
This uses the same method used for Dune::GmshReader.
Add some parallel test to make sure this works
Closes #10703.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3131[intersectingentities] Return const& to corner storage2022-05-30T09:20:40ZTimo Kochtimokoch@math.uio.no[intersectingentities] Return const& to corner storageThis avoids making a copy of the vectorThis avoids making a copy of the vector3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2996Improve PNM grid creator2022-04-05T09:11:16ZKilian WeishauptImprove PNM grid creator3.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3043Improve documentation of shallow water model2022-04-19T14:51:54ZMartin UtzImprove documentation of shallow water modelCloses #1140Closes #11403.5Martin UtzMartin Utzhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2415Improve brine fluidsystem2022-03-30T22:04:42ZTheresa SchollenbergerImprove brine fluidsystemCloses #970Closes #9703.5Johannes HommelJohannes Hommelhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2884Implement RichardsVelocityOutput which fixes velocity output for the Richards model2021-10-20T16:55:17ZRoman WinterImplement RichardsVelocityOutput which fixes velocity output for the Richards modelfixes #1087fixes #10873.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2900Implement new mobility treatment for case of disconnected water columns2021-12-13T20:51:15ZLeopold StadlerImplement new mobility treatment for case of disconnected water columnsCloses #1088Closes #10883.5Leopold StadlerLeopold Stadlerhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3038[handbook] change the version of supported compilers2022-03-31T08:34:37ZYue Wangyue.wang@iws.uni-stuttgart.de[handbook] change the version of supported compilersUpdate the version of compilers in handbook.Update the version of compilers in handbook.3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2815[gridgeometry][bugfix] Reinitialize maps in update2021-09-02T12:46:06ZTimo Kochtimokoch@math.uio.no[gridgeometry][bugfix] Reinitialize maps in updateIf update is called twice the connectivity map is wrong sinnce
we push additional entries in there, i.e. each node in the stencil
will appear twice.
This makes sure all vectors are correctly reinitalized in every updateIf update is called twice the connectivity map is wrong sinnce
we push additional entries in there, i.e. each node in the stencil
will appear twice.
This makes sure all vectors are correctly reinitalized in every update3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2722[geomtry][distance] Add distancePointTriangle2021-07-29T15:40:18ZKilian Weishaupt[geomtry][distance] Add distancePointTriangle3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2823[freeflow] Add mass/energy model and donea/channel/sincos test with new staggered2021-09-15T14:58:27ZTimo Kochtimokoch@math.uio.no[freeflow] Add mass/energy model and donea/channel/sincos test with new staggeredPart of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> impl...Part of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> implements same style as for pm models where non-isothermal version is also included in base model version. I don't see harm in adding this here already....
* [x] But maybe we should also add a NI test then.
* [x] Print error to analytical solution in Donea3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2879[flux] Add headers with declarations/primary templates/alias only2021-10-19T11:12:47ZTimo Kochtimokoch@math.uio.no[flux] Add headers with declarations/primary templates/alias only3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3134Fix/velocity output2022-05-31T07:40:58ZYue Wangyue.wang@iws.uni-stuttgart.deFix/velocity outputfixes #1161fixes #11613.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3130[fix] use referece instead of copy in loop2022-05-25T18:23:22ZYue Wangyue.wang@iws.uni-stuttgart.de[fix] use referece instead of copy in loop3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2600Fix/tabulated2dfunction2021-06-28T11:57:12ZDmitry PavlovFix/tabulated2dfunctionThere are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That ...There are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That needs to be fixed.
The second issue is the following code in get():
```c++
int i = max(0, min(m_, static_cast<int>(alpha)));
int j = max(0, min(n_, static_cast<int>(beta)));
```
With `x == xMax`, alpha will be as big as (`m_- 1`) even after the proposed fix to `xToI`. But we need an interval number here, not a point number, and there is no (`m_- 1`)-th interval (not to mention `_m`-th). So we need to cut `i` at (`m_ - 2`). Similarly with `j`.
Without the fix, the assertions in `getSamplePoint`
```c++
assert(0 <= i && i < m_);
assert(0 <= j && j < n_);
```
rightfully fail when `x` is close to `xMax` or `y` is close to `yMax`.
TODO:
* [ ] Check which tests are affected3.5Hanchuan WuHanchuan Wu