dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-02-23T22:19:46Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3011Surfactant test2022-02-23T22:19:46ZDmitry PavlovSurfactant testTest of surfactant injection in porous medium (2p2c). Surfactant model is loosely based on the one described [here](https://www.sintef.no/contentassets/0d97862cef164d1c965d268ce5e4e082/surfactant_model.pdf). (Also see [here](https://ntnu...Test of surfactant injection in porous medium (2p2c). Surfactant model is loosely based on the one described [here](https://www.sintef.no/contentassets/0d97862cef164d1c965d268ce5e4e082/surfactant_model.pdf). (Also see [here](https://ntnuopen.ntnu.no/ntnu-xmlui/handle/11250/240038) for a longer version). This test will not work without [MR 2914](!2914).3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2914[box] Option to update all element volume variables when deflecting solution2022-02-24T15:11:14ZDmitry Pavlov[box] Option to update all element volume variables when deflecting solutionAllows for volume variables in the box scheme to depend on all dofs of the element.
Adds a 2p3c test with surfactant injection in porous medium (2p3c). The surfactant model is loosely based on the one described [here](https://www.sintef...Allows for volume variables in the box scheme to depend on all dofs of the element.
Adds a 2p3c test with surfactant injection in porous medium (2p3c). The surfactant model is loosely based on the one described [here](https://www.sintef.no/contentassets/0d97862cef164d1c965d268ce5e4e082/surfactant_model.pdf). (Also see [here](https://ntnuopen.ntnu.no/ntnu-xmlui/handle/11250/240038) for a longer version). This test will not work without the fix in this MR.
Fixes #8923.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2994Cleanup: Rans velocity gradient function and IO fields2022-02-24T16:42:48ZNed ColtmanCleanup: Rans velocity gradient function and IO fields@anna_m_kostelecky pointed the following issues out yesterday during a meeting.
- The indices in the `velocityGradient(elementIdx, velIdx, dimIdx)` function within the rans problem were backwards
- The IO fields for the rans problem li...@anna_m_kostelecky pointed the following issues out yesterday during a meeting.
- The indices in the `velocityGradient(elementIdx, velIdx, dimIdx)` function within the rans problem were backwards
- The IO fields for the rans problem list the velocity gradients for all directions as "dv/dx_" with a trailing index (0,1,2). An "s", for spatial, rather than the "x" would be more fitting.
@tschol, I wouldn't blame you if you had ignored that part of conversation, but as you were there during the meeting I would assign you? Otherwise after the pipeline passes, anyone could merge this.3.5Sina AckermannSina Ackermannhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3029[doc][doxygen] Cleanup, especially of modules.txt and ingroups.2022-03-02T08:05:38ZMelanie Lipp[doc][doxygen] Cleanup, especially of modules.txt and ingroups.Introduces new groups in modules.txt according to the changed folder structure.
Corrects some ingroups.
Removes some superfluous \file.
Corrects other small doxygen issues (some missing documentation and some wrong copydoc reference).
...Introduces new groups in modules.txt according to the changed folder structure.
Corrects some ingroups.
Removes some superfluous \file.
Corrects other small doxygen issues (some missing documentation and some wrong copydoc reference).
Closes #11313.5Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2561WIP: analytical case for K-Omega2022-03-07T12:27:35ZNed ColtmanWIP: analytical case for K-Omega**What this MR does / why does DuMux need it**:
- Implements an analytical case for two-eq turbulence models from pre dumux 3.0
**Special notes for your reviewer**:
- Currently no convergence, for future comparison with new staggered im...**What this MR does / why does DuMux need it**:
- Implements an analytical case for two-eq turbulence models from pre dumux 3.0
**Special notes for your reviewer**:
- Currently no convergence, for future comparison with new staggered implementations3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1975WIP: [io][gridmanagerbase] Fix dune deprecation warning2022-03-28T09:36:01ZKilian WeishauptWIP: [io][gridmanagerbase] Fix dune deprecation warningfixes #859
Should probably be backported to 3.2fixes #859
Should probably be backported to 3.23.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3030Examples for Dumux 3.52022-03-28T09:53:54ZSina AckermannExamples for Dumux 3.5- [x] update READMEs according to latest commits (code changes)
- [x] check if everything compiles and runs (tests)- [x] update READMEs according to latest commits (code changes)
- [x] check if everything compiles and runs (tests)3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2988[test] Remove test description (except porous medium flow tests)2022-03-30T10:17:18ZLarissa Brencher[test] Remove test description (except porous medium flow tests)Remove test descriptions to avoid being outdated (#1106 and #1110)
Progress through test folders:
- [x] common
- [x] discretization
- [x] flux
- [x] freeflow
- [x] geomechanics
- [x] geometry
- [x] io
- [x] linear
- [x] material
- [x] m...Remove test descriptions to avoid being outdated (#1106 and #1110)
Progress through test folders:
- [x] common
- [x] discretization
- [x] flux
- [x] freeflow
- [x] geomechanics
- [x] geometry
- [x] io
- [x] linear
- [x] material
- [x] multidomain
- [x] nonlinear
- [x] porenetwork
- [ ] porousmediumflow
- [x] 1p* folders
- [ ] ~~remaining folders~~ -> separate MR
- [x] python
- [x] references
- [x] timestepping3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3032Feature/handbook update2022-03-30T14:09:28ZIvan BunticFeature/handbook updateMR to issue #1133.MR to issue #1133.3.5Ivan BunticIvan Buntichttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2856[material][components] add temperature dependent vaporization enthalpy to gas...2022-03-30T18:41:30ZKatharina Heck[material][components] add temperature dependent vaporization enthalpy to gas enthalpy of simpleh2o<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This adds the vaporization enthalpy to the gas enthalpy. This...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This adds the vaporization enthalpy to the gas enthalpy. This is needed for components that can have a phase change. A temperature dependence on tRef is introduced according to a simple formula found in literature.
Remark: This is consistent with constant component as both calculate the gas enthalpy as
```gasHeatCapacity(temperature, pressure)*(temperature - tRef) + vaporizationEnthalpy()```. However, for constant component the vaporization enthalpy is an input value (constant) while simpleh2o uses the calculation based on literature.
**Which issue this MR fixes**:
fixes #1013
Todo:
- [x] check if any test is influenced by this. so far i could not find one3.5Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1781Add script to extract CO2 tables from NIST website2022-03-30T22:03:58ZMartin UtzAdd script to extract CO2 tables from NIST websiteThis MR provides a python script, which can create CO2 tables, like the one used in the CO2 test. The tables contain density and enthalpy values for a specified temperature and pressure range. The CO2 tables are created by the help of a ...This MR provides a python script, which can create CO2 tables, like the one used in the CO2 test. The tables contain density and enthalpy values for a specified temperature and pressure range. The CO2 tables are created by the help of a website (https://webbook.nist.gov/chemistry/fluid), which calculate the needed values. The query for the values is automated by the python script, which also does the formatting of the received values.
The former way to generate the CO2 table was a Fortran script, which can't be published due to copy right issues. Therefore it was decided in #690 to use the NIST website and a python script to generate the new CO2 tables. Both approaches use the formula of Span and Wagner to calculate the values and produce the same result (within a acceptable tolerance). The new approach has the advantage, that we can publish the script.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2415Improve brine fluidsystem2022-03-30T22:04:42ZTheresa SchollenbergerImprove brine fluidsystemCloses #970Closes #9703.5Johannes HommelJohannes Hommelhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3038[handbook] change the version of supported compilers2022-03-31T08:34:37ZYue Wangyue.wang@iws.uni-stuttgart.de[handbook] change the version of supported compilersUpdate the version of compilers in handbook.Update the version of compilers in handbook.3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3039Cleanup/move tensor average helper2022-03-31T12:29:51ZMathis KelmCleanup/move tensor average helperMove the tensor-averaging helpers for interfaces from spatialparams to a separate header in `dumux/flux`.
Closes #1097Move the tensor-averaging helpers for interfaces from spatialparams to a separate header in `dumux/flux`.
Closes #10973.5Mathis KelmMathis Kelmhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3012Component-aware dispersion2022-03-31T14:16:48ZDmitry PavlovComponent-aware dispersionIt will be useful to allow different dispersion parameters for different components, even when they are in one phase. For instance, single-well chemical tracer tests are usually modeled in one phase (oil is immobile), but dispersion coef...It will be useful to allow different dispersion parameters for different components, even when they are in one phase. For instance, single-well chemical tracer tests are usually modeled in one phase (oil is immobile), but dispersion coefficients for different components are different.
See e.g. [this article](
https://doi.org/10.2118/129724-MS
): "Dispersivity is taken to be a history match parameter and can be different for each tracer".
Fixes #11043.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3040Cleanup/fix dependencies installexternal2022-03-31T22:24:04ZMathis KelmCleanup/fix dependencies installexternalAdd required dependencies to package `dumux-course` and change version of `dune-mmesh` to `release/1.3`.
Fixes #1137Add required dependencies to package `dumux-course` and change version of `dune-mmesh` to `release/1.3`.
Fixes #11373.5Mathis KelmMathis Kelmhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3035move gstatrandomfield from dumux/material/spatialparams to dumux/material2022-03-31T22:42:10ZRoman Wintermove gstatrandomfield from dumux/material/spatialparams to dumux/materialcloses #1114closes #11143.5Roman WinterRoman Winterhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3033[fix][richards] Extended richards: Fix balancequationoptions and do porosity ...2022-04-01T09:59:00ZKatharina Heck[fix][richards] Extended richards: Fix balancequationoptions and do porosity update before evaluating effective diffusion coefficients<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
The richards model never overwrote the balancequation options...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
The richards model never overwrote the balancequation options, which is why, although diffusion was calculated (for the extendend Richards model that considers water diffusion in the gas phase), it was immediatly also substracted, leading to a net diffusive flux of 0. With the richards-specific balancequationopts it depends on the phase index if diffusion is balanced or not. Additionally, the porosity in the volumevariables was updated at the wrong place, now it is updated before the effective diffusion coefficient.
This correction also made it necessary to change the boundary condition in the richards evaporation tests. a fixed value does not work if the liquid phase actually disappears.
fixes #11343.5Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2954Cleanup parameter list generator and input files2022-04-01T11:28:14ZYue Wangyue.wang@iws.uni-stuttgart.deCleanup parameter list generator and input files3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3037Feature/ff momentum numeqtype bcs2022-04-01T13:00:11ZNed ColtmanFeature/ff momentum numeqtype bcsfixes #895 and #1085fixes #895 and #10853.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no