dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-10-18T19:28:14Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2842Cleanup/port angeli test2021-10-18T19:28:14ZKatharina HeckCleanup/port angeli testthis is related to #1081.
useNeumann is added but not currently testedthis is related to #1081.
useNeumann is added but not currently tested3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2841[ff/channel/pipe] Port ff-channel-pipe case to staggered grid2021-10-01T22:07:48ZHanchuan Wu[ff/channel/pipe] Port ff-channel-pipe case to staggered grid#1081#10813.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2837Consistent naming in test/references2021-09-30T17:31:42ZFarid MohammadiConsistent naming in test/referencesCloses #1077Closes #10773.5Farid MohammadiFarid Mohammadihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2832[component] Allow specifying dynamic _or_ kinematic viscosity for constant co...2021-09-20T07:20:56ZTimo Kochtimokoch@math.uio.no[component] Allow specifying dynamic _or_ kinematic viscosity for constant components3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2831[material] Add option to PengRobinson::computeMolarVolume2021-09-16T11:22:20ZTimo Kochtimokoch@math.uio.no[material] Add option to PengRobinson::computeMolarVolume- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
o...- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
or the number of roots is 2 or more than 3
(no check was in place)
- Throwing NumericalProblem if the found molar volume turned
out to be zero, negative, or NaN. (Replacing assert)
- Added handleUnphysicalPhase flag (true by default). If false, the
single-root case is not checked for critical state of
the fluid (otherwise, Michelsen test for a mix of
hydrocarbons does not work).3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2830Test 3D with new staggered freeflow model2022-01-12T10:33:19ZTimo Kochtimokoch@math.uio.noTest 3D with new staggered freeflow modelTests are still failing with small differences. But it might be related to some wrong handling of the boundary conditions in 3D, so it should be investigated with care.Tests are still failing with small differences. But it might be related to some wrong handling of the boundary conditions in 3D, so it should be investigated with care.3.5Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2828[io] Check if grid can communicate when loading solution2021-09-14T15:18:20ZMartin Schneider[io] Check if grid can communicate when loading solution3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2827Feature/freeflow periodic2021-09-16T14:38:44ZTimo Kochtimokoch@math.uio.noFeature/freeflow periodic3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2826[md][ff-pm] Add freeflow porous medium coupling managers and test2021-10-19T12:06:20ZTimo Kochtimokoch@math.uio.no[md][ff-pm] Add freeflow porous medium coupling managers and testPart of merging !2201 in smaller parts.
Improvement in comparison to old convergence test:
* Add stress tensor for analytical solutions
* add tests for dirichlet, neumann and mixed dirichlet-neumann boundaries in both domains
* test al...Part of merging !2201 in smaller parts.
Improvement in comparison to old convergence test:
* Add stress tensor for analytical solutions
* add tests for dirichlet, neumann and mixed dirichlet-neumann boundaries in both domains
* test all implemented analytical solutions
TODO
* [x] Coupling manager: Make interface smaller (private) whereever possible
* [x] Fix updateCouplingContext3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2825[multidomain][couplingmanager] Store tuple of share_ptr's for SolutionVector2021-09-09T07:36:19ZTimo Kochtimokoch@math.uio.no[multidomain][couplingmanager] Store tuple of share_ptr's for SolutionVector* add new function curSol(domainIdx) and deprecate curSol()
* allow to set externally stored solution vector without taking ownership* add new function curSol(domainIdx) and deprecate curSol()
* allow to set externally stored solution vector without taking ownership3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2823[freeflow] Add mass/energy model and donea/channel/sincos test with new stagg...2021-09-15T14:58:27ZTimo Kochtimokoch@math.uio.no[freeflow] Add mass/energy model and donea/channel/sincos test with new staggeredPart of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> impl...Part of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> implements same style as for pm models where non-isothermal version is also included in base model version. I don't see harm in adding this here already....
* [x] But maybe we should also add a NI test then.
* [x] Print error to analytical solution in Donea3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2822[test][md] Use new error helper in convergence test2021-09-06T23:02:03ZTimo Kochtimokoch@math.uio.no[test][md] Use new error helper in convergence test3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2819[ci] Make triggered dumux-lecture branch a variable2021-09-06T13:37:26ZTimo Kochtimokoch@math.uio.no[ci] Make triggered dumux-lecture branch a variableAFAIK the release dumux branch currently triggers the dumux-lecture master branch. While this might be an interesting combination, this curretnly leaves the lecture rlease branch untested. With this variable, we can configure the nightly...AFAIK the release dumux branch currently triggers the dumux-lecture master branch. While this might be an interesting combination, this curretnly leaves the lecture rlease branch untested. With this variable, we can configure the nightly schedule to use release rbanches in both dumux and dumux-lecture3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2818Add PengRobinson::criticalTemperature()2021-09-05T14:45:03ZDmitry PavlovAdd PengRobinson::criticalTemperature()It is useful for determining whether the fluid is in supercritical state.It is useful for determining whether the fluid is in supercritical state.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2817remove unused local variable in MPNC nonequilibrium volume variables2021-09-03T10:23:21ZBernd Flemischremove unused local variable in MPNC nonequilibrium volume variablesleftover from the equilibrium variantleftover from the equilibrium variant3.5Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2816Feature/bin common affirmative filter2021-09-03T06:00:11ZDennis GläserFeature/bin common affirmative filterdepends on !2758depends on !27583.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2815[gridgeometry][bugfix] Reinitialize maps in update2021-09-02T12:46:06ZTimo Kochtimokoch@math.uio.no[gridgeometry][bugfix] Reinitialize maps in updateIf update is called twice the connectivity map is wrong sinnce
we push additional entries in there, i.e. each node in the stencil
will appear twice.
This makes sure all vectors are correctly reinitalized in every updateIf update is called twice the connectivity map is wrong sinnce
we push additional entries in there, i.e. each node in the stencil
will appear twice.
This makes sure all vectors are correctly reinitalized in every update3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2814fix/mpfa-fluxvars-caching-for-diffusion2021-09-22T11:29:52ZDennis Gläserfix/mpfa-fluxvars-caching-for-diffusionFixes #1047Fixes #10473.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2813[cleanup] Remove unused PengRobinsonMixture::computeMolarVolumes2021-08-31T16:56:53ZTimo Kochtimokoch@math.uio.no[cleanup] Remove unused PengRobinsonMixture::computeMolarVolumesIt also wouldn't translate because PengRobinson::computeMolarVolumes
does not exist.It also wouldn't translate because PengRobinson::computeMolarVolumes
does not exist.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2807[test][cleanup] Remove sequential references2021-08-30T13:09:41ZTimo Kochtimokoch@math.uio.no[test][cleanup] Remove sequential references3.5Dennis GläserDennis Gläser