dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-10-18T19:28:14Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2842Cleanup/port angeli test2021-10-18T19:28:14ZKatharina HeckCleanup/port angeli testthis is related to #1081.
useNeumann is added but not currently testedthis is related to #1081.
useNeumann is added but not currently tested3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2874[md][couplingmanager] Fix nullptr initialization of problem2021-10-18T16:28:31ZTimo Kochtimokoch@math.uio.no[md][couplingmanager] Fix nullptr initialization of problemRemove unncessary capture for init lambda functionsRemove unncessary capture for init lambda functions3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2871Feature/new staggered small fixes2021-10-17T17:49:44ZTimo Kochtimokoch@math.uio.noFeature/new staggered small fixes3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2870[navierstokes][problem] Do not expose discretization methods in problem2021-10-16T16:11:14ZTimo Kochtimokoch@math.uio.no[navierstokes][problem] Do not expose discretization methods in problemThis created some unresolved dependenices due to the cyclic interdependency
of problem and coupling manager. This worked before because the discretizaiton
method was always one specific type. With tags the actual type has to be known,
so...This created some unresolved dependenices due to the cyclic interdependency
of problem and coupling manager. This worked before because the discretizaiton
method was always one specific type. With tags the actual type has to be known,
so both problems and the coupling manager have to be instatiated before this
information can be accessed.3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2845[port] channel/1d to new staggered2021-10-02T11:17:04ZRoman Winter[port] channel/1d to new staggeredPorted channel/1d to new staggeredPorted channel/1d to new staggered3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2858Remove template argument PrimaryVariables from ShallowWaterViscousFlux2021-10-02T11:01:08ZMartin UtzRemove template argument PrimaryVariables from ShallowWaterViscousFluxThe template argument PrimaryVariables is not needed and can be therefore
removed as discussed with @timok in !2824The template argument PrimaryVariables is not needed and can be therefore
removed as discussed with @timok in !28243.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2841[ff/channel/pipe] Port ff-channel-pipe case to staggered grid2021-10-01T22:07:48ZHanchuan Wu[ff/channel/pipe] Port ff-channel-pipe case to staggered grid#1081#10813.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2781[ci] Test with dune 2.8 instead of dune 2.72021-09-30T18:37:36ZTimo Kochtimokoch@math.uio.no[ci] Test with dune 2.8 instead of dune 2.73.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2837Consistent naming in test/references2021-09-30T17:31:42ZFarid MohammadiConsistent naming in test/referencesCloses #1077Closes #10773.5Farid MohammadiFarid Mohammadihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2851Feature/test detection cmakelists2021-09-30T14:52:33ZTimo Kochtimokoch@math.uio.noFeature/test detection cmakelistsMark tests as affected if the CMakeLists.txt file changedMark tests as affected if the CMakeLists.txt file changed3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2850Fix switching between isothermal and nonisothermal model in freeflow channel test2021-09-30T13:05:00ZBernd FlemischFix switching between isothermal and nonisothermal model in freeflow channel testA preprocessor variable ISOTHERMAL was set to 0 per default in main.cc
while for switching, the variable NONISOTHERMAL was evaluated.
To fix, set NONISOTHERMAL instead of ISOTHERMAL in main.cc.A preprocessor variable ISOTHERMAL was set to 0 per default in main.cc
while for switching, the variable NONISOTHERMAL was evaluated.
To fix, set NONISOTHERMAL instead of ISOTHERMAL in main.cc.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2814fix/mpfa-fluxvars-caching-for-diffusion2021-09-22T11:29:52ZDennis Gläserfix/mpfa-fluxvars-caching-for-diffusionFixes #1047Fixes #10473.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2832[component] Allow specifying dynamic _or_ kinematic viscosity for constant components2021-09-20T07:20:56ZTimo Kochtimokoch@math.uio.no[component] Allow specifying dynamic _or_ kinematic viscosity for constant components3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2827Feature/freeflow periodic2021-09-16T14:38:44ZTimo Kochtimokoch@math.uio.noFeature/freeflow periodic3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2831[material] Add option to PengRobinson::computeMolarVolume2021-09-16T11:22:20ZTimo Kochtimokoch@math.uio.no[material] Add option to PengRobinson::computeMolarVolume- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
o...- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
or the number of roots is 2 or more than 3
(no check was in place)
- Throwing NumericalProblem if the found molar volume turned
out to be zero, negative, or NaN. (Replacing assert)
- Added handleUnphysicalPhase flag (true by default). If false, the
single-root case is not checked for critical state of
the fluid (otherwise, Michelsen test for a mix of
hydrocarbons does not work).3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2823[freeflow] Add mass/energy model and donea/channel/sincos test with new staggered2021-09-15T14:58:27ZTimo Kochtimokoch@math.uio.no[freeflow] Add mass/energy model and donea/channel/sincos test with new staggeredPart of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> impl...Part of merging !2201 in smaller parts.
* add the mass model headers
* add the energy model headers
* add mass-momentum coupling manager
* add Donea tests with new staggered (replaces old test)
TODO
* [x] Why is energy needed? -> implements same style as for pm models where non-isothermal version is also included in base model version. I don't see harm in adding this here already....
* [x] But maybe we should also add a NI test then.
* [x] Print error to analytical solution in Donea3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2828[io] Check if grid can communicate when loading solution2021-09-14T15:18:20ZMartin Schneider[io] Check if grid can communicate when loading solution3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2779Feature/freeflow momentum new staggered2021-09-10T08:55:21ZTimo Kochtimokoch@math.uio.noFeature/freeflow momentum new staggered* Add momentum model for fcstaggered
* Add a Donea test solving the momentum part of the Stokes equations with given pressure
Part of merging !2201 in smaller parts
Closes #896* Add momentum model for fcstaggered
* Add a Donea test solving the momentum part of the Stokes equations with given pressure
Part of merging !2201 in smaller parts
Closes #8963.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2780Fix/staggered fcdiscretization2021-09-10T08:55:21ZTimo Kochtimokoch@math.uio.noFix/staggered fcdiscretizationSome followup fixes for bugs overlooked in !2766Some followup fixes for bugs overlooked in !27663.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2825[multidomain][couplingmanager] Store tuple of share_ptr's for SolutionVector2021-09-09T07:36:19ZTimo Kochtimokoch@math.uio.no[multidomain][couplingmanager] Store tuple of share_ptr's for SolutionVector* add new function curSol(domainIdx) and deprecate curSol()
* allow to set externally stored solution vector without taking ownership* add new function curSol(domainIdx) and deprecate curSol()
* allow to set externally stored solution vector without taking ownership3.5Dennis GläserDennis Gläser