dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-06-02T11:50:52Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3157reorder changelog2022-06-02T11:50:52ZBernd Flemischreorder changelogReorder the changes from 3.4 to 3.5 in the changelog.Reorder the changes from 3.4 to 3.5 in the changelog.3.5Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3156Merge branch 'feature/facecentered_localidxfix' into 'master'2022-06-02T11:50:20ZYue Wangyue.wang@iws.uni-stuttgart.deMerge branch 'feature/facecentered_localidxfix' into 'master'[facecentered][convexcorner] fix the local Index logic
See merge request dumux-repositories/dumux!3154
(cherry picked from commit 60653203934979eef3d84388abb0619d0355cb43)
b7c21f27 [facecentered][convexcorner] fix the local Index logic[facecentered][convexcorner] fix the local Index logic
See merge request dumux-repositories/dumux!3154
(cherry picked from commit 60653203934979eef3d84388abb0619d0355cb43)
b7c21f27 [facecentered][convexcorner] fix the local Index logic3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3154[facecentered][convexcorner] fix the local Index logic2024-01-31T10:44:58ZNed Coltman[facecentered][convexcorner] fix the local Index logic<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
I've come across an error whil...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
I've come across an error while using the new face centered staggered scheme. For convex corner geometries, `localIndexOutsideScvfWithSameIntegrationPoint(scvf)` is called from the `outsideScvfWithSameIntegrationPoint(scvf) ` in the `fluxvariables`. The logic doesn't seem to be fool proof, in particular for the scvf with the local index 10.
As 10 is an even number, the function returns an index of 13, which does not typically exist, outside of elements with 2+ boundary faces.
This change should fix this for the local index of 10.
As a reference, here is a confusing quick drawing with all of the local scvf indexes.
![temp_localscvfidx](/uploads/26ec6ff585f142d3bf8fa9bc516c9b07/temp_localscvfidx.png)
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
I believe that this has not been identified yet because we do not have many new freeflow tests with convex corner geometries, especially where the scvf with local index 10 would be involved.
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3151Merge branch 'fix/test-1p3c-maxwell-stefan' into 'master'2022-06-01T20:50:57ZTimo Kochtimokoch@math.uio.noMerge branch 'fix/test-1p3c-maxwell-stefan' into 'master'[test][1pnc] Improve Maxwell-Stefan test
Closes #1158
See merge request dumux-repositories/dumux!3145
(cherry picked from commit 7c0e9f09588bd31c1ad27f456d52cba83b752916)
4cbb547b [test][1pnc] Improve Maxwell-Stefan test[test][1pnc] Improve Maxwell-Stefan test
Closes #1158
See merge request dumux-repositories/dumux!3145
(cherry picked from commit 7c0e9f09588bd31c1ad27f456d52cba83b752916)
4cbb547b [test][1pnc] Improve Maxwell-Stefan test3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3150Merge branch 'bugfix/richards-viscosity-check' into 'master'2022-06-01T19:44:38ZTimo Kochtimokoch@math.uio.noMerge branch 'bugfix/richards-viscosity-check' into 'master'[richards][fluidsystems] Fix static assert in Richards and implement...
See merge request dumux-repositories/dumux!3146
(cherry picked from commit a0f0e2970cbceb8b24ae8f8f167f4fbb39dae9d4)
ab78f171 [richards][fluidsystems] Fix static ...[richards][fluidsystems] Fix static assert in Richards and implement...
See merge request dumux-repositories/dumux!3146
(cherry picked from commit a0f0e2970cbceb8b24ae8f8f167f4fbb39dae9d4)
ab78f171 [richards][fluidsystems] Fix static assert in Richards and implement...
8309c462 fixup
f52906e8 fixrp3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3149Merge branch 'cleanup/1pnc-remove-delp-from-default-output' into 'master'2022-06-01T18:33:23ZTimo Kochtimokoch@math.uio.noMerge branch 'cleanup/1pnc-remove-delp-from-default-output' into 'master'[1pnc] Remove delp from default output
See merge request dumux-repositories/dumux!3144
(cherry picked from commit 8e3e6ea6679693538e0c3b418c89de726a8f3843)
840cd078 [1pnc] Remove delp from default output[1pnc] Remove delp from default output
See merge request dumux-repositories/dumux!3144
(cherry picked from commit 8e3e6ea6679693538e0c3b418c89de726a8f3843)
840cd078 [1pnc] Remove delp from default output3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3148Merge branch 'fix/pylint' into 'master'2022-06-01T17:25:01ZTimo Kochtimokoch@math.uio.noMerge branch 'fix/pylint' into 'master'[python][linter] Fix pylint warning appearing with newer version
See merge request dumux-repositories/dumux!3147
(cherry picked from commit 00f5923010e4f893d01815d0ac1243fa8736a5b1)
697569f1 [python][linter] Fix pylint warning appeari...[python][linter] Fix pylint warning appearing with newer version
See merge request dumux-repositories/dumux!3147
(cherry picked from commit 00f5923010e4f893d01815d0ac1243fa8736a5b1)
697569f1 [python][linter] Fix pylint warning appearing with newer version3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3147[python][linter] Fix pylint warning appearing with newer version2022-06-01T16:57:36ZTimo Kochtimokoch@math.uio.no[python][linter] Fix pylint warning appearing with newer version3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3146[richards][fluidsystems] Fix static assert in Richards and implement...2022-06-01T18:51:46ZTimo Kochtimokoch@math.uio.no[richards][fluidsystems] Fix static assert in Richards and implement...[richards][fluidsystems] Fix static assert in Richards and implement H2OAir::viscosityIsConstant interface[richards][fluidsystems] Fix static assert in Richards and implement H2OAir::viscosityIsConstant interface3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3145[test][1pnc] Improve Maxwell-Stefan test2022-06-01T19:54:38ZTimo Kochtimokoch@math.uio.no[test][1pnc] Improve Maxwell-Stefan testMake test more robust by
* fixing output interval so always the same number of outputs are written
* use fixed time step size
Decrease runtime by only using 1 cell in y-direction.
We test in 2D to test the model in 2D but the specific ...Make test more robust by
* fixing output interval so always the same number of outputs are written
* use fixed time step size
Decrease runtime by only using 1 cell in y-direction.
We test in 2D to test the model in 2D but the specific setup is
one-dimensional so the added cells can be spared.
The new reference solution was created with a timestep
of 5s. The test uses a timestep of 25s which still
reproduces and accurate enough solution so the
comparison passes.
Fixes #11583.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3144[1pnc] Remove delp from default output2022-06-01T18:00:18ZTimo Kochtimokoch@math.uio.no[1pnc] Remove delp from default outputdelp is not generally a useful output in particular since -1e5 is hard-coded as offset.
In case of small pressure changes this output also suffers from possible large rounding errors
since p is the primary variables and -1e5 might result...delp is not generally a useful output in particular since -1e5 is hard-coded as offset.
In case of small pressure changes this output also suffers from possible large rounding errors
since p is the primary variables and -1e5 might result in 5 insifgnificant digits.
No other model has this default output field. Hence, this makes
output more consistent across models.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3142Merge branch 'feature/parameterlist' into 'master'2022-06-01T11:57:53ZYue Wangyue.wang@iws.uni-stuttgart.deMerge branch 'feature/parameterlist' into 'master'Feature/parameterlist
Closes #1101
See merge request dumux-repositories/dumux!3067
(cherry picked from commit 04a29b64dbc5ffb01148950fdcbccfe514078676)
61939f37 [getparam] update script for known_parameter_warnings
95e4cacd [doc] upd...Feature/parameterlist
Closes #1101
See merge request dumux-repositories/dumux!3067
(cherry picked from commit 04a29b64dbc5ffb01148950fdcbccfe514078676)
61939f37 [getparam] update script for known_parameter_warnings
95e4cacd [doc] update parameterlist known_parameter_warnings3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3141Merge branch 'fix/return-type-in-function-outsideScvfWithSameIntegrationPoint...2022-05-31T17:36:38ZTimo Kochtimokoch@math.uio.noMerge branch 'fix/return-type-in-function-outsideScvfWithSameIntegrationPoint' into 'master'[fix] conditional return type in function outsideScvfWithSameIntegrationPoint
Closes #1159
See merge request dumux-repositories/dumux!3135
(cherry picked from commit ed6128e934b2dfc2ef46adbb6a9e5eb3266799f8)
602e4818 [fix][ff][stagge...[fix] conditional return type in function outsideScvfWithSameIntegrationPoint
Closes #1159
See merge request dumux-repositories/dumux!3135
(cherry picked from commit ed6128e934b2dfc2ef46adbb6a9e5eb3266799f8)
602e4818 [fix][ff][staggered] Fix return type of outsideScvfWithSameIntegrationPoint3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3140Merge branch 'fix/velocity-output' into 'master'2022-05-31T08:51:26ZTimo Kochtimokoch@math.uio.noMerge branch 'fix/velocity-output' into 'master'Fix/velocity output
Closes #1161
See merge request dumux-repositories/dumux!3134
(cherry picked from commit 2b68068f67f33b0eca96af05c1866634f2342d84)
9d4dd3e5 [pmFlow] correct area in velocity
6c2c9fda [examples]add velocity in 1prot...Fix/velocity output
Closes #1161
See merge request dumux-repositories/dumux!3134
(cherry picked from commit 2b68068f67f33b0eca96af05c1866634f2342d84)
9d4dd3e5 [pmFlow] correct area in velocity
6c2c9fda [examples]add velocity in 1protationsymmetry3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3137Merge branch 'fix/intersecting-entities-iinfo-corner-storage' into 'master'2022-05-30T18:46:40ZYue Wangyue.wang@iws.uni-stuttgart.deMerge branch 'fix/intersecting-entities-iinfo-corner-storage' into 'master'[intersectingentities] Return const& to corner storage
See merge request dumux-repositories/dumux!3131
(cherry picked from commit 3523166b13fa73ba6d1f583c6de95266c7b7692c)
9403e4e9 [intersectingentities] Return const& to corner storage[intersectingentities] Return const& to corner storage
See merge request dumux-repositories/dumux!3131
(cherry picked from commit 3523166b13fa73ba6d1f583c6de95266c7b7692c)
9403e4e9 [intersectingentities] Return const& to corner storage3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3135[fix] conditional return type in function outsideScvfWithSameIntegrationPoint2022-05-31T17:04:30ZYue Wangyue.wang@iws.uni-stuttgart.de[fix] conditional return type in function outsideScvfWithSameIntegrationPointfixes #1159fixes #11593.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3134Fix/velocity output2022-05-31T07:40:58ZYue Wangyue.wang@iws.uni-stuttgart.deFix/velocity outputfixes #1161fixes #11613.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3132Merge branch 'feature/improve-python-setup-doc' into 'master'2022-05-27T11:33:48ZTimo Kochtimokoch@math.uio.noMerge branch 'feature/improve-python-setup-doc' into 'master'[docs] Update Python setup
See merge request dumux-repositories/dumux!3128
(cherry picked from commit e73cc4cd4d6250a66e2175fe432bfd7b2bee34f5)
554d57fd [docs] Update Python setup
7d172751 [docs][python] Fix dumux version in docs[docs] Update Python setup
See merge request dumux-repositories/dumux!3128
(cherry picked from commit e73cc4cd4d6250a66e2175fe432bfd7b2bee34f5)
554d57fd [docs] Update Python setup
7d172751 [docs][python] Fix dumux version in docs3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3131[intersectingentities] Return const& to corner storage2022-05-30T09:20:40ZTimo Kochtimokoch@math.uio.no[intersectingentities] Return const& to corner storageThis avoids making a copy of the vectorThis avoids making a copy of the vector3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3130[fix] use referece instead of copy in loop2022-05-25T18:23:22ZYue Wangyue.wang@iws.uni-stuttgart.de[fix] use referece instead of copy in loop3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.de