dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-11-09T09:47:38Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2708Add new class for calculating wall distance2021-11-09T09:47:38ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deAdd new class for calculating wall distance* Add geometry utilities for constructing spheres / bounding spheres / circumspheres (these are acutally not used by the wall distance but might be useful in the future now that they are implemented.)
* Add `closestEntity` and `distance`...* Add geometry utilities for constructing spheres / bounding spheres / circumspheres (these are acutally not used by the wall distance but might be useful in the future now that they are implemented.)
* Add `closestEntity` and `distance` queries for point and AABB trees
* Add `DistanceField` a function-like wrapper around a set of geometries to make distance queries at a given sample point
* Add `WallDistance` a class that evaluates discrete distance-to-the-mesh-boundary field at either vertex or element centers
__TODO__
- [x] better test
- [x] Maybe use in existing RANS model
- [x] fix check for UG or ALU in test
- [x] check parallelism? maybe throw
![Screenshot_2021-08-26_at_16.06.13](/uploads/66e7098269e3030b6edd0dcff95c0364/Screenshot_2021-08-26_at_16.06.13.png)3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2201[WIP] Feature/new staggered impl2021-10-19T13:08:24ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.de[WIP] Feature/new staggered impl__TODO__
_General:_
- [ ] Fix docu (especially copy and paste errors)
- [ ] Rethink assembly strategy (forward / inverse)?
- [x] Introduce coupling stencils per DOF?
- [x] improve design of "dual" problem
- [x] boundary flux helpers
- [ ...__TODO__
_General:_
- [ ] Fix docu (especially copy and paste errors)
- [ ] Rethink assembly strategy (forward / inverse)?
- [x] Introduce coupling stencils per DOF?
- [x] improve design of "dual" problem
- [x] boundary flux helpers
- [ ] prohibit Dirichlet for mass model?
- [x] check difference in Jacobian for compressible fluids (channel)
- [x] periodic grids
- [ ] Look into benefits of caching options
- [ ] Add volume work to energy balance
@nedc:
- [x] Set up higher order geometry
- [x] Port the TVD methods
- [x] Add correct checks for various boundary conditions
- [x] Add useful tests for higher order
- [ ] Update and include the rans models
@kweis:
- [x] coupling (staggered-cellcentered)
- [x] implement Beavers-Joseph BC
- [x] Compositional models (1pnc)
@martins
- [ ] Finalize box-staggered coupling (old staggered)
- [ ] Port box-staggered to new staggered
- [ ] Develop new freeflow discretizations (long term)
@hanchuan
- [x] port and test Navier stokes tests (should have been completed already by @kweis)
- [x] port compositional tests (after 1pnc is updated)
- [ ] port stokes-darcy MD tests (after MD is updated)
- [ ] port rans tests (after rans is updated)
fixes #7563.5Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2113WIP: Feature/new istl linear solvers2021-07-16T13:11:46ZTimo Kochtimokoch@math.uio.noWIP: Feature/new istl linear solvers* [x] Revisit template arguments
* [x] Introduce linear algebra backend or similar to make usage simpler
* [x] Adapt all linear solvers to provide `norm`
* [x] In Newton call `linearSolver->norm(r)` if available otherwise call `assembler...* [x] Revisit template arguments
* [x] Introduce linear algebra backend or similar to make usage simpler
* [x] Adapt all linear solvers to provide `norm`
* [x] In Newton call `linearSolver->norm(r)` if available otherwise call `assembler->residualNorm();` (depends on !2311 to be merged)
* [x] Deprecate conversion of multitype matrices in Newton (do in solver instead if necessary)
Depends on !2310 to be merged.
The matrix and vector type now have to be known to construct the solver.
This was previously delayed until the solve call but made the structure kind of intransparent because it wasn't really clear which vector type has to come in but only specific types work anyway.
Hard coding the solver hopefully reduces compile times wrt the factory. Also the implementation should be
* more compact than the old backends
* have more runtime option due to parameter tree-based params
* work in parallel as well
If this works out, we would deprecated the old solver backends.3.5Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2837Consistent naming in test/references2021-09-30T17:31:42ZFarid MohammadiConsistent naming in test/referencesCloses #1077Closes #10773.5Farid MohammadiFarid Mohammadihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2784Feature/richards fluidsystem2021-08-24T20:56:29ZTimo Kochtimokoch@math.uio.noFeature/richards fluidsystemCloses #1002.
Allow using Richards model with the TwoPImmiscble fluid system.
Uses more general indices and asserts that the phases are as assumed before.
Theoretically not backwards compatible if someone had a custom fluid system wher...Closes #1002.
Allow using Richards model with the TwoPImmiscble fluid system.
Uses more general indices and asserts that the phases are as assumed before.
Theoretically not backwards compatible if someone had a custom fluid system where phases are exchanged. But the error message is clear due to the static assert and it should be easy to fix then.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2736Feature/simplify local view2021-08-20T16:04:14ZNed ColtmanFeature/simplify local viewFixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] ...Fixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] Go through all dumux/ headers and replace useage
- [x] Go through all test/ headers and replace useage
- [x] Add a note to the change log
- [x] Perform Benchmark to evaluate cost localview call within or outside of a element loop
- [x] Make changes according to the Benchmark results:
> Policy here:
> 1\.) If `bind(element)` is called within an `element` loop, call `auto fvGeometry = localView(gridGeometry)` before the loop.
> 2\.) If `bind(element)` is only called once (e.g. in certain functions), use the convenience syntax.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2724[disc] Add toString function for discretization method2021-07-22T11:00:06ZTimo Kochtimokoch@math.uio.no[disc] Add toString function for discretization methodThis came up for the Python bindings
!2681 but it also useful otherwise I think.This came up for the Python bindings
!2681 but it also useful otherwise I think.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2687WIP: Feature/metadata extraction2021-10-26T17:45:37ZTimo Kochtimokoch@math.uio.noWIP: Feature/metadata extractionFixes #885
- [ ] Use concepts
- [ ] Think about metadata collection for parallel runsFixes #885
- [ ] Use concepts
- [ ] Think about metadata collection for parallel runs3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2680[WIP][python] Add first draft of python properties generator2021-06-11T11:23:54ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.de[WIP][python] Add first draft of python properties generator3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2142WIP: Feature/freeflow outflow as neumann2021-03-25T08:51:25ZMartin SchneiderWIP: Feature/freeflow outflow as neumannInstead of outflow conditions we want to use Neumann conditions with convenience outflow functions provided in some fluxhelper class.
ToDos
- [x] Check turbulence models
- [ ] Check coupled models
- [ ] Deprecate outflow conditions
- [ ...Instead of outflow conditions we want to use Neumann conditions with convenience outflow functions provided in some fluxhelper class.
ToDos
- [x] Check turbulence models
- [ ] Check coupled models
- [ ] Deprecate outflow conditions
- [ ] Fix failing tests
- [ ] Documentation of helper classes3.5Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1822Feature/box forchheimer2021-07-23T13:53:51ZMartin SchneiderFeature/box forchheimerThe following points needs to be discussed
* [x] Code duplication for velocity calculation (same in darcyslaw and forchheimerslaw)
* [x] The upwind scheme is currently implemented in forchheimerslaw, this should be avoided by changing t...The following points needs to be discussed
* [x] Code duplication for velocity calculation (same in darcyslaw and forchheimerslaw)
* [x] The upwind scheme is currently implemented in forchheimerslaw, this should be avoided by changing the existing `upwindscheme.hh` class3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2987prepare for deprecations and removals in dune-common 2.92022-01-10T14:53:25ZChristoph Grüningerprepare for deprecations and removals in dune-common 2.9See https://gitlab.dune-project.org/core/dune-common/-/merge_requests/1076See https://gitlab.dune-project.org/core/dune-common/-/merge_requests/10763.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2985Feature/improve docker iamge creation script2021-12-20T12:19:03ZDennis GläserFeature/improve docker iamge creation scriptFollowing @bernd s presentation on how to use the script, I made some changes following the suggestions that popped up. I haven't tested it, but it basically is what Bernd demonstrated live, so it should work.Following @bernd s presentation on how to use the script, I made some changes following the suggestions that popped up. I haven't tested it, but it basically is what Bernd demonstrated live, so it should work.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2978Feature/spatialparams examples2021-12-14T12:03:26ZTimo Kochtimokoch@math.uio.noFeature/spatialparams examples3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2977Feature/3d-3d-intersection2022-01-05T19:27:03ZTimo Kochtimokoch@math.uio.noFeature/3d-3d-intersectionAdds polyhedron-polyhedron intersections and convex hull-based triangulation in 3d.
Outlook/side note: this probably also enables #707 in 3d.Adds polyhedron-polyhedron intersections and convex hull-based triangulation in 3d.
Outlook/side note: this probably also enables #707 in 3d.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2976[pnm] Allow the transmissibility of wetting phase to be zero in case of Circl...2021-12-14T08:20:28ZHanchuan Wu[pnm] Allow the transmissibility of wetting phase to be zero in case of Circle throat shapeFor circular throat (`ThroatShape = Circle`) in PNM the wetting layer area can be 0, which leads to 0 transmissibility. Therefore, `std::isfinite` is a better assert than `std::isnormal` which would fail for 0 transmissibilityFor circular throat (`ThroatShape = Circle`) in PNM the wetting layer area can be 0, which leads to 0 transmissibility. Therefore, `std::isfinite` is a better assert than `std::isnormal` which would fail for 0 transmissibility3.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2974[test][1pnc] adjust to new spatialparams2021-12-09T10:21:34ZDennis Gläser[test][1pnc] adjust to new spatialparams3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2972[md] Restructure multidomain tuple wrappers2021-12-14T11:52:38ZTimo Kochtimokoch@math.uio.no[md] Restructure multidomain tuple wrappers* get returns reference like for tuple
* provide const overload for get (pointer access)
* implement asTuple
* implement constructors using wrappers
* implement constructors getting tuples
* make interfaces take value types instead of on...* get returns reference like for tuple
* provide const overload for get (pointer access)
* implement asTuple
* implement constructors using wrappers
* implement constructors getting tuples
* make interfaces take value types instead of only allowing r-value references3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2963Draft: Cleanup/avoid depr warning from facet test2021-12-01T18:08:23ZDennis GläserDraft: Cleanup/avoid depr warning from facet testFixes #1068Fixes #10683.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2959[test][newton][cleanup] Remove time step interface not required anymore from ...2021-11-25T14:06:00ZTimo Kochtimokoch@math.uio.no[test][newton][cleanup] Remove time step interface not required anymore from the stationary assembler3.5Dennis GläserDennis Gläser