dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-11-09T09:47:38Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2708Add new class for calculating wall distance2021-11-09T09:47:38ZKilian WeishauptAdd new class for calculating wall distance* Add geometry utilities for constructing spheres / bounding spheres / circumspheres (these are acutally not used by the wall distance but might be useful in the future now that they are implemented.)
* Add `closestEntity` and `distance`...* Add geometry utilities for constructing spheres / bounding spheres / circumspheres (these are acutally not used by the wall distance but might be useful in the future now that they are implemented.)
* Add `closestEntity` and `distance` queries for point and AABB trees
* Add `DistanceField` a function-like wrapper around a set of geometries to make distance queries at a given sample point
* Add `WallDistance` a class that evaluates discrete distance-to-the-mesh-boundary field at either vertex or element centers
__TODO__
- [x] better test
- [x] Maybe use in existing RANS model
- [x] fix check for UG or ALU in test
- [x] check parallelism? maybe throw
![Screenshot_2021-08-26_at_16.06.13](/uploads/66e7098269e3030b6edd0dcff95c0364/Screenshot_2021-08-26_at_16.06.13.png)3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3134Fix/velocity output2022-05-31T07:40:58ZYue Wangyue.wang@iws.uni-stuttgart.deFix/velocity outputfixes #1161fixes #11613.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3126Use reference instead of copy in for loop in coupling manager2022-05-25T23:10:29ZBernd FlemischUse reference instead of copy in for loop in coupling managerAvoid a compiler warning from gcc 11 in test_md_boundary_ff1p_pnm1p.Avoid a compiler warning from gcc 11 in test_md_boundary_ff1p_pnm1p.3.5Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3119[vtkoutputmodule] Read parameters in constructor2022-05-25T08:21:11ZTimo Kochtimokoch@math.uio.no[vtkoutputmodule] Read parameters in constructorMakes it possible to change parameters by constructing a new VTK module. Local `static` variables were unnecessary here.Makes it possible to change parameters by constructing a new VTK module. Local `static` variables were unnecessary here.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3106[fix] correct the type and value in getParam2022-05-11T09:13:47ZYue Wangyue.wang@iws.uni-stuttgart.de[fix] correct the type and value in getParamfixes the some default value and paramter type in getParamfixes the some default value and paramter type in getParam3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3064Feature/headercheck2022-04-29T09:13:21ZYue Wangyue.wang@iws.uni-stuttgart.deFeature/headercheckHeadercheck before the new release.Headercheck before the new release.3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3063[cleanup] remove the discretization methods in model descriptions2022-04-26T11:19:50ZYue Wangyue.wang@iws.uni-stuttgart.de[cleanup] remove the discretization methods in model descriptionsfixes #1144fixes #11443.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3062[example][biomineralization][material][co2] use new type of CO2 tables,...2022-04-25T13:49:05ZJohannes Hommel[example][biomineralization][material][co2] use new type of CO2 tables,...[example][biomineralization][material][co2] use new type of CO2 tables, generated from NIST homepage
Fixes #1143[example][biomineralization][material][co2] use new type of CO2 tables, generated from NIST homepage
Fixes #11433.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3039Cleanup/move tensor average helper2022-03-31T12:29:51ZMathis KelmCleanup/move tensor average helperMove the tensor-averaging helpers for interfaces from spatialparams to a separate header in `dumux/flux`.
Closes #1097Move the tensor-averaging helpers for interfaces from spatialparams to a separate header in `dumux/flux`.
Closes #10973.5Mathis KelmMathis Kelmhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3034[test] Remove test description in porous medium flow tests2022-04-07T12:50:35ZMathis Kelm[test] Remove test description in porous medium flow testsRemove test descriptions in porous medium flow tests to avoid being outdated (fixes #1106). The other tests, as well as `porousmediumflow/1p/` have already been addressed in !2988.
Progress through test folders:
- [x] 2p @stefaniekiemle...Remove test descriptions in porous medium flow tests to avoid being outdated (fixes #1106). The other tests, as well as `porousmediumflow/1p/` have already been addressed in !2988.
Progress through test folders:
- [x] 2p @stefaniekiemle
- [x] 2p1c @stefaniekiemle
- [x] 2p2c @stefaniekiemle
- [x] 2pnc @stefaniekiemle
- [x] 2pncmin @stefaniekiemle
- [x] 3p @IvBu
- [x] 3p3c @IvBu
- [x] 3pwateroil @IvBu
- [x] co2 @IvBu
- [x] mpnc @IvBu
- [x] richards @yue
- [x] richardsnc @yue
- [x] solidenergy @yue
- [x] tracer @yue3.5Mathis KelmMathis Kelmhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3033[fix][richards] Extended richards: Fix balancequationoptions and do porosity ...2022-04-01T09:59:00ZKatharina Heck[fix][richards] Extended richards: Fix balancequationoptions and do porosity update before evaluating effective diffusion coefficients<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
The richards model never overwrote the balancequation options...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
The richards model never overwrote the balancequation options, which is why, although diffusion was calculated (for the extendend Richards model that considers water diffusion in the gas phase), it was immediatly also substracted, leading to a net diffusive flux of 0. With the richards-specific balancequationopts it depends on the phase index if diffusion is balanced or not. Additionally, the porosity in the volumevariables was updated at the wrong place, now it is updated before the effective diffusion coefficient.
This correction also made it necessary to change the boundary condition in the richards evaporation tests. a fixed value does not work if the liquid phase actually disappears.
fixes #11343.5Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3027Doc/reduce doxyerr log2022-02-23T17:50:52ZMelanie LippDoc/reduce doxyerr log**What this MR does / why does DuMux need it**: Reduces error messages in doxyerr.log to only two lines:
```
/temp1/melaniel/dumux1/dumux/dumux/discretization/cellcentered/elementsolution.hh:144: warning: Member documentation for element...**What this MR does / why does DuMux need it**: Reduces error messages in doxyerr.log to only two lines:
```
/temp1/melaniel/dumux1/dumux/dumux/discretization/cellcentered/elementsolution.hh:144: warning: Member documentation for elementSolution found several times in @ingroup groups!
/temp1/melaniel/dumux1/dumux/dumux/discretization/staggered/elementsolution.hh:62: The member will remain in group CCDiscretization, and won't be put into group StaggeredDiscretization
```
which are lines that we already have not been able to get rid of in previous releases.3.5Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2837Consistent naming in test/references2021-09-30T17:31:42ZFarid MohammadiConsistent naming in test/referencesCloses #1077Closes #10773.5Farid MohammadiFarid Mohammadihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2784Feature/richards fluidsystem2021-08-24T20:56:29ZTimo Kochtimokoch@math.uio.noFeature/richards fluidsystemCloses #1002.
Allow using Richards model with the TwoPImmiscble fluid system.
Uses more general indices and asserts that the phases are as assumed before.
Theoretically not backwards compatible if someone had a custom fluid system wher...Closes #1002.
Allow using Richards model with the TwoPImmiscble fluid system.
Uses more general indices and asserts that the phases are as assumed before.
Theoretically not backwards compatible if someone had a custom fluid system where phases are exchanged. But the error message is clear due to the static assert and it should be easy to fix then.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2736Feature/simplify local view2021-08-20T16:04:14ZNed ColtmanFeature/simplify local viewFixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] ...Fixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] Go through all dumux/ headers and replace useage
- [x] Go through all test/ headers and replace useage
- [x] Add a note to the change log
- [x] Perform Benchmark to evaluate cost localview call within or outside of a element loop
- [x] Make changes according to the Benchmark results:
> Policy here:
> 1\.) If `bind(element)` is called within an `element` loop, call `auto fvGeometry = localView(gridGeometry)` before the loop.
> 2\.) If `bind(element)` is only called once (e.g. in certain functions), use the convenience syntax.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2724[disc] Add toString function for discretization method2021-07-22T11:00:06ZTimo Kochtimokoch@math.uio.no[disc] Add toString function for discretization methodThis came up for the Python bindings
!2681 but it also useful otherwise I think.This came up for the Python bindings
!2681 but it also useful otherwise I think.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1822Feature/box forchheimer2021-07-23T13:53:51ZMartin SchneiderFeature/box forchheimerThe following points needs to be discussed
* [x] Code duplication for velocity calculation (same in darcyslaw and forchheimerslaw)
* [x] The upwind scheme is currently implemented in forchheimerslaw, this should be avoided by changing t...The following points needs to be discussed
* [x] Code duplication for velocity calculation (same in darcyslaw and forchheimerslaw)
* [x] The upwind scheme is currently implemented in forchheimerslaw, this should be avoided by changing the existing `upwindscheme.hh` class3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3157reorder changelog2022-06-02T11:50:52ZBernd Flemischreorder changelogReorder the changes from 3.4 to 3.5 in the changelog.Reorder the changes from 3.4 to 3.5 in the changelog.3.5Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3156Merge branch 'feature/facecentered_localidxfix' into 'master'2022-06-02T11:50:20ZYue Wangyue.wang@iws.uni-stuttgart.deMerge branch 'feature/facecentered_localidxfix' into 'master'[facecentered][convexcorner] fix the local Index logic
See merge request dumux-repositories/dumux!3154
(cherry picked from commit 60653203934979eef3d84388abb0619d0355cb43)
b7c21f27 [facecentered][convexcorner] fix the local Index logic[facecentered][convexcorner] fix the local Index logic
See merge request dumux-repositories/dumux!3154
(cherry picked from commit 60653203934979eef3d84388abb0619d0355cb43)
b7c21f27 [facecentered][convexcorner] fix the local Index logic3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3154[facecentered][convexcorner] fix the local Index logic2024-01-31T10:44:58ZNed Coltman[facecentered][convexcorner] fix the local Index logic<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
I've come across an error whil...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
I've come across an error while using the new face centered staggered scheme. For convex corner geometries, `localIndexOutsideScvfWithSameIntegrationPoint(scvf)` is called from the `outsideScvfWithSameIntegrationPoint(scvf) ` in the `fluxvariables`. The logic doesn't seem to be fool proof, in particular for the scvf with the local index 10.
As 10 is an even number, the function returns an index of 13, which does not typically exist, outside of elements with 2+ boundary faces.
This change should fix this for the local index of 10.
As a reference, here is a confusing quick drawing with all of the local scvf indexes.
![temp_localscvfidx](/uploads/26ec6ff585f142d3bf8fa9bc516c9b07/temp_localscvfidx.png)
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
I believe that this has not been identified yet because we do not have many new freeflow tests with convex corner geometries, especially where the scvf with local index 10 would be involved.
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.de