dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-05-25T18:23:22Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3130[fix] use referece instead of copy in loop2022-05-25T18:23:22ZYue Wangyue.wang@iws.uni-stuttgart.de[fix] use referece instead of copy in loop3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3108Merge branch 'fix/fmt-for-use-with-opm' into 'master'2022-05-11T07:18:18ZYue Wangyue.wang@iws.uni-stuttgart.deMerge branch 'fix/fmt-for-use-with-opm' into 'master'Move fmt to Dumux namespace
Closes #1150
See merge request dumux-repositories/dumux!3099
(cherry picked from commit ffa6d36ff84da95458da34c02ea2a4c796448f15)
dc5d7d03 [fmt] move implementation to namespace Dumux
27942de6 [test] Use F...Move fmt to Dumux namespace
Closes #1150
See merge request dumux-repositories/dumux!3099
(cherry picked from commit ffa6d36ff84da95458da34c02ea2a4c796448f15)
dc5d7d03 [fmt] move implementation to namespace Dumux
27942de6 [test] Use Fmt in cornerpoint test3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3065[cmake]update cmakelists2022-04-26T12:03:29ZYue Wangyue.wang@iws.uni-stuttgart.de[cmake]update cmakelists3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3047Draft: Feature/improve poroelastic doc2022-04-26T10:11:54ZDennis GläserDraft: Feature/improve poroelastic docDepends on !3046Depends on !30463.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3053Feature/use inialize in tests2022-04-22T17:08:39ZTimo Kochtimokoch@math.uio.noFeature/use inialize in tests3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1975WIP: [io][gridmanagerbase] Fix dune deprecation warning2022-03-28T09:36:01ZKilian WeishauptWIP: [io][gridmanagerbase] Fix dune deprecation warningfixes #859
Should probably be backported to 3.2fixes #859
Should probably be backported to 3.23.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2561WIP: analytical case for K-Omega2022-03-07T12:27:35ZNed ColtmanWIP: analytical case for K-Omega**What this MR does / why does DuMux need it**:
- Implements an analytical case for two-eq turbulence models from pre dumux 3.0
**Special notes for your reviewer**:
- Currently no convergence, for future comparison with new staggered im...**What this MR does / why does DuMux need it**:
- Implements an analytical case for two-eq turbulence models from pre dumux 3.0
**Special notes for your reviewer**:
- Currently no convergence, for future comparison with new staggered implementations3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3011Surfactant test2022-02-23T22:19:46ZDmitry PavlovSurfactant testTest of surfactant injection in porous medium (2p2c). Surfactant model is loosely based on the one described [here](https://www.sintef.no/contentassets/0d97862cef164d1c965d268ce5e4e082/surfactant_model.pdf). (Also see [here](https://ntnu...Test of surfactant injection in porous medium (2p2c). Surfactant model is loosely based on the one described [here](https://www.sintef.no/contentassets/0d97862cef164d1c965d268ce5e4e082/surfactant_model.pdf). (Also see [here](https://ntnuopen.ntnu.no/ntnu-xmlui/handle/11250/240038) for a longer version). This test will not work without [MR 2914](!2914).3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2734Draft: Resolve "extrusionFactor should be a spatial parameter interface"2022-02-22T15:00:08ZFelix WeinhardtDraft: Resolve "extrusionFactor should be a spatial parameter interface"Closes #1001Closes #10013.5Felix WeinhardtFelix Weinhardthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2963Draft: Cleanup/avoid depr warning from facet test2021-12-01T18:08:23ZDennis GläserDraft: Cleanup/avoid depr warning from facet testFixes #1068Fixes #10683.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2555Feature/paramlist add old description2021-11-18T16:24:01ZYue Wangyue.wang@iws.uni-stuttgart.deFeature/paramlist add old descriptionfixed #959
The script `generate_parameterlist.py` extracts the parameters from header files.
Per default header files in `test` and `examples` are excluded (user defined parameters).
The file `parameters.json` in `doc/doxygen/extradoc...fixed #959
The script `generate_parameterlist.py` extracts the parameters from header files.
Per default header files in `test` and `examples` are excluded (user defined parameters).
The file `parameters.json` in `doc/doxygen/extradoc` is used as the default input.
The script will take the _explanation, default value, and param type_ of a detected parameter from the input if given. Otherwise, it tries to automatically choose a value.
Hence, if the automatic output is not good for some reason, write the best version into `parameters.json`.
Only ever modify `parameters.json` since `parameters.txt` is auto-generated by the script.
In the JSON file, one can define multiple default values for certain parameters.
In this case, all different values will be listed in the output file.
Parameters which are not found in code but exist in the input file, will be added to the output.
Usage: `./generate_parameterlist.py` (`cwd = dumux/bin/doc`)
After the execution, information will be written in a log file such as
- the code where parameters can not be correctly extracted
- for the parameters with multi entries, all the values are listed. And the default value will be marked with source (input or code)
- added parameters, which maybe manually added in the JSON file
- the list of parameters without explanations3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2824Remove check of number of equations.2021-10-01T14:29:30ZMartin UtzRemove check of number of equations.Since the shallow water viscous momentum flux is only implemented for 2D
depth averaged models, the `ShallowwaterViscousFlux` checks if the number
of equations is equal to three. Unfortunately, this prevents the use of
the viscous flux f...Since the shallow water viscous momentum flux is only implemented for 2D
depth averaged models, the `ShallowwaterViscousFlux` checks if the number
of equations is equal to three. Unfortunately, this prevents the use of
the viscous flux for models which couple shallow water flow and sediment
transport, because these models have more equations.3.5Martin UtzMartin Utzhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2794Draft: Resolve "Discretization method as tag instead of enum"2021-08-25T12:49:26ZIvan BunticDraft: Resolve "Discretization method as tag instead of enum"Closes #1054Closes #10543.5Ivan BunticIvan Buntichttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2612Draft: Resolve "Segfault in McWorther test"2021-08-16T12:19:02ZHanchuan WuDraft: Resolve "Segfault in McWorther test"Closes #1034Closes #10343.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2733Draft: Resolve "extrusionFactor should be a spatial parameter interface"2021-07-28T10:17:47ZFelix WeinhardtDraft: Resolve "extrusionFactor should be a spatial parameter interface"Closes #1001Closes #10013.5Felix WeinhardtFelix Weinhardthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2600Fix/tabulated2dfunction2021-06-28T11:57:12ZDmitry PavlovFix/tabulated2dfunctionThere are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That ...There are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That needs to be fixed.
The second issue is the following code in get():
```c++
int i = max(0, min(m_, static_cast<int>(alpha)));
int j = max(0, min(n_, static_cast<int>(beta)));
```
With `x == xMax`, alpha will be as big as (`m_- 1`) even after the proposed fix to `xToI`. But we need an interval number here, not a point number, and there is no (`m_- 1`)-th interval (not to mention `_m`-th). So we need to cut `i` at (`m_ - 2`). Similarly with `j`.
Without the fix, the assertions in `getSamplePoint`
```c++
assert(0 <= i && i < m_);
assert(0 <= j && j < n_);
```
rightfully fail when `x` is close to `xMax` or `y` is close to `yMax`.
TODO:
* [ ] Check which tests are affected3.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2680[WIP][python] Add first draft of python properties generator2021-06-11T11:23:54ZKilian Weishaupt[WIP][python] Add first draft of python properties generator3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no