dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-07-23T13:53:51Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1822Feature/box forchheimer2021-07-23T13:53:51ZMartin SchneiderFeature/box forchheimerThe following points needs to be discussed
* [x] Code duplication for velocity calculation (same in darcyslaw and forchheimerslaw)
* [x] The upwind scheme is currently implemented in forchheimerslaw, this should be avoided by changing t...The following points needs to be discussed
* [x] Code duplication for velocity calculation (same in darcyslaw and forchheimerslaw)
* [x] The upwind scheme is currently implemented in forchheimerslaw, this should be avoided by changing the existing `upwindscheme.hh` class3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1821[WIP][md] Implement box staggered coupling2022-10-18T06:52:10ZKilian Weishaupt[WIP][md] Implement box staggered couplingTodos:
- [x] Add test for segment-segment intersection algorithm
- [x] Make segment-segment intersection algorithm more efficient
- [x] Put segment-segment in different MR
- [x] Extract Box-Forchheimer to separate MR
- [x] New BJ test ...Todos:
- [x] Add test for segment-segment intersection algorithm
- [x] Make segment-segment intersection algorithm more efficient
- [x] Put segment-segment in different MR
- [x] Extract Box-Forchheimer to separate MR
- [x] New BJ test (existing test uses indefinite perm. matrix)
- [x] Change convergence script to specify convergence rate
- [ ] It currently only works for `DiffusionCoefficientAveragingType::ffOnly`
- [ ] Maxwell Stefan Diffusion law not yet implemented when using Box
- [ ] Renaming: Use ff/pm instead of stokes/darcy
- [ ] New IC assume specific parameter group "Darcy", generalise this
- [ ] Add missing tests
Suggestions:
- [x] Currently, we retrieve the entire context via `couplingContextVector()`, but the old interface is still there. I would shrink this to only one interface and probably rename it. Currently, there is one context object per coupling segment, so maybe we can find a better name.
- [x] At the moment the coupling segment geometry is stored in both the darcy and the stokes coupling info objects in the mapper. I don't think this is the most memory consuming part of the code, but there is room for memory efficiency improvements.
Fixes #788.Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1820[doc] Add script to extract all contributors between two commits2019-12-20T12:55:30ZTimo Kochtimokoch@math.uio.no[doc] Add script to extract all contributors between two commitsI had this hanging around from release manager tasks and thought I could add it.
Prints all authors that committed between two given commits.I had this hanging around from release manager tasks and thought I could add it.
Prints all authors that committed between two given commits.3.2Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1817Feature/test rotationsymmetry2020-04-23T10:48:58ZMartin SchneiderFeature/test rotationsymmetryFixes #787 Fixes #787 3.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1807[vangenuchten] Introduce pore-connectivity parameter L2020-02-01T13:41:56ZTimo Kochtimokoch@math.uio.no[vangenuchten] Introduce pore-connectivity parameter L<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Introduces the pore-connectivity parameter `l`. The para...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Introduces the pore-connectivity parameter `l`. The parameter is used in the relative permeability curve in the Mualem model.
Mualem (1976) suggested that 0.5 is a good value for many soils. Sometimes a
value different from 0.5 is provided, which is why this patch implements it as additional variable.
**Special notes for your reviewer**:
* There was something weird in `krn`. The function uses the factor $`(1-S_{we})^{1/3}`$ but according to the van Genuchten Mualem model this should be $`(1-S_{we})^{1/2}`$ or $`(1-S_{we})^l`$. See Mualem 1976 (https://doi.org/10.1029/WR012i003p00513) and e.g. Dury et all (1999) (https://doi.org/10.1029/1999WR900019). @holle The `1/3` appears e.g. in your habilitation but no other sources than Mualem and van Genuchten are given. Can you comment on where it might come from?
* I believe the derivative $`\frac{\partial k_{rn}}{\partial S_{we}}`$ was wrong. Please recheck the new result before merging.
These two points change the van genuchten material law (not backwards compatible) and could also result in differences in the reference solutions. If the changes get accepted we should
* [x] Add note in changelog about the changes in vangenuchten
* [x] Check tests and possibly update references3.2Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1805[pointsource] Make computation more efficient by not copying vector2019-11-21T16:31:25ZTimo Kochtimokoch@math.uio.no[pointsource] Make computation more efficient by not copying vectorInstead of copying a vector of point sources we just do a local copy of each point source. This way we never copy a vector.Instead of copying a vector of point sources we just do a local copy of each point source. This way we never copy a vector.3.2Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1804[rotationsymmetry] Add convenience traits to construct radially symmetric gri...2019-11-21T22:26:43ZTimo Kochtimokoch@math.uio.no[rotationsymmetry] Add convenience traits to construct radially symmetric grid geometriesAdd a convenience traits class that turn grid geometry traits into radially symmetric grid geometry traitsAdd a convenience traits class that turn grid geometry traits into radially symmetric grid geometry traits3.2Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1803Feature/radially symmetric problems2019-11-21T11:07:07ZTimo Kochtimokoch@math.uio.noFeature/radially symmetric problems**What this MR does / why does DuMux need it:**
A lot of users seem to solve radially symmetric problems. Many use the cake grid manager. However, cake grids are not very easy to use, not efficient (because it's always one or two dimensi...**What this MR does / why does DuMux need it:**
A lot of users seem to solve radially symmetric problems. Many use the cake grid manager. However, cake grids are not very easy to use, not efficient (because it's always one or two dimensions more than you need), and -- most importantly -- not exact for radially-symmetric problems. Actually cake grids should only be used for cake shaped domains but for non-uniform boundary conditions. However, even for these cases it is questionable why this would be better that e.g. an unstructured grid with gmsh, since cake grids have quite bad cell aspect ratios.
This MR helps to implement "real" radially symmetric problems.
**How does it work:**
This implements wrappers for scvs and scvf that turn them into
radially symmetric counterparts by overloading the volume() and
area() functions. We support three modes:
* disc (annulus): A 1d grid is extruded into an annulus or disc
In the case of a disc (inner pos: 0) the inner scvf.area() is 0!
* ball (shell): A 1d grid is extruded into a spherical shell or a ball
In the case of a ball the inner scvf.area() is 0!
* toroid: A 2d grid is extruded into a toroid
In the case that on grid side is aligned with the axis the inner
scvf.area() for all inner scvfs is 0!
The grid points all have to be >= 0!
We also support unstructured grids and random convex shapes.
**How to use it in application code:** you have to modify the traits passed into the grid geometry class, as shown in the test.
**Special notes for your reviewer**:
Once this is merged, we could implement an "example" demonstrating this feature. For example a comparison to an analytic solution.3.2Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1795Fix/error message gridgeometry parallel box2019-11-13T16:47:46ZTimo Kochtimokoch@math.uio.noFix/error message gridgeometry parallel boxThe error in box signifying that box does only work in parallel with zero overlap was accidentally commented in c5787288b78801a9b14bbbabd953c1d56b87e1b9 and slipped the review.
This adds it back in (only concerned caching=false).
T...The error in box signifying that box does only work in parallel with zero overlap was accidentally commented in c5787288b78801a9b14bbbabd953c1d56b87e1b9 and slipped the review.
This adds it back in (only concerned caching=false).
This also adds an error message for the parallel periodic boundaries with box which is currently not implemented.
Should be backported to 3.1.
Fixes #786 3.2Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1785[cakegridmanager] Fix bugs, allow zero well radius2019-11-11T20:39:37ZMartin Schneider[cakegridmanager] Fix bugs, allow zero well radius3.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1781Add script to extract CO2 tables from NIST website2022-03-30T22:03:58ZMartin UtzAdd script to extract CO2 tables from NIST websiteThis MR provides a python script, which can create CO2 tables, like the one used in the CO2 test. The tables contain density and enthalpy values for a specified temperature and pressure range. The CO2 tables are created by the help of a ...This MR provides a python script, which can create CO2 tables, like the one used in the CO2 test. The tables contain density and enthalpy values for a specified temperature and pressure range. The CO2 tables are created by the help of a website (https://webbook.nist.gov/chemistry/fluid), which calculate the needed values. The query for the values is automated by the python script, which also does the formatting of the received values.
The former way to generate the CO2 table was a Fortran script, which can't be published due to copy right issues. Therefore it was decided in #690 to use the NIST website and a python script to generate the new CO2 tables. Both approaches use the formula of Span and Wagner to calculate the values and produce the same result (within a acceptable tolerance). The new approach has the advantage, that we can publish the script.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1772Feature/intersect single geometry2019-10-23T16:16:08ZTimo Kochtimokoch@math.uio.noFeature/intersect single geometry* Add intersectingEntitites overload for intersection of a single geometry with a bounding box tree of an entity set* Add intersectingEntitites overload for intersection of a single geometry with a bounding box tree of an entity set3.2Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1771[geometry] Implement intersection entity set, a set of intersections of two e...2020-04-06T08:05:52ZTimo Kochtimokoch@math.uio.no[geometry] Implement intersection entity set, a set of intersections of two entity sets* [x] Forward multidomain glue to this new and more general implementation
* [x] Add unit test for new class
* [x] Forward multidomain glue to this new and more general implementation
* [x] Add unit test for new class
3.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1769Feature/1d 1d intersection2019-10-21T12:50:59ZTimo Kochtimokoch@math.uio.noFeature/1d 1d intersection3.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1767Fix/master cmake backwards compatibility dune 2.6.02019-12-02T17:55:08ZTimo Kochtimokoch@math.uio.noFix/master cmake backwards compatibility dune 2.6.0Support Dune 2.6.0Support Dune 2.6.03.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1742[1p][tpfa] Implement analytical diff for network grids2019-10-09T16:46:50ZTimo Kochtimokoch@math.uio.no[1p][tpfa] Implement analytical diff for network grids3.1Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1741[common][geometricentityset] Add entity set for Dune geometries2019-12-20T13:05:48ZKilian Weishaupt[common][geometricentityset] Add entity set for Dune geometriesclose #737
__TODO__
- [x] template GeometryType
- [x] add testclose #737
__TODO__
- [x] template GeometryType
- [x] add test3.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1720[test][md] Add a convergence test for a coupled Stokes/Darcy problem2020-03-31T13:37:59ZKilian Weishaupt[test][md] Add a convergence test for a coupled Stokes/Darcy problemThis MR adds a coupled stokes/darcy test for which an analytical reference solution exists, taking
into account the Beavers-Joseph-Saffman slip conditon.
The test checks for convergence. Three different reference solutions can be cho...This MR adds a coupled stokes/darcy test for which an analytical reference solution exists, taking
into account the Beavers-Joseph-Saffman slip conditon.
The test checks for convergence. Three different reference solutions can be chosen on run-time.
We perform the test for the second example of Shiue et al., 2018: "Convergence of the MAC Scheme for the Stokes/Darcy Coupling Problem"
The test comes with a python script that helps to check the mathematical consistency of the reference solution.
It also provides the necessary source term. It can therefore help to add new analytical solutions. 3.2Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1719[WIP] Improve stokes darcy coupling2020-05-11T07:53:50ZKilian Weishaupt[WIP] Improve stokes darcy couplingFor testing, might not be merged.
__Problems__:
* how to make backwards-compatible?
* solution-dependent Dirichlet?
* Neumann-Neumann / Dirichlet-Dirichlet coupling does not yield the same resultsFor testing, might not be merged.
__Problems__:
* how to make backwards-compatible?
* solution-dependent Dirichlet?
* Neumann-Neumann / Dirichlet-Dirichlet coupling does not yield the same resultsKilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1718Feature/newton converged shift or reduction2019-09-19T16:19:09ZMartin SchneiderFeature/newton converged shift or reduction3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no