dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2023-11-07T12:22:13Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3709Fix type in changelog2023-11-07T12:22:13ZMartin UtzFix type in changelogMartin UtzMartin Utzhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2458fix the failing Richards benchmark test2021-02-01T16:58:39ZHanchuan Wufix the failing Richards benchmark testThe problem is figured out. Because the `VanGenuchtenPcHighSweThreshold` and `VanGenuchtenKrwHighSweThreshold` are set to 1.0, which failed the assert check `assert(x_(i) > x_(i-1))` (line 636 in `dumux/common/splinecommon_.hh`) by assig...The problem is figured out. Because the `VanGenuchtenPcHighSweThreshold` and `VanGenuchtenKrwHighSweThreshold` are set to 1.0, which failed the assert check `assert(x_(i) > x_(i-1))` (line 636 in `dumux/common/splinecommon_.hh`) by assigning x_(i) and x_(i-1) both to 1. The simplest way to solve it is easily set `SweThreshold` to some value close to 1 like 0.99999, (0.9999 is still not enough precise for infiltration case). In the end, we need to enlarge `TIMEOUT`, otherwise it fails too.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2600Fix/tabulated2dfunction2021-06-28T11:57:12ZDmitry PavlovFix/tabulated2dfunctionThere are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That ...There are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That needs to be fixed.
The second issue is the following code in get():
```c++
int i = max(0, min(m_, static_cast<int>(alpha)));
int j = max(0, min(n_, static_cast<int>(beta)));
```
With `x == xMax`, alpha will be as big as (`m_- 1`) even after the proposed fix to `xToI`. But we need an interval number here, not a point number, and there is no (`m_- 1`)-th interval (not to mention `_m`-th). So we need to cut `i` at (`m_ - 2`). Similarly with `j`.
Without the fix, the assertions in `getSamplePoint`
```c++
assert(0 <= i && i < m_);
assert(0 <= j && j < n_);
```
rightfully fail when `x` is close to `xMax` or `y` is close to `yMax`.
TODO:
* [ ] Check which tests are affected3.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/937Fix replaceCompEqIdx for freeflow2018-04-30T14:30:57ZSina AckermannFix replaceCompEqIdx for freeflowcloses #482closes #482Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/721Fix/rename fluidsystem file2018-01-02T10:56:34ZBernd FlemischFix/rename fluidsystem fileThomas FetzerThomas Fetzerhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2593Fix of a corner case in inverseCubicPolynomial + test for that corner case2021-05-05T20:33:43ZDmitry PavlovFix of a corner case in inverseCubicPolynomial + test for that corner case3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2756Fix missing header2021-08-02T17:41:30ZHanchuan WuFix missing header3.4Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/109Fix/forgotten renamings decoupled sequential2016-03-10T11:17:00ZTimo Kochtimokoch@math.uio.noFix/forgotten renamings decoupled sequential2.9.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2810Fixed PrimaryVariablesSwitch::reset().2021-09-03T16:31:21ZDmitry PavlovFixed PrimaryVariablesSwitch::reset().resize() does not reset existing values.
There is no other place where wasSwitched_ is cleared.
So the reset() did not work at all.resize() does not reset existing values.
There is no other place where wasSwitched_ is cleared.
So the reset() did not work at all.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2095[fix] change maxRelativeNewtonShift to a stricter criterion to make solution ...2020-04-29T16:16:35ZKatharina Heck[fix] change maxRelativeNewtonShift to a stricter criterion to make solution more stableWith this change the test passes me. Before the pressure solution varied by 1.2 percent.With this change the test passes me. Before the pressure solution varied by 1.2 percent.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3255[ff][cvfe] Implement velocity output for cvfe scheme2022-08-13T18:33:21ZTimo Kochtimokoch@math.uio.no[ff][cvfe] Implement velocity output for cvfe scheme3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2181Feature/variable cakegrid height2020-06-13T16:19:56ZKai WendelFeature/variable cakegrid heightThe CakeGridManager has now an additional input parameter, that allows to change its height. Before this change, it was only possible to create Cake Grids with a height of 1.The CakeGridManager has now an additional input parameter, that allows to change its height. Before this change, it was only possible to create Cake Grids with a height of 1.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/381Feature/use problem shared ptr2017-12-22T13:12:07ZTimo Kochtimokoch@math.uio.noFeature/use problem shared ptrBernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3053Feature/use inialize in tests2022-04-22T17:08:39ZTimo Kochtimokoch@math.uio.noFeature/use inialize in tests3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2244Feature/update box couplingdata2023-12-13T10:52:17ZMartin SchneiderFeature/update box couplingdataUpdate the box coupling such that it works for general non-matching grids.
This is done by introducing general projections onto the stokes faces.Update the box coupling such that it works for general non-matching grids.
This is done by introducing general projections onto the stokes faces.Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1924Feature/tracer multiphase zero sat rebase2020-03-30T18:58:34ZDennis GläserFeature/tracer multiphase zero sat rebaseTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/273Feature/tpfa 1dnd networks2016-12-08T11:30:23ZTimo Kochtimokoch@math.uio.noFeature/tpfa 1dnd networksTODO
* [x] Implement local caching versions
* [x] Fix Upwind scheme. Still buggy, bad convergence and not working for 2p test problem.
* [ ] Add 1d3d convergence testTODO
* [x] Implement local caching versions
* [x] Fix Upwind scheme. Still buggy, bad convergence and not working for 2p test problem.
* [ ] Add 1d3d convergence testDennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1817Feature/test rotationsymmetry2020-04-23T10:48:58ZMartin SchneiderFeature/test rotationsymmetryFixes #787 Fixes #787 3.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1816Feature/tabulated components with constant spacing2019-11-29T15:02:48ZBeatrix BeckerFeature/tabulated components with constant spacingTabularization now uses the same spacing across gas/liquid range (or very close) and adheres to the user-specified number of tabulated values (plus/minus 1 or 2 maybe).
Things to consider: The tabularization test failed with this. Tol...Tabularization now uses the same spacing across gas/liquid range (or very close) and adheres to the user-specified number of tabulated values (plus/minus 1 or 2 maybe).
Things to consider: The tabularization test failed with this. Tolerances were chosen very close to failing already before, though. I raised them to 1% and doubled the number of tabularized values for pressure. Now the test parses. It seems those large errors occured for the gas density, when it was in a range close to the triple point. Here, the calculation of the density changes from iapws to ideal gas law. I assume this causes large non-linearities (or better: a kink) in this region which is not very well resolved with constant spacing (sometimes only 2-3 values are tabularized for the gas density... before there were 200!).
Another thing I noticed: The tabularization test has uncommented lines, testing the pressure tabularization. I assume this is because it fails unless unreasonable high tolerances are set. This should maybe be investigated further. The pressure is calculated vie Newton in the component, maybe something is going wrong there.
I am still checking if other tests fail because of this, currently, hence WIP. Edit: no failing tests on my machine due to this change.
Resolves #755Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1209Feature/restart test2018-11-19T18:17:02ZBeatrix BeckerFeature/restart testSolves #541 (with a few examples). It was decided to test the names in the output of all models with a unit test.Solves #541 (with a few examples). It was decided to test the names in the output of all models with a unit test.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no