dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2019-08-07T11:13:35Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1686Use entity.type() instead of creating a temporary geometry2019-08-07T11:13:35ZTimo Kochtimokoch@math.uio.noUse entity.type() instead of creating a temporary geometryConstructing a geometry may be expensive depending on the grid
implementation.Constructing a geometry may be expensive depending on the grid
implementation.3.1Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1684Improve effective laws2020-04-06T08:44:11ZKilian WeishauptImprove effective lawsFixes #711
Fixes #710
Fixes #733
The goal of this MR is to make the effective laws more general and use the same interfaces for all of them, making them easier accessible. The effective values should then be added in the volumeVar...Fixes #711
Fixes #710
Fixes #733
The goal of this MR is to make the effective laws more general and use the same interfaces for all of them, making them easier accessible. The effective values should then be added in the volumeVariables and which means that then all effective quantities could be accessed from the volumevariables (e.g. in FicksLaw take the effective diffusion coefficient directly from the volumevariables). To make this possible, a common interface in the volumevariables is necessary. To achieve this the following steps are taken in this MR:
- [x] delete the obsolete johansenindices from the thermalconductivityjohansen and get the wetting index directly from the volumevariables (minor change)
- [x] introduce effective diffusion coefficients in all compositional volume variables
- [x] MPFA also needed some fixing adressed in #733.
While introducing the above point it was obvious that currently the diffusion coefficients are treated quite heterogeneously in the volumevariables depending on the model. That is why the suggestion was to introduce a container for the diffusion coefficients so that they can be easier accessed. That means the container deals with transferring the indices for phaseIdx, compIIdx, compJIdx to the right diffusion coefficient. The goal is to use the common interface `diffusioncoefficient(int phaseIdx, int compIIdx, int compJIdx)` in the volumevariables.
Container types for the diffusion coefficients are introduced.
* [x] Depends on a fix in MPFA to handle zero coefficients.
__TODO__
- [x] Revise the maxstef container
- [x] Revise the fixs law container to include a loop for each specialization
- [x] Redo the Volvars to include the update functions and helper lambdas (1p2c, 2p2c)
- [x] Redo the Volvars to include the update functions and helper lambdas (1pnc, 2pnc, mpnc, 3p3c)
- [x] Redo the Volvars to include the update functions and helper lambdas (richardsnc, richards)
- [x] Fix the 1p tracer example which fails.
- [x] Fix the 2p tracer test.
- [x] Redo the Volvars to include the update functions and helper lambdas (3pwateroil)
- [x] Redo the Volvars to include the update functions and helper lambdas (co2)
- [x] Adapt NavierStokesNC for Ficks law.
- [x] Adapt NavierStokesNC for Max-Stef law.
- [x] Remove MPFA warnings
- [x] Adapt Compositional RANS
- [x] Fix all branch related warnings
As of Thursday 2020.01.30 all of the tests compile without branch related deprecation warnings, and pass. This leaves two tasks:
- [x] Address comments in 1543095d232f45e4e53aa48fe45d3186fc214f43
- [x] Try and the reduce property system duplication with better inheritance
- [x] Recommit/squash everything
After Dumux day on the 4th of March:
- [x] Add sentence to changelog3.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1683Automatically create READMEs for examples2019-09-19T10:11:56ZBernd FlemischAutomatically create READMEs for examples3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1680[cmake][test] Increase timeout to be able to test in debug mode2019-07-30T14:12:19ZTimo Kochtimokoch@math.uio.no[cmake][test] Increase timeout to be able to test in debug mode3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1679Feature/add hint to disable prop macro warning2019-07-31T09:32:30ZTimo Kochtimokoch@math.uio.noFeature/add hint to disable prop macro warningdepends on !1678depends on !16783.1Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1664[disc] Enable optional internal Dirichlet constraints2019-10-02T14:55:12ZTimo Kochtimokoch@math.uio.no[disc] Enable optional internal Dirichlet constraints<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Implements internal Dirichlet constraints. There is no o...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Implements internal Dirichlet constraints. There is no overhead if it's not manually enabled in the problem.
fixes #705
* [x] cell-centered
* [x] box
* [x] add a test3.1Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1661Feature/output vtk path from inputfile2019-08-07T09:34:47ZTimo Kochtimokoch@math.uio.noFeature/output vtk path from inputfile<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This adds a path prefix to the name given to the output modu...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This adds a path prefix to the name given to the output module. This way the vtk output files can be written to a different folder.
<!--
**Which issue this MR fixes** *(optional - uncomment and add issue)*:
fixes #
-->
**Special notes for your reviewer**:
The argument `path` of the `Dune::VTKSequenceWriter` only changes the path of the vtu files, not the pvd, so it doesn't give the desired effect.3.1Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1656[glue] check non-uniqueness of raw intersection geometries only if dim1 != dim22019-07-05T16:13:53ZDennis Gläser[glue] check non-uniqueness of raw intersection geometries only if dim1 != dim2This is an memory and runtime optimization for the equidimensional intersection case.This is an memory and runtime optimization for the equidimensional intersection case.3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1652[test] Remove numpy dependency2019-06-27T18:07:59ZTimo Kochtimokoch@math.uio.no[test] Remove numpy dependencyFixes #731Fixes #7313.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1648WIP: Feature/simplify effectivelaws - Do not merge!2019-08-05T18:27:27ZGabi SeitzWIP: Feature/simplify effectivelaws - Do not merge!Fixes #711
Fixes #710
Fixes #733
* [x] Depends on a fix in MPFA to handle zero coefficients.
This MR is outdated and superseded by !1684
Fixes #711
Fixes #710
Fixes #733
* [x] Depends on a fix in MPFA to handle zero coefficients.
This MR is outdated and superseded by !1684
3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1647Feature/generalize fvgridgeometry2019-12-19T11:11:44ZSimon EmmertFeature/generalize fvgridgeometry**What this MR does / why does DuMux need it**:
So far this renames FVGridGeometry to GridGeometry for box, tpfa, mpfa and staggered.
** Things left to do:**
* [x] deprecate FVGridGeometry property correctly
* [x] open new M...**What this MR does / why does DuMux need it**:
So far this renames FVGridGeometry to GridGeometry for box, tpfa, mpfa and staggered.
** Things left to do:**
* [x] deprecate FVGridGeometry property correctly
* [x] open new MR with renaming and deprecation of all places where a public FVGridGeometry is used --> see !1700
* [x] discuss if a warning needs to be thrown and where (e.g. similar to the property-system warning
* [x] merge !1700 after testing this branch thoroughly (this branch is how it will look like to a user, before taking care of the deprecation warnings)
<!--
**Which issue this MR fixes** *(optional - uncomment and add issue)*:
fixes #719
-->
**Special notes for your reviewer**:
This now only changes and deprecates the aliases for the fvelementgeometry.hh files, the renaming and deprecation of all other instances (in the tests etc) will be done in a new MR.
Fixes #719 3.1Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1646Feature/optimize projector2019-07-01T09:44:53ZDennis GläserFeature/optimize projectorFixes #708 Fixes #708 3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1625Feature/2d 2d intersections2019-06-17T12:10:49ZDennis GläserFeature/2d 2d intersectionsDepends on the hasParamInGroup fix in !1628.Depends on the hasParamInGroup fix in !1628.3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1620Feature/monotone cubic spline2019-05-29T10:08:34ZTimo Kochtimokoch@math.uio.noFeature/monotone cubic splineFixes #712.
Implements monotone cubic spline due to Fritsch & Butland (1984) (https://doi.org/10.1137/0905021)Fixes #712.
Implements monotone cubic spline due to Fritsch & Butland (1984) (https://doi.org/10.1137/0905021)3.1Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1616Feature/free-function-make-glue2019-05-27T11:31:39ZDennis GläserFeature/free-function-make-glueThis moves the class MixedDimensionGlue into the more generic MultiDomainGlue class. The order of the template and constructor arguments now doesn't matter anymore, as additionally we provide the overloads of GeometryIntersection for the...This moves the class MixedDimensionGlue into the more generic MultiDomainGlue class. The order of the template and constructor arguments now doesn't matter anymore, as additionally we provide the overloads of GeometryIntersection for the reverse order of template arguments.3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1614Feature/fem gridgeometry2019-05-24T12:46:29ZTimo Kochtimokoch@math.uio.noFeature/fem gridgeometry3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1613Feature/rename basevfgridgeometry2019-05-23T09:09:22ZTimo Kochtimokoch@math.uio.noFeature/rename basevfgridgeometry3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1612[io] Add RasterImageReader2019-06-01T10:53:35ZKilian Weishaupt[io] Add RasterImageReader- [x] make reader static/stateless
- [x] add documentation and changelog- [x] make reader static/stateless
- [x] add documentation and changelog3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1611[io][gridmanager] Improve error message if grid manager not found2019-05-22T18:17:12ZTimo Kochtimokoch@math.uio.no[io][gridmanager] Improve error message if grid manager not found3.1Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1610Feature/tracer multiphase test zero saturation2020-03-30T20:16:37ZTimo Kochtimokoch@math.uio.noFeature/tracer multiphase test zero saturationFixes #704 by introducing a regularization for the saturation if it is zero to avoid singular matrices in areas where there is no transporting fluid and hence no tracer.
Solution:
![tracer](/uploads/518c3151f82f9c3aea77b556c4a6726c/t...Fixes #704 by introducing a regularization for the saturation if it is zero to avoid singular matrices in areas where there is no transporting fluid and hence no tracer.
Solution:
![tracer](/uploads/518c3151f82f9c3aea77b556c4a6726c/tracer.gif)
Depends on #733 to be fixed3.2Dennis GläserDennis Gläser