dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2020-06-25T08:44:16Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2187Feature/newton relative shift2020-06-25T08:44:16ZTimo Kochtimokoch@math.uio.noFeature/newton relative shift3.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2186[newton] Extract privarswitch implementation to separate class2020-06-19T17:57:39ZTimo Kochtimokoch@math.uio.no[newton] Extract privarswitch implementation to separate class3.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2184Feature/improve cleanup 1d3d couplingmanager2020-06-25T16:34:01ZTimo Kochtimokoch@math.uio.noFeature/improve cleanup 1d3d couplingmanagerSeveral smaller cleanups and improvements in the 1d3d coupling manager
* Use GridIndex
* Optimise point source data performance by not using maps
* Optimise integration point source by only storing a single element index
* Add possibili...Several smaller cleanups and improvements in the 1d3d coupling manager
* Use GridIndex
* Optimise point source data performance by not using maps
* Optimise integration point source by only storing a single element index
* Add possibility to distribute integration point source with box trial functions
* Rename fvGridGeometry -> gridGeometry
Affects only the test with the label `multidomain_embedded`3.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2182[test] Add test for 2p rotation-symmetric toroid policy unstr. grid2020-06-15T16:57:36ZTimo Kochtimokoch@math.uio.no[test] Add test for 2p rotation-symmetric toroid policy unstr. grid* Add 2p test with density-driven water and air separation in dome-shaped rotational symmetric domain* Add 2p test with density-driven water and air separation in dome-shaped rotational symmetric domain3.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2180Feature/cylinder integration2020-06-22T11:42:51ZTimo Kochtimokoch@math.uio.noFeature/cylinder integrationDepends on !2178 to be merged first.
* Add tool to integrate over cylindrical domain with lowest order formula by dividing the cylinder in small finite integration volumes
* Add tool for elliptic cylinder and ellipse as well
* Add a...Depends on !2178 to be merged first.
* Add tool to integrate over cylindrical domain with lowest order formula by dividing the cylinder in small finite integration volumes
* Add tool for elliptic cylinder and ellipse as well
* Add a unit test for all tools (so far the only test for this feature) -> `test_cylinderintegration`3.3Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2179[test] Make transformation more natural: first rotate then scale and translate2020-06-17T06:21:51ZTimo Kochtimokoch@math.uio.no[test] Make transformation more natural: first rotate then scale and translateThis is used in the tests
* test_0d3d_intersection
* test_0d2d_intersection
Should be enough to check these. Pass for me.This is used in the tests
* test_0d3d_intersection
* test_0d2d_intersection
Should be enough to check these. Pass for me.3.3Tim JupeTim Jupehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2178Feature/cirle points optimized2020-06-15T14:52:34ZTimo Kochtimokoch@math.uio.noFeature/cirle points optimized* Add version with precomputed sine and cosine
* Add unit test
* Affected tests:
- `make build_multidomain_embedded_tests` (`ctest -L multidomain_embedded`)
- `test_circlepoints`* Add version with precomputed sine and cosine
* Add unit test
* Affected tests:
- `make build_multidomain_embedded_tests` (`ctest -L multidomain_embedded`)
- `test_circlepoints`3.3Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2177Add multidomain gmres solver backend2020-06-12T08:33:01ZTimo Kochtimokoch@math.uio.noAdd multidomain gmres solver backend3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2176Feature/intersecting entities cartesian2020-06-12T08:27:55ZTimo Kochtimokoch@math.uio.noFeature/intersecting entities cartesian3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2172Enable rotational-symmetric geometries for the staggered/freeflow models2020-06-22T16:09:17ZTimo Kochtimokoch@math.uio.noEnable rotational-symmetric geometries for the staggered/freeflow models* Add classes for face-related frontal/lateral scvfs and scvs so they can be modified through the traits
* Make makeBoundaryFace a free function. This allows the scvf to be wrapped (as necessary for rotational-symmetric geometries)
* A...* Add classes for face-related frontal/lateral scvfs and scvs so they can be modified through the traits
* Make makeBoundaryFace a free function. This allows the scvf to be wrapped (as necessary for rotational-symmetric geometries)
* Add rotational-symmetric stationary stokes pipe flow problem3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2169Feature/simplify staggered upwind fluxvars2020-06-08T15:16:50ZTimo Kochtimokoch@math.uio.noFeature/simplify staggered upwind fluxvarsSimplifies the upwind flux vars. Is based on !2168 so that MR should be merged first.
@nedc @kweis There is a bugfix in the last commit. I'm not sure if this is correct and when the case exactly occurs. The kovasznay tests pass.
TO...Simplifies the upwind flux vars. Is based on !2168 so that MR should be merged first.
@nedc @kweis There is a bugfix in the last commit. I'm not sure if this is correct and when the case exactly occurs. The kovasznay tests pass.
TODO
* [x] Rename upwind header
* [x] `static_assert` that higher order only works with caching enabled (different MR)
* [x] Add TODO note that higher order is only higher order for incompressible flow (different MR)
* [x] `static_assert` that only up to second order upwinding is implemented
@nedc @kweis Also something seems to be wrong with the densities in the lateral upwind momentum. First order uses once inside once outside (here https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2169/diffs#44bceb1eaa3ec17ea5ff08b356165ffbac56c5d6_460_332), higher order uses always inside (here https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2169/diffs#44bceb1eaa3ec17ea5ff08b356165ffbac56c5d6_316_279) or outside for the density.3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2168Feature/cleanup staggered geoflux helpers2020-06-08T06:53:58ZTimo Kochtimokoch@math.uio.noFeature/cleanup staggered geoflux helpersSimplify higher order geo helper algorithmsSimplify higher order geo helper algorithms3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2153Implement defaults for FluxVariablesCache(Filler) properties for mpfa/tpfa2020-06-01T10:59:37ZBernd FlemischImplement defaults for FluxVariablesCache(Filler) properties for mpfa/tpfaFixes #867.
Please backport to 3.2.Fixes #867.
Please backport to 3.2.3.3Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2150Translate install script to Python2020-06-25T18:23:52ZFarid MohammadiTranslate install script to Pythonpart of #883 part of #883 3.3Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2147[constraintsolver] Improve error handler and error message2020-05-29T08:24:45ZTimo Kochtimokoch@math.uio.no[constraintsolver] Improve error handler and error message* Improve message (remove assumption about time step reduction; use correct wording (solve LES not matrix))
* Do not provide default handler that doesn't even rethrow* Improve message (remove assumption about time step reduction; use correct wording (solve LES not matrix))
* Do not provide default handler that doesn't even rethrow3.3Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2142WIP: Feature/freeflow outflow as neumann2022-09-01T07:09:15ZMartin SchneiderWIP: Feature/freeflow outflow as neumannInstead of outflow conditions we want to use Neumann conditions with convenience outflow functions provided in some fluxhelper class.
ToDos
- [x] Check turbulence models
- [ ] Check coupled models
- [ ] Deprecate outflow conditions
- [ ...Instead of outflow conditions we want to use Neumann conditions with convenience outflow functions provided in some fluxhelper class.
ToDos
- [x] Check turbulence models
- [ ] Check coupled models
- [ ] Deprecate outflow conditions
- [ ] Fix failing tests
- [ ] Documentation of helper classes3.7https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2137WIP: [newton] Generalize Newton implementation for different solution types2021-03-24T16:18:08ZTimo Kochtimokoch@math.uio.noWIP: [newton] Generalize Newton implementation for different solution types* [x] Extract Privarswitch logic/implementation into separate class
* [ ] Extract partial reassembler logic into seperate class
* [ ] Provide external helpers for relative shift* [x] Extract Privarswitch logic/implementation into separate class
* [ ] Extract partial reassembler logic into seperate class
* [ ] Provide external helpers for relative shifthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2132Export element type in FV element geometry2020-05-19T10:11:41ZTimo Kochtimokoch@math.uio.noExport element type in FV element geometryI always found it strange that you can't get the element type from an `FVElementGeometry` object.I always found it strange that you can't get the element type from an `FVElementGeometry` object.3.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2130WIP Feature/finite element method2023-12-13T10:52:17ZDennis GläserWIP Feature/finite element methodThis is a first draft of an FEM framework. Currently, major limitations/assumptions are:
* assumes Standard-Galerkin approach
* assumes non-composite dune function space bases
I have tried to incorporate suggestions stemming from the d...This is a first draft of an FEM framework. Currently, major limitations/assumptions are:
* assumes Standard-Galerkin approach
* assumes non-composite dune function space bases
I have tried to incorporate suggestions stemming from the discussion in #884, in particular it is:
1. The state of the grid variables was always dependent on the problem (e.g. due to BCs) and a current solution. Nevertheless, we had grid variables and problem and cursol as arguments in several assembly-related functions. In particular, we did `assembler.assemble(curSol)`. The assembler introduced here fulfills this interface (for compatibility with NewtonSolver), but does not use curSol. Instead, the assembler is instantiated with grid variables, which are updated with a solution and a problem. Thus, the assembler takes the solution and problem from the grid variables. So, you would want to do `Assembler assembler(gridVariables); assembler.assemble()`. This could help implementing other time stepping schemes, where you create grid variables on different time levels (stages), make an assembler from them and let it assemble the stage. The assembler is basically a copy of `FVAssembler`, which was almost general and non fv-specific. There is one piece of commented code related to parallelism with box (with a todo in the comment) which has to be figured out still.
2. Local assemblers are now a `localView` of the assembler, no which you then call `bind` with only an element. The problem & current solution are extracted from the grid variables with which the assembler was instantiated. This guarantees that a wrong combination of _problem state_, _solution state_ and _grid variables state_ is passed to it.
3. None of the classes use the property system anymore. I wrote a little test solving a poisson equation, which completely works without the property system. See test/discretization/fem/poisson. Therein, a problem and local residual have to be implemented. Currently, I implemented it in a "Dumux conforming" way, also implementing a spatial parameters class that stores the tensor and an "IntegrationPointVariables" class (the equivalent of vol vars in fv schemes), which hold the tensor at an integration point. The test implementation could be simplified very much if the custom local residual simply called `problem.getTensor()` or so - that would get rid of the spatial params and the integration point variables implementations. I did it this way for now to illustrate the complete workflow for implementing a new model and test.
All of this is subject to discussion, and all new headers have "TODOs" all over the place which can be discussed.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2126[WIP] Feature/ff stokes reverse coupling2023-12-13T10:52:17ZKilian Weishaupt[WIP] Feature/ff stokes reverse coupling__TODO__
- [x] make backwards compatible
- [ ] fix failing tests
- [ ] implement for compositional, compressible flow
depends on !2128 !2133__TODO__
- [x] make backwards compatible
- [ ] fix failing tests
- [ ] implement for compositional, compressible flow
depends on !2128 !2133Kilian WeishauptKilian Weishaupt