dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2020-10-09T10:31:19Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2227WIP: Feature/new ic condition22020-10-09T10:31:19ZLars KaiserWIP: Feature/new ic condition2<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This MR implements new coupling conditions for stokes-darcy i...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This MR implements new coupling conditions for stokes-darcy interfaces, as proposed/described by Elissa Eggenweiler. The new interface conditions are meant to be more general and appropriate in comparison to the Beavers-Joseph condition and the current normal momentum coupling.
<!--
**Which issue this MR fixes** *(optional - uncomment and add issue)*:
fixes #
-->
**TODO**:
- [x] Combine new/standardPorousMediumVelocity, beaversJoseph/nTangentialVelocity and old/newMomentumCouplingCondition
- [x] Allow unsymmetrizedStressTensorForBJ and unsymmetrizedStressTensorForIC!
- [x] Set up two tests: Beaver-Josephs and newIC, see: dumux/test/multidomain/boundary/stokesdarcy/1p_1p, @Elissa
- [ ] Check deprecation and documentation, link to paper from Elissa?
- [x] Add warning for newIC with symmetrized tensor
- [x] Folder and file names should not contain capital letters.
- [x] Follow styleguide: Correct indent, curly braces
- [x] Small TODOs in project
**Special notes for your reviewer**:
I appreciate all help regarding the technicalities of the merge request.Lars KaiserLars Kaiserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2222WIP: MR Translate the dockerimage shell script to python2021-03-25T09:31:08ZMartin UtzWIP: MR Translate the dockerimage shell script to pythonpart of #883
WIP because it has to wait for !2220part of #883
WIP because it has to wait for !2220Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2217[WIP] Feature/new staggered parallel2021-11-09T06:51:45ZKilian Weishaupt[WIP] Feature/new staggered parallelhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2199WIP [md][embedded] fix call to cm.problem()2020-06-25T17:06:38ZDennis GläserWIP [md][embedded] fix call to cm.problem()`couplingManager.problem()` was called with std::size_t although it expects `Dune::index_constant<std::size_t`, which did not compile.`couplingManager.problem()` was called with std::size_t although it expects `Dune::index_constant<std::size_t`, which did not compile.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2190WIP: Feature/integration rebase22020-10-29T22:53:11ZTimo Kochtimokoch@math.uio.noWIP: Feature/integration rebase2https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2181Feature/variable cakegrid height2020-06-13T16:19:56ZKai WendelFeature/variable cakegrid heightThe CakeGridManager has now an additional input parameter, that allows to change its height. Before this change, it was only possible to create Cake Grids with a height of 1.The CakeGridManager has now an additional input parameter, that allows to change its height. Before this change, it was only possible to create Cake Grids with a height of 1.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2175WIP: Coupling concepts 1d3d2020-10-29T22:53:51ZTimo Kochtimokoch@math.uio.noWIP: Coupling concepts 1d3dThis has to be split up in separate MRs.
* [x] intersecting entities cartesian grid -> !2176
* [x] Block-diagonal ILU0 GMres solver -> !2177
* [x] Optimized circle points -> !2178
* [x] Cylinder integration -> !2180 (contains some in...This has to be split up in separate MRs.
* [x] intersecting entities cartesian grid -> !2176
* [x] Block-diagonal ILU0 GMres solver -> !2177
* [x] Optimized circle points -> !2178
* [x] Cylinder integration -> !2180 (contains some interface changes wrt this branch)
* [x] Several smaller cleanups and improvements in the 1d3d coupling manager !2184 (use GridIndex, optimise point source data performance by not using maps, optimise integration point source by only storing a single element index, add possibility to distribute integration point source with box trial functions, rename fvGridGeometry -> gridGeometry)
* [x] polyline debug output helper !2191
* [x] Geometry distance helpers !2192
* [x] Implement internal Dirichlet constraints !2202
* [x] Add changes in coupling manager in some wayhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2173WIP: Coupling concepts 1d3d (old)2020-10-29T22:54:07ZTimo Kochtimokoch@math.uio.noWIP: Coupling concepts 1d3d (old)https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2162[WIP] Feature/restructure ff fluxvars2023-12-13T10:52:17ZKilian Weishaupt[WIP] Feature/restructure ff fluxvarshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2161[cleanup] Use find PTScotch from Dune2020-06-01T11:04:48ZTimo Kochtimokoch@math.uio.no[cleanup] Use find PTScotch from Dune@gruenich We don't need this here, right? And it might even overwrite the stuff that Dune found!?@gruenich We don't need this here, right? And it might even overwrite the stuff that Dune found!?3.3Christoph GrüningerChristoph Grüningerhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2134WIP Feature/timestepper test2021-03-25T09:14:10ZDennis GläserWIP Feature/timestepper testMany todos...
One of them:
- [ ] rethink commit providing access to assembler/linear solver in PDESolver
Furthermore, I guess we have to rethink our plan to not provide the current solution to the PDESolver/assembler - as a reminder: t...Many todos...
One of them:
- [ ] rethink commit providing access to assembler/linear solver in PDESolver
Furthermore, I guess we have to rethink our plan to not provide the current solution to the PDESolver/assembler - as a reminder: the motivation was to avoid multiple calls to gridVars.init() or update() in case users have instantiated grid vars before assembly. What we also wanted to achieve is that, when a user creates grid vars and a solution in the main file, after the time integration procedure we said we'd like both the solution and the grid variables to be on the state after time integration withouth the user having to do anything.
The problem is - I changed the (grid)variables concept such that they store a pointer to the solution with which they were updated. However, if we change that pointer in update() which is, for instance, called from the NewtonSolver after an iteration, this changes the pointer in the grid variables of the user as the user grid vars are used in the last stage of time integration such that everything is written into them. Now it works because the time stepper receives a user solution vector (in which to store the solution), which is the one stored in the user grid variables, and which is forwarded to the PDESolver. So the whole chain uses that solution vector. But, I guess we have to think more about this as this is error-prone. If the user provides another solution vector to store the result in then the grid variables won't be up to date after time integration. This issue is a general one in our current assembly concept (as we discussed).
W.r.t. time integration: what we could do is to always use temporary grid variables for all stages (also the last) and copy the last grid variables into the user grid vars. But, as the solution vector that created the object is a temporary, the pointer would lose validity - this could only be fixed using shared_ptr everywhere... But maybe we find a better way.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2125WIP: [assembly] Add element view for assembly routines2023-05-31T13:24:04ZTimo Kochtimokoch@math.uio.noWIP: [assembly] Add element view for assembly routinesSuggestion for an element view for assembly rountinesSuggestion for an element view for assembly rountineshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2112WIP: Cleanup/assembly properties2023-12-13T10:52:17ZTimo Kochtimokoch@math.uio.noWIP: Cleanup/assembly properties* [ ] test everything
* [ ] update changelog for `ElementBoundaryTypes` in `LocalResidual`
* [ ] think about `NumEqVector`* [ ] test everything
* [ ] update changelog for `ElementBoundaryTypes` in `LocalResidual`
* [ ] think about `NumEqVector`Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2095[fix] change maxRelativeNewtonShift to a stricter criterion to make solution ...2020-04-29T16:16:35ZKatharina Heck[fix] change maxRelativeNewtonShift to a stricter criterion to make solution more stableWith this change the test passes me. Before the pressure solution varied by 1.2 percent.With this change the test passes me. Before the pressure solution varied by 1.2 percent.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2058[WIP] Cleanup/matrixconverter2020-04-27T13:40:31ZKilian Weishaupt[WIP] Cleanup/matrixconverterCannot be backported to 3.2Cannot be backported to 3.23.3Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1975WIP: [io][gridmanagerbase] Fix dune deprecation warning2022-03-28T09:36:01ZKilian WeishauptWIP: [io][gridmanagerbase] Fix dune deprecation warningfixes #859
Should probably be backported to 3.2fixes #859
Should probably be backported to 3.23.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1950WIP: Block-diagonal AMG in parallel2023-02-22T21:10:03ZBernd FlemischWIP: Block-diagonal AMG in parallelMake the `BlockDiagAMGBiCGSTABSolver` work in parallel.
On the user side, this requires passing argument and template tuples. For the currently working test in `multidomain/poroelastic/el1p`, this amounts to
```cpp
using GridGeometr...Make the `BlockDiagAMGBiCGSTABSolver` work in parallel.
On the user side, this requires passing argument and template tuples. For the currently working test in `multidomain/poroelastic/el1p`, this amounts to
```cpp
using GridGeometries = std::tuple<OnePFVGridGeometry, PoroMechFVGridGeometry>;
using LinearSolver = BlockDiagAMGBiCGSTABSolver<GridGeometries>;
auto views = std::make_tuple(std::cref(leafGridView), std::cref(leafGridView));
auto mappers = std::make_tuple(onePFvGridGeometry->dofMapper(), poroMechFvGridGeometry->dofMapper());
auto groups = std::make_tuple(std::string("OneP"), std::string("PoroElastic"));
auto linearSolver = std::make_shared<LinearSolver>(views, mappers, groups);
```
1. [x] Make it work for [dumux-sediment](https://git.iws.uni-stuttgart.de/dumux-appl/dumux-sediment).
2. [x] Make it work for `YaspGrid`, `UGGrid` and `ALUGrid`.
3. [x] Decide where to put what.3.7Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1941WIP: Feature/example rot sym2020-04-23T10:50:07ZMartin SchneiderWIP: Feature/example rot symFixes #787
ToDos:
* [x] Update documentation, especially in spatialparams
* [x] explain rotationsymmetricgridgeometrytraits
* [x] write 1p equation in radial coordinates and specify analytical solution
* [x] generate and include...Fixes #787
ToDos:
* [x] Update documentation, especially in spatialparams
* [x] explain rotationsymmetricgridgeometrytraits
* [x] write 1p equation in radial coordinates and specify analytical solution
* [x] generate and include result pictures
* [x] maybe also explain how the paraview filter can be used for visualization
* [x] Move calculate L2 error to main.cc
* [x] Move add vtk output to main.cc3.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1930WIP cleanup/use lambdas for isvalid2020-04-06T18:31:11ZDennis GläserWIP cleanup/use lambdas for isvalidTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1924Feature/tracer multiphase zero sat rebase2020-03-30T18:58:34ZDennis GläserFeature/tracer multiphase zero sat rebaseTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no