dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-10-01T09:12:03Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1213Remove warnings Wfloat-equal from dumux.2018-10-01T09:12:03ZMelanie LippRemove warnings Wfloat-equal from dumux.Related issue: #469Related issue: #469Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1210[feature] add restart facility for mpnc2018-10-10T14:32:36ZKatharina Heck[feature] add restart facility for mpncI tested this with the obstacle test and it produced the same result but I did not add a new test, since we want to deal with that in #570.
updating the reference solution was necessary as we need to include the fugacities in the output...I tested this with the obstacle test and it produced the same result but I did not add a new test, since we want to deal with that in #570.
updating the reference solution was necessary as we need to include the fugacities in the output because they are primary variables.
- [x] change reference solution for the nonequilibrium testsBernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1209Feature/restart test2018-11-19T18:17:02ZBeatrix BeckerFeature/restart testSolves #541 (with a few examples). It was decided to test the names in the output of all models with a unit test.Solves #541 (with a few examples). It was decided to test the names in the output of all models with a unit test.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1207[vtk][elastic] load solution for elasticity2018-08-29T14:17:53ZBernd Flemisch[vtk][elastic] load solution for elasticityGeneralize loadSolution such vector fields, namely, fields with
numberOfComponents > 1, can be read. Add primaryVariableName for
elastic. Test.Generalize loadSolution such vector fields, namely, fields with
numberOfComponents > 1, can be read. Add primaryVariableName for
elastic. Test.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1206Feature/restart for mineralization2018-08-30T07:17:42ZKatharina HeckFeature/restart for mineralizationBernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1203[test] Use FoamGrid for 2d in 3d grid as alu doesn't support networks just su...2018-08-29T09:16:40ZTimo Kochtimokoch@math.uio.no[test] Use FoamGrid for 2d in 3d grid as alu doesn't support networks just surfacesFixes #567.
dune-alugrid only supports surface not network grids. The resulting vtk file was still correct as it doesn't care about face connectivity. But the assert signified that something is wrong.
Now we use dune-foamgrid, the grid ...Fixes #567.
dune-alugrid only supports surface not network grids. The resulting vtk file was still correct as it doesn't care about face connectivity. But the assert signified that something is wrong.
Now we use dune-foamgrid, the grid was also made with dune-foamgrid.3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1200Feature/update coupling context staggered2018-11-14T10:35:48ZKilian WeishauptFeature/update coupling context staggered3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1194[fix][multidomain][stokesdarcy] fix convective coupling so that it is energy ...2018-08-27T13:21:48ZKatharina Heck[fix][multidomain][stokesdarcy] fix convective coupling so that it is energy conservativeKilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1193[staggered][subdomainlocalassembler] Consider storage term and boundary in…2018-08-28T09:37:41ZMelanie Lipp[staggered][subdomainlocalassembler] Consider storage term and boundary in…[staggered][subdomainlocalassembler] Consider storage term and boundary in assembling face residual.[staggered][subdomainlocalassembler] Consider storage term and boundary in assembling face residual.Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1192[spatialparams][test] free spatial parameters from typetag2018-08-28T20:17:30ZBernd Flemisch[spatialparams][test] free spatial parameters from typetagPartly fi xes issue #555.Partly fi xes issue #555.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1189[mpfa][props] add missing include2018-08-22T07:15:11ZDennis Gläser[mpfa][props] add missing includeIf a problem was created where only mpfa was used, i.e. only the mpfa properties were included, there was an error from the property system which stem from this missing include. We never ran into this problem because we always have sever...If a problem was created where only mpfa was used, i.e. only the mpfa properties were included, there was an error from the property system which stem from this missing include. We never ran into this problem because we always have several discretization methods being tested with one problem file.
To reproduce this error choose any test and comment out the includes of tpfa or box. Then try to compile the mpfa test which should give an error. With this commit the error should disappear.Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1187[box] allow mixed-type boundary conditions for box2018-08-16T16:48:42ZBernd Flemisch[box] allow mixed-type boundary conditions for boxTest in test/geomechanics/elastic.
Fixes #560.Test in test/geomechanics/elastic.
Fixes #560.3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1186[facet][box][fvgridgeom] use correct codim for facet mapper2018-08-21T19:15:19ZDennis Gläser[facet][box][fvgridgeom] use correct codim for facet mapperTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1185[staggered][freeflow] Print position of failing BC2018-08-20T08:37:01ZKilian Weishaupt[staggered][freeflow] Print position of failing BC3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1183[material][porodeformation] use correct law2018-08-16T08:37:34ZDennis Gläser[material][porodeformation] use correct lawTODO:
* [x] how to treat porosities > 1.0TODO:
* [x] how to treat porosities > 1.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1182Feature/improve fixed cell ff2018-11-09T14:14:24ZKilian WeishauptFeature/improve fixed cell ff- [x] check tests, adapt ref sols
- [x] check setting value within domain- [x] check tests, adapt ref sols
- [x] check setting value within domainNed ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1180Fix/staggered memory leak2018-08-14T13:45:11ZKilian WeishauptFix/staggered memory leakTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1176fix fracture facet determination in box-dfm framework2018-08-30T07:09:15ZDennis Gläserfix fracture facet determination in box-dfm frameworkWe reuse the grid creation facility of the facet coupling framework and
require grid files that have the information on the fracture facets in
them. This enables us to reuse the codimension one grid adapter of the
facet coupling frame...We reuse the grid creation facility of the facet coupling framework and
require grid files that have the information on the fracture facets in
them. This enables us to reuse the codimension one grid adapter of the
facet coupling framework to identify which matrix element facets
coincide with a fracture.
This also introduces a test on the same geometry as in the 2.12 release.
TODO:
* [x] reintroduce tests for quads
* [x] reintroduce tests for tetrahedraBernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1175[fluidsystem][brineco2] fix fugacity coeff2018-08-10T13:42:17ZBeatrix Becker[fluidsystem][brineco2] fix fugacity coeffAdd ratio of pressures to calculation of fugacity coefficients. Since, e.g., for a w-component in the liquid phase:
```math
f_l^w = f_g^w
```
```math
\varphi_l^w x_l^w p_l = \varphi_g^w x_g^w p_g
```
```math
\rightarrow \, \varphi_l^w =...Add ratio of pressures to calculation of fugacity coefficients. Since, e.g., for a w-component in the liquid phase:
```math
f_l^w = f_g^w
```
```math
\varphi_l^w x_l^w p_l = \varphi_g^w x_g^w p_g
```
```math
\rightarrow \, \varphi_l^w = \varphi_g^w \frac{x_g^w}{x_l^w}\frac{p_g}{p_l} = \frac{x_g^w}{x_l^w}\frac{p_g}{p_l}
```
This might not have a very strong effect because pressures may not deviate much. There is no test for that, though. The only test where brineco2 is used, as far as I can see, are the co2-model tests. They do not use the fugacity coefficients at all.Holger ClassHolger Classhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1174[privarswitch] Unify phase presence output to be called 'phase presence'2018-08-09T09:59:04ZTimo Kochtimokoch@math.uio.no[privarswitch] Unify phase presence output to be called 'phase presence'3.0Dennis GläserDennis Gläser