dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2019-10-23T16:16:08Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1772Feature/intersect single geometry2019-10-23T16:16:08ZTimo Kochtimokoch@math.uio.noFeature/intersect single geometry* Add intersectingEntitites overload for intersection of a single geometry with a bounding box tree of an entity set* Add intersectingEntitites overload for intersection of a single geometry with a bounding box tree of an entity set3.2Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1771[geometry] Implement intersection entity set, a set of intersections of two e...2020-04-06T08:05:52ZTimo Kochtimokoch@math.uio.no[geometry] Implement intersection entity set, a set of intersections of two entity sets* [x] Forward multidomain glue to this new and more general implementation
* [x] Add unit test for new class
* [x] Forward multidomain glue to this new and more general implementation
* [x] Add unit test for new class
3.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1769Feature/1d 1d intersection2019-10-21T12:50:59ZTimo Kochtimokoch@math.uio.noFeature/1d 1d intersection3.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1767Fix/master cmake backwards compatibility dune 2.6.02019-12-02T17:55:08ZTimo Kochtimokoch@math.uio.noFix/master cmake backwards compatibility dune 2.6.0Support Dune 2.6.0Support Dune 2.6.03.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1742[1p][tpfa] Implement analytical diff for network grids2019-10-09T16:46:50ZTimo Kochtimokoch@math.uio.no[1p][tpfa] Implement analytical diff for network grids3.1Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1741[common][geometricentityset] Add entity set for Dune geometries2019-12-20T13:05:48ZKilian Weishaupt[common][geometricentityset] Add entity set for Dune geometriesclose #737
__TODO__
- [x] template GeometryType
- [x] add testclose #737
__TODO__
- [x] template GeometryType
- [x] add test3.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1720[test][md] Add a convergence test for a coupled Stokes/Darcy problem2020-03-31T13:37:59ZKilian Weishaupt[test][md] Add a convergence test for a coupled Stokes/Darcy problemThis MR adds a coupled stokes/darcy test for which an analytical reference solution exists, taking
into account the Beavers-Joseph-Saffman slip conditon.
The test checks for convergence. Three different reference solutions can be cho...This MR adds a coupled stokes/darcy test for which an analytical reference solution exists, taking
into account the Beavers-Joseph-Saffman slip conditon.
The test checks for convergence. Three different reference solutions can be chosen on run-time.
We perform the test for the second example of Shiue et al., 2018: "Convergence of the MAC Scheme for the Stokes/Darcy Coupling Problem"
The test comes with a python script that helps to check the mathematical consistency of the reference solution.
It also provides the necessary source term. It can therefore help to add new analytical solutions. 3.2Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1719[WIP] Improve stokes darcy coupling2020-05-11T07:53:50ZKilian Weishaupt[WIP] Improve stokes darcy couplingFor testing, might not be merged.
__Problems__:
* how to make backwards-compatible?
* solution-dependent Dirichlet?
* Neumann-Neumann / Dirichlet-Dirichlet coupling does not yield the same resultsFor testing, might not be merged.
__Problems__:
* how to make backwards-compatible?
* solution-dependent Dirichlet?
* Neumann-Neumann / Dirichlet-Dirichlet coupling does not yield the same resultsKilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1718Feature/newton converged shift or reduction2019-09-19T16:19:09ZMartin SchneiderFeature/newton converged shift or reduction3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1714Fix/2p2c chem nonequil test2019-09-16T07:10:44ZKatharina HeckFix/2p2c chem nonequil test**What this MR does / why does DuMux need it**:
This fixes the new 2p2c chemical nonequilibrium tests.
Velocity output was disabled so the dimensionless numbers were always 0.
Separates velocity computation from velocity output...**What this MR does / why does DuMux need it**:
This fixes the new 2p2c chemical nonequilibrium tests.
Velocity output was disabled so the dimensionless numbers were always 0.
Separates velocity computation from velocity output. This way the grid variables do not have to concern themselves with the output which is why this bug was introduced in the first place.3.1Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1699[WIP] Feature/freeflow periodic bc2020-09-29T07:34:41ZKilian Weishaupt[WIP] Feature/freeflow periodic bccloses #756closes #7563.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1698Fix/facet gmsh reader2019-09-12T17:22:01ZDennis GläserFix/facet gmsh reader**What this MR does / why does DuMux need it**:
This makes sure that an error is thrown when a gmsh file with an unsupported format is used in a multidomain facet coupling simulation. Also, the grid file wasn't properly closed until now.**What this MR does / why does DuMux need it**:
This makes sure that an error is thrown when a gmsh file with an unsupported format is used in a multidomain facet coupling simulation. Also, the grid file wasn't properly closed until now.3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1697Feature/richards analytical jacobian2019-09-02T08:54:20ZTimo Kochtimokoch@math.uio.noFeature/richards analytical jacobian<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds analytic derivatives to the Richards local residual...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds analytic derivatives to the Richards local residual under the assumption of an incompressible fluid with constant viscosity.
**Contains the following bugfix**
The derivative dswe/dpc is corrected for the regularized van genuchten law3.1Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1694Feature/instationary assembler constructor2019-09-13T07:38:06ZDennis GläserFeature/instationary assembler constructorFixes #748
setPreviousSolution function of the assembler doesn't need to be called anymore if the new assembler constructor is used for transient problemsFixes #748
setPreviousSolution function of the assembler doesn't need to be called anymore if the new assembler constructor is used for transient problems3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1686Use entity.type() instead of creating a temporary geometry2019-08-07T11:13:35ZTimo Kochtimokoch@math.uio.noUse entity.type() instead of creating a temporary geometryConstructing a geometry may be expensive depending on the grid
implementation.Constructing a geometry may be expensive depending on the grid
implementation.3.1Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1684Improve effective laws2020-04-06T08:44:11ZKilian WeishauptImprove effective lawsFixes #711
Fixes #710
Fixes #733
The goal of this MR is to make the effective laws more general and use the same interfaces for all of them, making them easier accessible. The effective values should then be added in the volumeVar...Fixes #711
Fixes #710
Fixes #733
The goal of this MR is to make the effective laws more general and use the same interfaces for all of them, making them easier accessible. The effective values should then be added in the volumeVariables and which means that then all effective quantities could be accessed from the volumevariables (e.g. in FicksLaw take the effective diffusion coefficient directly from the volumevariables). To make this possible, a common interface in the volumevariables is necessary. To achieve this the following steps are taken in this MR:
- [x] delete the obsolete johansenindices from the thermalconductivityjohansen and get the wetting index directly from the volumevariables (minor change)
- [x] introduce effective diffusion coefficients in all compositional volume variables
- [x] MPFA also needed some fixing adressed in #733.
While introducing the above point it was obvious that currently the diffusion coefficients are treated quite heterogeneously in the volumevariables depending on the model. That is why the suggestion was to introduce a container for the diffusion coefficients so that they can be easier accessed. That means the container deals with transferring the indices for phaseIdx, compIIdx, compJIdx to the right diffusion coefficient. The goal is to use the common interface `diffusioncoefficient(int phaseIdx, int compIIdx, int compJIdx)` in the volumevariables.
Container types for the diffusion coefficients are introduced.
* [x] Depends on a fix in MPFA to handle zero coefficients.
__TODO__
- [x] Revise the maxstef container
- [x] Revise the fixs law container to include a loop for each specialization
- [x] Redo the Volvars to include the update functions and helper lambdas (1p2c, 2p2c)
- [x] Redo the Volvars to include the update functions and helper lambdas (1pnc, 2pnc, mpnc, 3p3c)
- [x] Redo the Volvars to include the update functions and helper lambdas (richardsnc, richards)
- [x] Fix the 1p tracer example which fails.
- [x] Fix the 2p tracer test.
- [x] Redo the Volvars to include the update functions and helper lambdas (3pwateroil)
- [x] Redo the Volvars to include the update functions and helper lambdas (co2)
- [x] Adapt NavierStokesNC for Ficks law.
- [x] Adapt NavierStokesNC for Max-Stef law.
- [x] Remove MPFA warnings
- [x] Adapt Compositional RANS
- [x] Fix all branch related warnings
As of Thursday 2020.01.30 all of the tests compile without branch related deprecation warnings, and pass. This leaves two tasks:
- [x] Address comments in 1543095d232f45e4e53aa48fe45d3186fc214f43
- [x] Try and the reduce property system duplication with better inheritance
- [x] Recommit/squash everything
After Dumux day on the 4th of March:
- [x] Add sentence to changelog3.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1683Automatically create READMEs for examples2019-09-19T10:11:56ZBernd FlemischAutomatically create READMEs for examples3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1680[cmake][test] Increase timeout to be able to test in debug mode2019-07-30T14:12:19ZTimo Kochtimokoch@math.uio.no[cmake][test] Increase timeout to be able to test in debug mode3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1679Feature/add hint to disable prop macro warning2019-07-31T09:32:30ZTimo Kochtimokoch@math.uio.noFeature/add hint to disable prop macro warningdepends on !1678depends on !16783.1Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1664[disc] Enable optional internal Dirichlet constraints2019-10-02T14:55:12ZTimo Kochtimokoch@math.uio.no[disc] Enable optional internal Dirichlet constraints<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Implements internal Dirichlet constraints. There is no o...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Implements internal Dirichlet constraints. There is no overhead if it's not manually enabled in the problem.
fixes #705
* [x] cell-centered
* [x] box
* [x] add a test3.1Dennis GläserDennis Gläser