dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-07-12T23:07:29Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3196[bugfix][md] Allow disabling multithreaded assembly2022-07-12T23:07:29ZTimo Kochtimokoch@math.uio.no[bugfix][md] Allow disabling multithreaded assembly3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3197pore network model: 2pnc test2024-03-27T18:35:55ZMaziar Veyskaramipore network model: 2pnc test<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Implementing a test case for 2...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Implementing a test case for 2pnc-pore network.
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
TODO: insert text here
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [ ] does the new code follow the [style guide](doc/styleguide.md)?
- [ ] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [ ] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [ ] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [ ] is the list of the header includes complete? ("include what you use")
- [ ] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
- [ ] (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
- [ ] (if not applicable remove) if the examples are modified, is the documentation regenerated (using [`generate_example_docs.py`](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/examples/generate_example_docs.py))
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->Maziar VeyskaramiMaziar Veyskaramihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3198[test][md][facet] Increase test robustness by always comparing against last t...2022-07-13T18:43:17ZTimo Kochtimokoch@math.uio.no[test][md][facet] Increase test robustness by always comparing against last time step3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3199[box] geometry(scv)/geometry(scvf) interface2022-07-14T14:50:13ZTimo Kochtimokoch@math.uio.no[box] geometry(scv)/geometry(scvf) interface<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds two new interface to the ...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds two new interface to the box fv element geometry `geometry(scv)` and `geometry(scvf)` that produce a geometry on-the-fly. This obviates the need for storing corners in the sub entities themselves.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3200Revert "Merge branch 'feature/box-without-corner-storage' into 'master'"2022-07-14T14:02:46ZDennis GläserRevert "Merge branch 'feature/box-without-corner-storage' into 'master'"!3199 was prematurely merged by accident.!3199 was prematurely merged by accident.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3201[extrusion] Add isRotationalExtrusion helper to extrusion header2022-07-14T15:10:04ZTimo Kochtimokoch@math.uio.no[extrusion] Add isRotationalExtrusion helper to extrusion headerThis is needed in other places too (soon) (see !2979)This is needed in other places too (soon) (see !2979)3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3202Feature/Prepare for box without corner storage2022-09-13T11:55:24ZTimo Kochtimokoch@math.uio.noFeature/Prepare for box without corner storage**What this MR does / why does DuMux need it**:
* Adds two new interface to the box fv element geometry `geometry(scv)` and `geometry(scvf)` that produce a geometry on-the-fly. This obviates the need for storing corners in the sub entit...**What this MR does / why does DuMux need it**:
* Adds two new interface to the box fv element geometry `geometry(scv)` and `geometry(scvf)` that produce a geometry on-the-fly. This obviates the need for storing corners in the sub entities themselves.
* Deprecates box `scv/scvf.geometry()` and `scv/scvf.corner(i)`
* Adds a deprecation helper to get rid of deprecation warnings (but deprecation warning are not all fixed in this MR)
* Extends the interface of extrusion, necessary to have a more relaxed geometry interface
Follow-up from !3199.
Addresses #1173 for box
* [x] use new center from !3230
**Notes to reviewer**:
The changes lead to quite a lot of deprecation warnings which need to be fixed before the release. But I propose to do this in another cleanup MR.
These changes will allow for a box scv/scvf implementation after the release which significantly reduces memory overhead when caching is enabled.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3203Draft: [box] Add cache to hide implementation interface from the grid geometr...2022-09-05T17:37:26ZTimo Kochtimokoch@math.uio.noDraft: [box] Add cache to hide implementation interface from the grid geometry public interfaceTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3204[diamond] Add face-centered FV discretization2022-07-25T11:19:28ZTimo Kochtimokoch@math.uio.no[diamond] Add face-centered FV discretizationAdd the diamond face-centered FV discretization based on lowest order non-conforming FV spaces (Crouzeix-Raviart, Rannacher-Turek).
Adds a 1p test solving Darcy's equation for the new scheme and support to output non-conforming functions.Add the diamond face-centered FV discretization based on lowest order non-conforming FV spaces (Crouzeix-Raviart, Rannacher-Turek).
Adds a 1p test solving Darcy's equation for the new scheme and support to output non-conforming functions.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3205[python] Update gridgeometry update interface2022-07-15T19:17:46ZTimo Kochtimokoch@math.uio.no[python] Update gridgeometry update interfaceCleanup required after #1056 is fixed now. No longer use the deprecated `gg.update()` method.Cleanup required after #1056 is fixed now. No longer use the deprecated `gg.update()` method.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3206Draft: [pm/1p] add initialfluidstate to encapsule completefluidstate function.2023-12-13T10:51:33ZYue Wangyue.wang@iws.uni-stuttgart.deDraft: [pm/1p] add initialfluidstate to encapsule completefluidstate function.<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
An `InitialFluidState` is intr...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
An `InitialFluidState` is introduced to improve the `completeFluidState`.
See also #814
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
TODO: insert text here
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [ ] does the new code follow the [style guide](doc/styleguide.md)?
- [ ] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [ ] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [ ] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [ ] is the list of the header includes complete? ("include what you use")
- [ ] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
- [ ] (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
- [ ] (if not applicable remove) if the examples are modified, is the documentation regenerated (using [`generate_example_docs.py`](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/examples/generate_example_docs.py))
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3207Draft: Feature/bin find non tested headers2023-12-13T10:52:21ZDennis GläserDraft: Feature/bin find non tested headers<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds a script to determine hea...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds a script to determine headers of a dumux project that are not included by its test suite. This could be included into the test suite to ensure that any new header is covered in the test suite.
Before you request a review from someone, make sure to revise the following points:
- [ ] does the new code follow the [style guide](doc/styleguide.md)?
- [ ] do the test pipelines pass? (TODO: introduce a fake change to check that selection still works)
- [ ] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3208[assembly] Get caching mode from cache not from property directly2022-07-18T22:27:30ZTimo Kochtimokoch@math.uio.no[assembly] Get caching mode from cache not from property directly3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3209[ci] Enable secrets security check2022-07-21T08:03:36ZTimo Kochtimokoch@math.uio.no[ci] Enable secrets security checkAdds secret detection job using template. Support in free version is not great but from the logs it's visible if some problem was detected.
This suggests to always runs the check on every commit.Adds secret detection job using template. Support in free version is not great but from the logs it's visible if some problem was detected.
This suggests to always runs the check on every commit.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3210Draft: python dune master bugfix test DO NOT MERGE2022-07-20T16:42:01ZTimo Kochtimokoch@math.uio.noDraft: python dune master bugfix test DO NOT MERGE<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
TODO: insert text here
<!--
I...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
TODO: insert text here
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
TODO: insert text here
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [ ] does the new code follow the [style guide](doc/styleguide.md)?
- [ ] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [ ] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [ ] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [ ] is the list of the header includes complete? ("include what you use")
- [ ] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
- [ ] (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
- [ ] (if not applicable remove) if the examples are modified, is the documentation regenerated (using [`generate_example_docs.py`](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/examples/generate_example_docs.py))
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3211[cmake.opts] Remove outdated property flags2022-07-21T16:09:08ZTimo Kochtimokoch@math.uio.no[cmake.opts] Remove outdated property flagsTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3212Draft: staggered par2023-12-13T10:52:22ZTimo Kochtimokoch@math.uio.noDraft: staggered parsee if there is anything from here that can be reused on mastersee if there is anything from here that can be reused on masterTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3213[richards] Do not compute endPointPc twice, reuse cached value2022-07-22T11:59:59ZTimo Kochtimokoch@math.uio.no[richards] Do not compute endPointPc twice, reuse cached value3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3214[immiscible] Fix typo in doc2022-07-22T13:01:09ZTimo Kochtimokoch@math.uio.no[immiscible] Fix typo in doc3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3215[ci] Enable codespell spell checking2022-07-28T12:31:26ZTimo Kochtimokoch@math.uio.no[ci] Enable codespell spell checkingAdds a job that checks spelling in Dumux code
* [x] Run `codespell -w` to actually implement the changes before enabling this check
* [x] Go through the automatic corrections and fix all false positives
__Notes to reviewer:__
* Change...Adds a job that checks spelling in Dumux code
* [x] Run `codespell -w` to actually implement the changes before enabling this check
* [x] Go through the automatic corrections and fix all false positives
__Notes to reviewer:__
* Changes some internal variable names `insideD` and `aws` to better names `insideDiffCoeff` `areaWS`
* Fixes one spelling mistake in an interface `DiffusionCoefficientAveragingType` in darcy-stokes `Arithmethic` -> `Arithmetic`. If someone used the wrong spelling before this will lead to an error now. There is a note about it in the changelog.
* Some spelling mistakes in tex files are fixed but tex-files are excluded in the CI because there were some false positives that are hard to fix
Closes #11743.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no