dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-07-27T20:23:42Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3221[disc] Remove old enum Discretization method that had been deprecated2022-07-27T20:23:42ZTimo Kochtimokoch@math.uio.no[disc] Remove old enum Discretization method that had been deprecatedRelated to #1163Related to #11633.6Ivan BunticIvan Buntichttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3220[pnm][util] Fix missing new line in openpnm2dgf's dgf writer2022-07-27T19:00:36ZTimo Kochtimokoch@math.uio.no[pnm][util] Fix missing new line in openpnm2dgf's dgf writerThe newline was missing so everything was written in one line which leads to a wrong dgf file.
This should be backported to 3.5 after merging.The newline was missing so everything was written in one line which leads to a wrong dgf file.
This should be backported to 3.5 after merging.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3219[pmflow][velocity][cleanup] Remove unused aliases2022-07-24T19:52:30ZTimo Kochtimokoch@math.uio.no[pmflow][velocity][cleanup] Remove unused aliases3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3218Feature/outsource assembly helper2022-07-24T18:28:50ZTimo Kochtimokoch@math.uio.noFeature/outsource assembly helper3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3217[box][cleanup] Remove unused variable2022-07-24T16:17:23ZTimo Kochtimokoch@math.uio.no[box][cleanup] Remove unused variable3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3216[cleanup][vtkoutputmodule] Do not require elementIndex interface unnecessarily2022-07-23T01:07:35ZTimo Kochtimokoch@math.uio.no[cleanup][vtkoutputmodule] Do not require elementIndex interface unnecessarily3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3215[ci] Enable codespell spell checking2022-07-28T12:31:26ZTimo Kochtimokoch@math.uio.no[ci] Enable codespell spell checkingAdds a job that checks spelling in Dumux code
* [x] Run `codespell -w` to actually implement the changes before enabling this check
* [x] Go through the automatic corrections and fix all false positives
__Notes to reviewer:__
* Change...Adds a job that checks spelling in Dumux code
* [x] Run `codespell -w` to actually implement the changes before enabling this check
* [x] Go through the automatic corrections and fix all false positives
__Notes to reviewer:__
* Changes some internal variable names `insideD` and `aws` to better names `insideDiffCoeff` `areaWS`
* Fixes one spelling mistake in an interface `DiffusionCoefficientAveragingType` in darcy-stokes `Arithmethic` -> `Arithmetic`. If someone used the wrong spelling before this will lead to an error now. There is a note about it in the changelog.
* Some spelling mistakes in tex files are fixed but tex-files are excluded in the CI because there were some false positives that are hard to fix
Closes #11743.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3214[immiscible] Fix typo in doc2022-07-22T13:01:09ZTimo Kochtimokoch@math.uio.no[immiscible] Fix typo in doc3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3213[richards] Do not compute endPointPc twice, reuse cached value2022-07-22T11:59:59ZTimo Kochtimokoch@math.uio.no[richards] Do not compute endPointPc twice, reuse cached value3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3211[cmake.opts] Remove outdated property flags2022-07-21T16:09:08ZTimo Kochtimokoch@math.uio.no[cmake.opts] Remove outdated property flagsTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3209[ci] Enable secrets security check2022-07-21T08:03:36ZTimo Kochtimokoch@math.uio.no[ci] Enable secrets security checkAdds secret detection job using template. Support in free version is not great but from the logs it's visible if some problem was detected.
This suggests to always runs the check on every commit.Adds secret detection job using template. Support in free version is not great but from the logs it's visible if some problem was detected.
This suggests to always runs the check on every commit.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3208[assembly] Get caching mode from cache not from property directly2022-07-18T22:27:30ZTimo Kochtimokoch@math.uio.no[assembly] Get caching mode from cache not from property directly3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3205[python] Update gridgeometry update interface2022-07-15T19:17:46ZTimo Kochtimokoch@math.uio.no[python] Update gridgeometry update interfaceCleanup required after #1056 is fixed now. No longer use the deprecated `gg.update()` method.Cleanup required after #1056 is fixed now. No longer use the deprecated `gg.update()` method.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3204[diamond] Add face-centered FV discretization2022-07-25T11:19:28ZTimo Kochtimokoch@math.uio.no[diamond] Add face-centered FV discretizationAdd the diamond face-centered FV discretization based on lowest order non-conforming FV spaces (Crouzeix-Raviart, Rannacher-Turek).
Adds a 1p test solving Darcy's equation for the new scheme and support to output non-conforming functions.Add the diamond face-centered FV discretization based on lowest order non-conforming FV spaces (Crouzeix-Raviart, Rannacher-Turek).
Adds a 1p test solving Darcy's equation for the new scheme and support to output non-conforming functions.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3202Feature/Prepare for box without corner storage2022-09-13T11:55:24ZTimo Kochtimokoch@math.uio.noFeature/Prepare for box without corner storage**What this MR does / why does DuMux need it**:
* Adds two new interface to the box fv element geometry `geometry(scv)` and `geometry(scvf)` that produce a geometry on-the-fly. This obviates the need for storing corners in the sub entit...**What this MR does / why does DuMux need it**:
* Adds two new interface to the box fv element geometry `geometry(scv)` and `geometry(scvf)` that produce a geometry on-the-fly. This obviates the need for storing corners in the sub entities themselves.
* Deprecates box `scv/scvf.geometry()` and `scv/scvf.corner(i)`
* Adds a deprecation helper to get rid of deprecation warnings (but deprecation warning are not all fixed in this MR)
* Extends the interface of extrusion, necessary to have a more relaxed geometry interface
Follow-up from !3199.
Addresses #1173 for box
* [x] use new center from !3230
**Notes to reviewer**:
The changes lead to quite a lot of deprecation warnings which need to be fixed before the release. But I propose to do this in another cleanup MR.
These changes will allow for a box scv/scvf implementation after the release which significantly reduces memory overhead when caching is enabled.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3201[extrusion] Add isRotationalExtrusion helper to extrusion header2022-07-14T15:10:04ZTimo Kochtimokoch@math.uio.no[extrusion] Add isRotationalExtrusion helper to extrusion headerThis is needed in other places too (soon) (see !2979)This is needed in other places too (soon) (see !2979)3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3200Revert "Merge branch 'feature/box-without-corner-storage' into 'master'"2022-07-14T14:02:46ZDennis GlĂ¤serRevert "Merge branch 'feature/box-without-corner-storage' into 'master'"!3199 was prematurely merged by accident.!3199 was prematurely merged by accident.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3199[box] geometry(scv)/geometry(scvf) interface2022-07-14T14:50:13ZTimo Kochtimokoch@math.uio.no[box] geometry(scv)/geometry(scvf) interface<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds two new interface to the ...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds two new interface to the box fv element geometry `geometry(scv)` and `geometry(scvf)` that produce a geometry on-the-fly. This obviates the need for storing corners in the sub entities themselves.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3198[test][md][facet] Increase test robustness by always comparing against last t...2022-07-13T18:43:17ZTimo Kochtimokoch@math.uio.no[test][md][facet] Increase test robustness by always comparing against last time step3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3196[bugfix][md] Allow disabling multithreaded assembly2022-07-12T23:07:29ZTimo Kochtimokoch@math.uio.no[bugfix][md] Allow disabling multithreaded assembly3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no