dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-04-01T09:59:00Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3033[fix][richards] Extended richards: Fix balancequationoptions and do porosity ...2022-04-01T09:59:00ZKatharina Heck[fix][richards] Extended richards: Fix balancequationoptions and do porosity update before evaluating effective diffusion coefficients<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
The richards model never overwrote the balancequation options...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
The richards model never overwrote the balancequation options, which is why, although diffusion was calculated (for the extendend Richards model that considers water diffusion in the gas phase), it was immediatly also substracted, leading to a net diffusive flux of 0. With the richards-specific balancequationopts it depends on the phase index if diffusion is balanced or not. Additionally, the porosity in the volumevariables was updated at the wrong place, now it is updated before the effective diffusion coefficient.
This correction also made it necessary to change the boundary condition in the richards evaporation tests. a fixed value does not work if the liquid phase actually disappears.
fixes #11343.5Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3027Doc/reduce doxyerr log2022-02-23T17:50:52ZMelanie LippDoc/reduce doxyerr log**What this MR does / why does DuMux need it**: Reduces error messages in doxyerr.log to only two lines:
```
/temp1/melaniel/dumux1/dumux/dumux/discretization/cellcentered/elementsolution.hh:144: warning: Member documentation for element...**What this MR does / why does DuMux need it**: Reduces error messages in doxyerr.log to only two lines:
```
/temp1/melaniel/dumux1/dumux/dumux/discretization/cellcentered/elementsolution.hh:144: warning: Member documentation for elementSolution found several times in @ingroup groups!
/temp1/melaniel/dumux1/dumux/dumux/discretization/staggered/elementsolution.hh:62: The member will remain in group CCDiscretization, and won't be put into group StaggeredDiscretization
```
which are lines that we already have not been able to get rid of in previous releases.3.5Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3008remove outdated dispersion parameter2022-02-02T11:55:06ZNed Coltmanremove outdated dispersion parameterfixes #1121fixes #1121Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2995[fcstaggered][fvgridgeometry] Use SingleCodimSingleGeomTypeMapper2022-01-17T11:10:29ZKilian Weishaupt[fcstaggered][fvgridgeometry] Use SingleCodimSingleGeomTypeMapper*should be faster than MultipleCodimMultipleGeomTypeMapper*should be faster than MultipleCodimMultipleGeomTypeMapperKilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2901Feature/improve staggered gridgeometry2021-11-05T17:29:35ZKilian WeishauptFeature/improve staggered gridgeometryTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2837Consistent naming in test/references2021-09-30T17:31:42ZFarid MohammadiConsistent naming in test/referencesCloses #1077Closes #10773.5Farid MohammadiFarid Mohammadihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2836[fvprob][internaldiri] fix docu2021-09-29T09:11:02ZDennis Gläser[fvprob][internaldiri] fix docuTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2793[test][freeflow] Move createAnalyticalSolution to file and reuse for several ...2021-08-27T14:36:54ZMelanie Lipp[test][freeflow] Move createAnalyticalSolution to file and reuse for several tests.So far, every Navier-Stokes test with analytical solution implements its own function to prepare and get the analytical solution for the vtk output. This MR moves this functionality to one common class to reduce code duplication.So far, every Navier-Stokes test with analytical solution implements its own function to prepare and get the analytical solution for the vtk output. This MR moves this functionality to one common class to reduce code duplication.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2792[test][freeflow] Improve error calculation.2021-09-05T12:27:17ZMelanie Lipp[test][freeflow] Improve error calculation.- Change of the calculation of the L2 error:
The calculation of the L2 error before built the four vectors staggeredVolume, errorVelocity, velocityReference and directionIndex. There where two loops: one filling those vectors, one using ...- Change of the calculation of the L2 error:
The calculation of the L2 error before built the four vectors staggeredVolume, errorVelocity, velocityReference and directionIndex. There where two loops: one filling those vectors, one using them. The reason for this approach was that for the staggeredVolume the two staggeredHalfVolumes corresponding to two different scvfs have to be added.
This MR changes the error calculation to one loop making use of the fact that both staggeredHalfVolumes are multiplied by the same factor errorVelocity[i]. So building the four vectors staggeredVolume, errorVelocity, velocityReference and directionIndex is avoided.
- Adding a calculation of an L infinity error
- Move printError out of individual test files to one common file.
- Change error output format to a CSV file
ToDos
Manually make sure L2 errors are unchanged on a sample basis:
* [x] Angeli
* [x] Channel 1d
Deal with following files:
* [x] test/freeflow/navierstokes/convergence.sh
* [x] test/freeflow/navierstokes/channel/pipe/convergencetest.py
* [x] test/freeflow/navierstokes/sincos/convergencetest.pyhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2784Feature/richards fluidsystem2021-08-24T20:56:29ZTimo Kochtimokoch@math.uio.noFeature/richards fluidsystemCloses #1002.
Allow using Richards model with the TwoPImmiscble fluid system.
Uses more general indices and asserts that the phases are as assumed before.
Theoretically not backwards compatible if someone had a custom fluid system wher...Closes #1002.
Allow using Richards model with the TwoPImmiscble fluid system.
Uses more general indices and asserts that the phases are as assumed before.
Theoretically not backwards compatible if someone had a custom fluid system where phases are exchanged. But the error message is clear due to the static assert and it should be easy to fix then.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2757Add code of conduct2021-08-24T20:57:52ZTimo Kochtimokoch@math.uio.noAdd code of conduct@all I think it would be good to adapt and official code of conduct in the DuMux community and the development of DuMux. This would be a formalization of what we already (hopefully) practiced and tried to communicate to developers.
I sug...@all I think it would be good to adapt and official code of conduct in the DuMux community and the development of DuMux. This would be a formalization of what we already (hopefully) practiced and tried to communicate to developers.
I suggest to add en established form (e.g. the [Contributor Covenant](https://www.contributor-covenant.org/ as suggested in this MR). Small modifications are of course possible (personally I don't think this is necessary).
TODOs
* [x] Contact methodBernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2736Feature/simplify local view2021-08-20T16:04:14ZNed ColtmanFeature/simplify local viewFixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] ...Fixes #1060
- [x] Make sure I'm even doing this correctly
- [x] Change bind interface for each discretization's fvelementgeometry.hh
- [x] Change bind interface for each ELemVolVars
- [x] Change bind interface for each FluxCache
- [x] Go through all dumux/ headers and replace useage
- [x] Go through all test/ headers and replace useage
- [x] Add a note to the change log
- [x] Perform Benchmark to evaluate cost localview call within or outside of a element loop
- [x] Make changes according to the Benchmark results:
> Policy here:
> 1\.) If `bind(element)` is called within an `element` loop, call `auto fvGeometry = localView(gridGeometry)` before the loop.
> 2\.) If `bind(element)` is only called once (e.g. in certain functions), use the convenience syntax.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2726Replace the IsOnWall function requirement with a boundary type2021-11-09T09:47:38ZNed ColtmanReplace the IsOnWall function requirement with a boundary typeFor wall distance calculations use the call to boundary types
- [x] Try and integrate the turbulence model specific boundary conditions into this
- [x] Make this backwards compatible somehow
- [x] Remove compiler warnings from the com...For wall distance calculations use the call to boundary types
- [x] Try and integrate the turbulence model specific boundary conditions into this
- [x] Make this backwards compatible somehow
- [x] Remove compiler warnings from the compositional rans tests (after the Backwards compatibility is approved)
resolves #947Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2724[disc] Add toString function for discretization method2021-07-22T11:00:06ZTimo Kochtimokoch@math.uio.no[disc] Add toString function for discretization methodThis came up for the Python bindings
!2681 but it also useful otherwise I think.This came up for the Python bindings
!2681 but it also useful otherwise I think.3.5Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2705[fvassembler] Set r=0 in the beginning of assembleResidual2021-07-08T09:42:02ZMelanie Lipp[fvassembler] Set r=0 in the beginning of assembleResidualWhen going into assembleResidual with r\neq 0, you get another behavior than "just write the residual into r." I think r should be set zero at the beginning of assembleResidual.When going into assembleResidual with r\neq 0, you get another behavior than "just write the residual into r." I think r should be set zero at the beginning of assembleResidual.Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2695Feature/mpfa boundary flag2021-10-12T12:25:14ZDennis GläserFeature/mpfa boundary flagTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2687WIP: Feature/metadata extraction2022-07-27T07:37:25ZTimo Kochtimokoch@math.uio.noWIP: Feature/metadata extractionFixes #885
- [x] Use concepts
- [ ] Think about metadata collection for parallel runs
- [ ] Add test cases (!3176)Fixes #885
- [x] Use concepts
- [ ] Think about metadata collection for parallel runs
- [ ] Add test cases (!3176)3.6Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2686Feature/separate vtk field type2021-06-28T21:10:00ZDennis GläserFeature/separate vtk field typeThis avoids having to know the exact output module type to use `FieldType`This avoids having to know the exact output module type to use `FieldType`Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2680[WIP][python] Add first draft of python properties generator2021-06-11T11:23:54ZKilian Weishaupt[WIP][python] Add first draft of python properties generator3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2640WIP: [assembler] Add parallel assembly with tbb and coloring2022-04-20T19:05:16ZTimo Kochtimokoch@math.uio.noWIP: [assembler] Add parallel assembly with tbb and coloring* [x] Look at other discretization schemes (or at least disable feature for non-tpfa, non-box)
* [x] Add guards in case TBB is not available.
* [ ] Guard for gridviews which are not thread-safe.
* [x] Check caching (due to coloring this ...* [x] Look at other discretization schemes (or at least disable feature for non-tpfa, non-box)
* [x] Add guards in case TBB is not available.
* [ ] Guard for gridviews which are not thread-safe.
* [x] Check caching (due to coloring this should also work with caching)
* [x] Option to set number of available threads at runtime
Check efficiency of coloring scheme (efficiency doesn't matter much for instationary simulations).
The constraint behind the coloring should be: Two elements that modify the same entries of the matrix or the cache or any other global object shouldn't have the same color. In the graph coloring sense: Two elements (two nodes) that do modify the same entries are connected by an edge.