dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2019-05-06T13:04:54Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1581WIP: Feature/ extend current timestep to the next CheckPoint if criterion is ...2019-05-06T13:04:54ZSimon EmmertWIP: Feature/ extend current timestep to the next CheckPoint if criterion is fullfilledThis reduces the testing time e.g. for the dumux-lecture test `lens2pexercise1` (efm/1p2cvs2p) from 38 sec with 283 timesteps to 21 sec with 124 timesteps.This reduces the testing time e.g. for the dumux-lecture test `lens2pexercise1` (efm/1p2cvs2p) from 38 sec with 283 timesteps to 21 sec with 124 timesteps.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1540Feature/one iteration newton2019-05-06T17:11:29ZBeatrix BeckerFeature/one iteration newtonResolves issue #659Resolves issue #659Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1584WIP: Resolve "[shallowwater] Complete the doxygen documentation"2019-05-10T09:13:44ZMartin UtzWIP: Resolve "[shallowwater] Complete the doxygen documentation"Closes #697Closes #697https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/926WIP: New style material laws2019-05-19T18:07:58ZTimo Kochtimokoch@math.uio.noWIP: New style material lawsFixes #319.Fixes #319.3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1622WIP [seq][2p2c] adjust reference solution to match docker solution2019-06-17T13:29:48ZSimon EmmertWIP [seq][2p2c] adjust reference solution to match docker solutionFixes #716
This MR provides a new reference solution that should now pass on buildbot. The test itself seems to be very sensitive and compiler-dependent. We opted for changing the reference solution instead of increasing thresholds.Fixes #716
This MR provides a new reference solution that should now pass on buildbot. The test itself seems to be very sensitive and compiler-dependent. We opted for changing the reference solution instead of increasing thresholds.3.1https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1651[test][freeflow][sincos] remove numpy from convergencetest.py2019-06-27T18:08:58ZSimon Emmert[test][freeflow][sincos] remove numpy from convergencetest.py<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This removes the numpy include in the `convergencetest.p...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This removes the numpy include in the `convergencetest.py` that caused problems on buildbot and implements its own mean function.
**Which issue this MR fixes**:
fixes #731
**Special notes for your reviewer**:
It works on my machine, but please check ;-) 3.1Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1667[io] Add logging system prototype2019-08-01T11:38:35ZTimo Kochtimokoch@math.uio.no[io] Add logging system prototypehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1648WIP: Feature/simplify effectivelaws - Do not merge!2019-08-05T18:27:27ZGabi SeitzWIP: Feature/simplify effectivelaws - Do not merge!Fixes #711
Fixes #710
Fixes #733
* [x] Depends on a fix in MPFA to handle zero coefficients.
This MR is outdated and superseded by !1684
Fixes #711
Fixes #710
Fixes #733
* [x] Depends on a fix in MPFA to handle zero coefficients.
This MR is outdated and superseded by !1684
3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1661Feature/output vtk path from inputfile2019-08-07T09:34:47ZTimo Kochtimokoch@math.uio.noFeature/output vtk path from inputfile<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This adds a path prefix to the name given to the output modu...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This adds a path prefix to the name given to the output module. This way the vtk output files can be written to a different folder.
<!--
**Which issue this MR fixes** *(optional - uncomment and add issue)*:
fixes #
-->
**Special notes for your reviewer**:
The argument `path` of the `Dune::VTKSequenceWriter` only changes the path of the vtu files, not the pvd, so it doesn't give the desired effect.3.1Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1689WIP: [examples] shallow water2019-08-13T08:42:32ZMartin UtzWIP: [examples] shallow water3.1Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1556Feature/pm ff watervelocity2019-09-02T12:54:08ZKatharina HeckFeature/pm ff watervelocity- [x] check results to see if they look physical
The following changes where made in separate commits to separate the steps more easily:
* fix the 1p_2p test, as the boundary condition was wrong
* change the momentum coupling condit...- [x] check results to see if they look physical
The following changes where made in separate commits to separate the steps more easily:
* fix the 1p_2p test, as the boundary condition was wrong
* change the momentum coupling condition for multiphase flow to also reconstruct the coupling pressure with darcys law
* include the flux of the other phase for multiphase models in the coupling conditions
The results seem more dry with the changes, which seems logical as there should be more evaporation. The fluxes become 0 when we have a phase switch in the 2p2c model, which is also correct.Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1081WIP: Feature/feature list2019-09-12T10:11:46ZTimo Kochtimokoch@math.uio.noWIP: Feature/feature listIntroduces a new folder "examples" that will host documented examples in the future. There are different from tests, which are meant only for testing and are not necessarily instructive.
Fixes #520
Fixes #378Introduces a new folder "examples" that will host documented examples in the future. There are different from tests, which are meant only for testing and are not necessarily instructive.
Fixes #520
Fixes #3783.1https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/976[freeflow][navierstokes] Improve calculation of l2error2019-10-02T13:06:59ZThomas Fetzer[freeflow][navierstokes] Improve calculation of l2errorKilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1761Install fix2019-10-18T08:02:11ZEdscott Wilson GarciaInstall fix<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**This MR fixes the "make install" instruction / DuMux needs it so user can do a standard make install withou...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**This MR fixes the "make install" instruction / DuMux needs it so user can do a standard make install without having to hack source **:
<!--
-->
**Which issue this MR fixes: Fixes install references to non existing files.
**Special notes for your reviewer**:
I think I have the merge request done correctly by updating my local fork to the current releases/3.1 branch.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1778WIP: Resolve "[tests] Newon line search not tested in test suite"2019-10-30T12:15:41ZRoman WinterWIP: Resolve "[tests] Newon line search not tested in test suite"Closes #753Closes #7533.2https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1779WIP: Resolve "[tests] Newon line search not tested in test suite"2019-10-30T12:18:39ZRoman WinterWIP: Resolve "[tests] Newon line search not tested in test suite"Closes #753Closes #7533.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1797Merge branch 'fix/error-message-gridgeometry-parallel-box' into 'master'2019-11-13T16:49:08ZBernd FlemischMerge branch 'fix/error-message-gridgeometry-parallel-box' into 'master'Fix/error message gridgeometry parallel box
Closes #786
See merge request dumux-repositories/dumux!1795
(cherry picked from commit c87e5a235385829dbed54ec25e0753035b201a8e)
d77200c6 [fix][box] Throw error if someone tries to run box ...Fix/error message gridgeometry parallel box
Closes #786
See merge request dumux-repositories/dumux!1795
(cherry picked from commit c87e5a235385829dbed54ec25e0753035b201a8e)
d77200c6 [fix][box] Throw error if someone tries to run box in parallel with overlap
4e8af5db [fix][box] Box does not support periodic boundaries in parallel
620e8f7c [io][spgrid] dune-spgrid does not support zero overlapTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1801WIP: Correctcomments1911192019-11-27T12:25:22ZKai WendelWIP: Correctcomments191119Still some small tasks to do:
* [ ] in dumux/material/fluidstates/adapter.hh: please explain "AdapterPolicy" in Line 34
* [ ] in dumux/material/spatialparams/gstatrandomfield.hh: please explain "fieldType" in Line 84Still some small tasks to do:
* [ ] in dumux/material/fluidstates/adapter.hh: please explain "AdapterPolicy" in Line 34
* [ ] in dumux/material/spatialparams/gstatrandomfield.hh: please explain "fieldType" in Line 84https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1816Feature/tabulated components with constant spacing2019-11-29T15:02:48ZBeatrix BeckerFeature/tabulated components with constant spacingTabularization now uses the same spacing across gas/liquid range (or very close) and adheres to the user-specified number of tabulated values (plus/minus 1 or 2 maybe).
Things to consider: The tabularization test failed with this. Tol...Tabularization now uses the same spacing across gas/liquid range (or very close) and adheres to the user-specified number of tabulated values (plus/minus 1 or 2 maybe).
Things to consider: The tabularization test failed with this. Tolerances were chosen very close to failing already before, though. I raised them to 1% and doubled the number of tabularized values for pressure. Now the test parses. It seems those large errors occured for the gas density, when it was in a range close to the triple point. Here, the calculation of the density changes from iapws to ideal gas law. I assume this causes large non-linearities (or better: a kink) in this region which is not very well resolved with constant spacing (sometimes only 2-3 values are tabularized for the gas density... before there were 200!).
Another thing I noticed: The tabularization test has uncommented lines, testing the pressure tabularization. I assume this is because it fails unless unreasonable high tolerances are set. This should maybe be investigated further. The pressure is calculated vie Newton in the component, maybe something is going wrong there.
I am still checking if other tests fail because of this, currently, hence WIP. Edit: no failing tests on my machine due to this change.
Resolves #755Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1841WIP: Feature/test richards istl factory2020-01-29T12:37:41ZTimo Kochtimokoch@math.uio.noWIP: Feature/test richards istl factoryDepends on !1839.
Compiles and test passes for sequential and parallel richards testsDepends on !1839.
Compiles and test passes for sequential and parallel richards tests3.2