dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-10-23T08:31:08Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2899Draft: Resolve "Shallow water turbulent diffusion wrong mobility"2021-10-23T08:31:08ZLeopold StadlerDraft: Resolve "Shallow water turbulent diffusion wrong mobility"Closes #1088Closes #1088Leopold StadlerLeopold Stadlerhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2880[disc][io] Use discretization tag instead of enum for comparisons.2021-10-19T09:26:24ZIvan Buntic[disc][io] Use discretization tag instead of enum for comparisons.Ivan BunticIvan Buntichttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2824Remove check of number of equations.2021-10-01T14:29:30ZMartin UtzRemove check of number of equations.Since the shallow water viscous momentum flux is only implemented for 2D
depth averaged models, the `ShallowwaterViscousFlux` checks if the number
of equations is equal to three. Unfortunately, this prevents the use of
the viscous flux f...Since the shallow water viscous momentum flux is only implemented for 2D
depth averaged models, the `ShallowwaterViscousFlux` checks if the number
of equations is equal to three. Unfortunately, this prevents the use of
the viscous flux for models which couple shallow water flow and sediment
transport, because these models have more equations.3.5Martin UtzMartin Utzhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2843Cleanup/ port problem kovaszny2021-09-29T13:28:50ZYue WangCleanup/ port problem kovasznyI just compile the code but still a large error there.
Maybe someone could check my code at first?I just compile the code but still a large error there.
Maybe someone could check my code at first?https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2808PengRobinson::computeMolarVolume changes2021-09-16T11:12:58ZDmitry PavlovPengRobinson::computeMolarVolume changes- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
o...- Ignoring the first two roots of the equation for Z in the
smallest one is zero or negative. There was a comment
documenting that behavior, but it was not implemented.
- Throwing NumericalProblem if no positive Z has been found
or the number of roots is 2 or more than 3
(no check was in place)
- Throwing NumericalProblem if the found molar volume turned
out to be zero, negative, or NaN. (Replacing assert)
- Added handleOneRootSpecially flag (true by default). If false,
the single-root case works as the three-roots case, without special
treatment which causes the Michelsen test for a mix of hydrocarbons
to fail to deliver.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2685Port Darcy-Stokes convergence test2021-09-09T14:21:16ZTimo Kochtimokoch@math.uio.noPort Darcy-Stokes convergence test* Port convergence test to new staggered
* Add stress tensor for analytical solutions
* add tests for dirichlet, neumann and mixed dirichlet-neumann boundaries in both domains
* test all implemented analytical solutions* Port convergence test to new staggered
* Add stress tensor for analytical solutions
* add tests for dirichlet, neumann and mixed dirichlet-neumann boundaries in both domains
* test all implemented analytical solutionsTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2810Fixed PrimaryVariablesSwitch::reset().2021-09-03T16:31:21ZDmitry PavlovFixed PrimaryVariablesSwitch::reset().resize() does not reset existing values.
There is no other place where wasSwitched_ is cleared.
So the reset() did not work at all.resize() does not reset existing values.
There is no other place where wasSwitched_ is cleared.
So the reset() did not work at all.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2809Removed PengRobinsonMixture::computeMolarVolumes. It is used nowhere2021-08-31T16:50:16ZDmitry PavlovRemoved PengRobinsonMixture::computeMolarVolumes. It is used nowhere(Also it will not translate because PengRobinson::computeMolarVolumes
does not exist).(Also it will not translate because PengRobinson::computeMolarVolumes
does not exist).Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2794Draft: Resolve "Discretization method as tag instead of enum"2021-08-25T12:49:26ZIvan BunticDraft: Resolve "Discretization method as tag instead of enum"Closes #1054Closes #10543.5Ivan BunticIvan Buntichttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2791WIP: Analytical solution in freeflow2021-08-25T12:01:08ZMelanie LippWIP: Analytical solution in freeflowThe idea is to avoid createanalyticalsolution, printerror in every file.The idea is to avoid createanalyticalsolution, printerror in every file.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2769WIP: [test] Add unit test for parameters2021-08-25T11:30:37ZTimo Kochtimokoch@math.uio.noWIP: [test] Add unit test for parameterssee #1069see #1069https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2630WIP: Fix/sequential buckleylev mcworther analytical sol2021-08-16T15:07:18ZTimo Kochtimokoch@math.uio.noWIP: Fix/sequential buckleylev mcworther analytical solReopening of !2608 which has been reverted in !2627 due to bug #1034. Should be revisited preferably in the light of #869 and !2629 !2628Reopening of !2608 which has been reverted in !2627 due to bug #1034. Should be revisited preferably in the light of #869 and !2629 !2628https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2612Draft: Resolve "Segfault in McWorther test"2021-08-16T12:19:02ZHanchuan WuDraft: Resolve "Segfault in McWorther test"Closes #1034Closes #10343.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2765Temp/ci lecture trigger test2021-08-10T15:36:48ZDennis GläserTemp/ci lecture trigger testhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2764[test][2ptracer] remove UMFPack cmake guard2021-08-05T13:22:58ZDennis Gläser[test][2ptracer] remove UMFPack cmake guardhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2756Fix missing header2021-08-02T17:41:30ZHanchuan WuFix missing header3.4Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2733Draft: Resolve "extrusionFactor should be a spatial parameter interface"2021-07-28T10:17:47ZFelix WeinhardtDraft: Resolve "extrusionFactor should be a spatial parameter interface"Closes #1001Closes #10013.5Felix WeinhardtFelix Weinhardthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2654WIP: refactor-make-install-script2021-07-26T18:41:30ZDennis GläserWIP: refactor-make-install-scriptThe install-script functionality (or similar) is now in bin/extractmodule/util.py
Closes #1021
Closes #1037The install-script functionality (or similar) is now in bin/extractmodule/util.py
Closes #1021
Closes #10373.4Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2600Fix/tabulated2dfunction2021-06-28T11:57:12ZDmitry PavlovFix/tabulated2dfunctionThere are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That ...There are two issues. First, we have m * n points, so (m-1) * (n - 1) intervals. The existing `iToX` and `jToY` functions are written in accordance. However, `xToI` and `jToY` do not match. They assume that there are m*n intervals. That needs to be fixed.
The second issue is the following code in get():
```c++
int i = max(0, min(m_, static_cast<int>(alpha)));
int j = max(0, min(n_, static_cast<int>(beta)));
```
With `x == xMax`, alpha will be as big as (`m_- 1`) even after the proposed fix to `xToI`. But we need an interval number here, not a point number, and there is no (`m_- 1`)-th interval (not to mention `_m`-th). So we need to cut `i` at (`m_ - 2`). Similarly with `j`.
Without the fix, the assertions in `getSamplePoint`
```c++
assert(0 <= i && i < m_);
assert(0 <= j && j < n_);
```
rightfully fail when `x` is close to `xMax` or `y` is close to `yMax`.
TODO:
* [ ] Check which tests are affected3.5Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2680[WIP][python] Add first draft of python properties generator2021-06-11T11:23:54ZKilian Weishaupt[WIP][python] Add first draft of python properties generator3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no