dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-08-13T18:33:47Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3249Draft: Implementation of navier-stokes cvfe model2022-08-13T18:33:47ZMartin SchneiderDraft: Implementation of navier-stokes cvfe modelImplements a cvfe discretization for Navier-StokesImplements a cvfe discretization for Navier-StokesMartin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3255[ff][cvfe] Implement velocity output for cvfe scheme2022-08-13T18:33:21ZTimo Kochtimokoch@math.uio.no[ff][cvfe] Implement velocity output for cvfe scheme3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3247Draft: Control-volume finite-element discretization2022-08-12T22:54:52ZMartin SchneiderDraft: Control-volume finite-element discretization**What this MR does / why does DuMux need it**:
* Implements a new discretization scheme (box + cell unknown)
* Implements a 1p porous medium test
* Tests the discretization
** ToDo
- [ ] Cleanup geometryhelper, maybe use tuple
- [ ] I...**What this MR does / why does DuMux need it**:
* Implements a new discretization scheme (box + cell unknown)
* Implements a 1p porous medium test
* Tests the discretization
** ToDo
- [ ] Cleanup geometryhelper, maybe use tuple
- [ ] Implement MultithreadedAssembly
- [ ] Implement ParallelizationMartin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1244WIP: Timo's implementation of a Navier-Stokes Schur complement solver ported ...2022-07-26T13:37:24ZMelanie LippWIP: Timo's implementation of a Navier-Stokes Schur complement solver ported to 3.0.To Dos:
* [ ] Implement that neither Dirichlet boundary values nor fixed pressure values (cf. `setFixedCell` in dumux/freeflow/navierstokes/staggered/localresidual.hh) are degrees of freedom. Make sure that whenever those non-dof Dirich...To Dos:
* [ ] Implement that neither Dirichlet boundary values nor fixed pressure values (cf. `setFixedCell` in dumux/freeflow/navierstokes/staggered/localresidual.hh) are degrees of freedom. Make sure that whenever those non-dof Dirichlet values are part of the stencil they are considered in a source-term manner.
* [ ] Give linear operators to SchurComplementPreconditioner, SchurApproximate and SchurComplement instead of matrices.
* [ ] Find a better name for InnerSolverTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3210Draft: python dune master bugfix test DO NOT MERGE2022-07-20T16:42:01ZTimo Kochtimokoch@math.uio.noDraft: python dune master bugfix test DO NOT MERGE<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
TODO: insert text here
<!--
I...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
TODO: insert text here
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
TODO: insert text here
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [ ] does the new code follow the [style guide](doc/styleguide.md)?
- [ ] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [ ] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [ ] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [ ] is the list of the header includes complete? ("include what you use")
- [ ] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
- [ ] (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
- [ ] (if not applicable remove) if the examples are modified, is the documentation regenerated (using [`generate_example_docs.py`](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/examples/generate_example_docs.py))
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2632WIP: Diamon schemes2022-06-02T08:15:05ZMartin SchneiderWIP: Diamon schemesToDos:
- [ ] Unify interfaces of staggered and diamond in common base classes, i.e. prevent code duplication
- [ ] Fix problem with internal Dirichlet constraints when using Box method for mass balance (!2637)
- [ ] Diamond + Box method...ToDos:
- [ ] Unify interfaces of staggered and diamond in common base classes, i.e. prevent code duplication
- [ ] Fix problem with internal Dirichlet constraints when using Box method for mass balance (!2637)
- [ ] Diamond + Box method for nc and ni
- [ ] Adapt vtk output for Diamond schemes, e.g. velocity output for unstructured grids
- [ ] Tpfa scheme for mass balances
- [ ] Reduce Box - Diamond coupling stencils
- [ ] Add diamond testshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3130[fix] use referece instead of copy in loop2022-05-25T18:23:22ZYue Wangyue.wang@iws.uni-stuttgart.de[fix] use referece instead of copy in loop3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3123Draft: fix test freeflow-pornetwork2022-05-25T13:27:55ZMaziar VeyskaramiDraft: fix test freeflow-pornetworkhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3108Merge branch 'fix/fmt-for-use-with-opm' into 'master'2022-05-11T07:18:18ZYue Wangyue.wang@iws.uni-stuttgart.deMerge branch 'fix/fmt-for-use-with-opm' into 'master'Move fmt to Dumux namespace
Closes #1150
See merge request dumux-repositories/dumux!3099
(cherry picked from commit ffa6d36ff84da95458da34c02ea2a4c796448f15)
dc5d7d03 [fmt] move implementation to namespace Dumux
27942de6 [test] Use F...Move fmt to Dumux namespace
Closes #1150
See merge request dumux-repositories/dumux!3099
(cherry picked from commit ffa6d36ff84da95458da34c02ea2a4c796448f15)
dc5d7d03 [fmt] move implementation to namespace Dumux
27942de6 [test] Use Fmt in cornerpoint test3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2980[freeflow] diamond scheme tests2022-05-10T12:16:13ZMartin Schneider[freeflow] diamond scheme testsTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3065[cmake]update cmakelists2022-04-26T12:03:29ZYue Wangyue.wang@iws.uni-stuttgart.de[cmake]update cmakelists3.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3047Draft: Feature/improve poroelastic doc2022-04-26T10:11:54ZDennis GläserDraft: Feature/improve poroelastic docDepends on !3046Depends on !30463.5Yue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3053Feature/use inialize in tests2022-04-22T17:08:39ZTimo Kochtimokoch@math.uio.noFeature/use inialize in tests3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2640WIP: [assembler] Add parallel assembly with tbb and coloring2022-04-20T19:05:16ZTimo Kochtimokoch@math.uio.noWIP: [assembler] Add parallel assembly with tbb and coloring* [x] Look at other discretization schemes (or at least disable feature for non-tpfa, non-box)
* [x] Add guards in case TBB is not available.
* [ ] Guard for gridviews which are not thread-safe.
* [x] Check caching (due to coloring this ...* [x] Look at other discretization schemes (or at least disable feature for non-tpfa, non-box)
* [x] Add guards in case TBB is not available.
* [ ] Guard for gridviews which are not thread-safe.
* [x] Check caching (due to coloring this should also work with caching)
* [x] Option to set number of available threads at runtime
Check efficiency of coloring scheme (efficiency doesn't matter much for instationary simulations).
The constraint behind the coloring should be: Two elements that modify the same entries of the matrix or the cache or any other global object shouldn't have the same color. In the graph coloring sense: Two elements (two nodes) that do modify the same entries are connected by an edge.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3045Draft: feature/improve-geomechanics-documentation2022-04-13T14:29:36ZDennis GläserDraft: feature/improve-geomechanics-documentationYue Wangyue.wang@iws.uni-stuttgart.deYue Wangyue.wang@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3036Improve documentation for 2p flow tests2022-03-30T15:07:49ZStefanie KiemleImprove documentation for 2p flow testshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1975WIP: [io][gridmanagerbase] Fix dune deprecation warning2022-03-28T09:36:01ZKilian WeishauptWIP: [io][gridmanagerbase] Fix dune deprecation warningfixes #859
Should probably be backported to 3.2fixes #859
Should probably be backported to 3.23.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2561WIP: analytical case for K-Omega2022-03-07T12:27:35ZNed ColtmanWIP: analytical case for K-Omega**What this MR does / why does DuMux need it**:
- Implements an analytical case for two-eq turbulence models from pre dumux 3.0
**Special notes for your reviewer**:
- Currently no convergence, for future comparison with new staggered im...**What this MR does / why does DuMux need it**:
- Implements an analytical case for two-eq turbulence models from pre dumux 3.0
**Special notes for your reviewer**:
- Currently no convergence, for future comparison with new staggered implementations3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3011Surfactant test2022-02-23T22:19:46ZDmitry PavlovSurfactant testTest of surfactant injection in porous medium (2p2c). Surfactant model is loosely based on the one described [here](https://www.sintef.no/contentassets/0d97862cef164d1c965d268ce5e4e082/surfactant_model.pdf). (Also see [here](https://ntnu...Test of surfactant injection in porous medium (2p2c). Surfactant model is loosely based on the one described [here](https://www.sintef.no/contentassets/0d97862cef164d1c965d268ce5e4e082/surfactant_model.pdf). (Also see [here](https://ntnuopen.ntnu.no/ntnu-xmlui/handle/11250/240038) for a longer version). This test will not work without [MR 2914](!2914).3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2146WIP: [box] Update all element volume variables when deflecting solution2022-02-23T17:26:19ZTimo Kochtimokoch@math.uio.noWIP: [box] Update all element volume variables when deflecting solutionFixes #892Fixes #892