dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2020-07-22T08:50:59Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2216[math] Add linear table interpolation with two arguments2020-07-22T08:50:59ZTimo Kochtimokoch@math.uio.no[math] Add linear table interpolation with two argumentsAllow also interface version with two arguments range/values.Allow also interface version with two arguments range/values.3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2208Feature/pore network model2021-02-25T15:34:18ZKilian WeishauptFeature/pore network modelThis MR implements pore-network models in Dumux.
__TODO__
- [x] remove deprecated warnings
- [x] discuss folder structure
- [x] discuss caching and transmissibility laws
- [x] discuss grid data
- [x] discuss tests
- [x] check docu
- [x...This MR implements pore-network models in Dumux.
__TODO__
- [x] remove deprecated warnings
- [x] discuss folder structure
- [x] discuss caching and transmissibility laws
- [x] discuss grid data
- [x] discuss tests
- [x] check docu
- [x] clean up
- [x] use script in `bin/util/create_cmakelists.py` to create CMakeLists.txt files
- [x] change license headers to GPL v3
- [x] put flux-related header into `dumux/flux`
- [x] revise and check ps-Sw curve
- [x] discuss and find a solution for the 2p and 2pni tests, which are very sensitive to the chosen regularization method and the parameter Swmax.
- [x] Add description in changelog (+ backwards-compatibility policy)3.4Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2202Feature/cc internaldirichlet2020-06-30T19:37:30ZKilian WeishauptFeature/cc internaldirichletcloses #772closes #7723.3Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2187Feature/newton relative shift2020-06-25T08:44:16ZTimo Kochtimokoch@math.uio.noFeature/newton relative shift3.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2143Cleanup/use mathjax2020-05-27T14:31:26ZSimon EmmertCleanup/use mathjax
**What this MR does / why does DuMux need it**:
Use MathJax to render equations for doxygen. I also replaced `\textup` with `\text` for now
I do not see a problem with `\textbf` and `\bf` as they are listed as supported by mathjax ...
**What this MR does / why does DuMux need it**:
Use MathJax to render equations for doxygen. I also replaced `\textup` with `\text` for now
I do not see a problem with `\textbf` and `\bf` as they are listed as supported by mathjax (http://docs.mathjax.org/en/latest/input/tex/macros/index.html)
But mabye this is also related to browser versions.
Runtime reduces to 1m45.409s on my machine (without tests already), compared to 3m58.628s (without tests but with images) or 8m29.095s (with all tests and images)
The only downside I see when using MathJax is that MathJax actually takes some time to render once I click on a page.
Edit:
The goal was to make formulas look nicer in doxygen.
* [x] Add doc/doxygen/Doxylocal `+USE_MATHJAX = YES`
* [x] Get rid of `\textup`, and `\mbox{\bf}` as they are not properly parsed by mathjax
* [x] Further commands that are not parsed properly were not found
`\textbf` stays for now.
**Which issue this MR fixes**:
fixes #882
**Special notes for your reviewer**:
Needs to be merged after !2141https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2141[doxygen] exclude tests from doxygen to reduce doxygen size and runtime2020-05-27T11:13:44ZSimon Emmert[doxygen] exclude tests from doxygen to reduce doxygen size and runtime**What this MR does / why does DuMux need it**:
Excludes tests from doxygen to reduce doxygen size and compile time.
**Before:**
Size: 302M
Time: 8m29.095s
**After:**
Size: 181M
Time: 3m58.628s
**Which issue this MR fixes**...**What this MR does / why does DuMux need it**:
Excludes tests from doxygen to reduce doxygen size and compile time.
**Before:**
Size: 302M
Time: 8m29.095s
**After:**
Size: 181M
Time: 3m58.628s
**Which issue this MR fixes**:
fixes #887Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2139[rans] add density in all terms of the RANS models2020-10-30T18:27:17ZKatharina Heck[rans] add density in all terms of the RANS modelsThis is to include variable density in the the 1-2eq turbulence models.
___
Explanation, using the K-omega model as an example:
Previously implemented (K):
```math
\frac{\partial \left( k \right)}{\partial t}
+ \nabla \cdot \left( \ma...This is to include variable density in the the 1-2eq turbulence models.
___
Explanation, using the K-omega model as an example:
Previously implemented (K):
```math
\frac{\partial \left( k \right)}{\partial t}
+ \nabla \cdot \left( \mathbf{v} k \right)
- \nabla \cdot \left[ \left( \nu + \sigma_\textrm{k} \frac{k}{\omega}\right) \nabla k \right]
- (2 \nu_t \mathbf{S} \cdot \mathbf{S})
+ \beta_k k \omega = 0
```
Introduced in this MR (K):
```math
\frac{\partial \left( \rho k \right)}{\partial t}
+ \nabla \cdot \left( \rho k \mathbf{v} \right)
- \nabla \cdot \left[ \left( \mu + \rho \sigma_\textrm{k} \frac{k}{\omega}\right) \nabla k \right]
- (2 \mu_t \mathbf{S} \cdot \mathbf{S})
+ \rho \beta_k k \omega = 0
```
Previously implemented ($`\omega`$):
```math
\frac{\partial \left( \omega \right)}{\partial t}
+\nabla \cdot \left( \mathbf{v} \omega \right)
-\nabla \cdot \left[ \left( \nu + \sigma_{\omega} \frac{k}{\omega}\right) \nabla \omega \right]
-\alpha \frac{\omega}{k} (2 \nu_t \mathbf{S} \cdot \mathbf{S})
+\beta_{\omega} \omega^2
-\frac{\sigma_d}{\omega} \nabla k \nabla \omega = 0
```
Introduced in this MR ($`\omega`$):
```math
\frac{\partial \left( \rho \omega \right)}{\partial t}
+\nabla \cdot \left( \rho \mathbf{v} \omega \right)
-\nabla \cdot \left[ \left( \mu + \rho \sigma_{\omega} \frac{k}{\omega}\right) \nabla \omega \right]
-\alpha \frac{\omega}{k} (2 \mu_t \mathbf{S} \cdot \mathbf{S})
+\rho \beta_{\omega} \omega^2
-\rho \frac{\sigma_d}{\omega} \nabla k \nabla \omega = 0
```
___
- [x] add density in production limiter term
The production limiter is also modified from:
```math
20 \beta_K k \omega \text{ to } 20 \rho \beta_K k \omega
```
___
- [x] test how much that changes results
* This shouldn't effect any of the isothermal single component tests. All ni or nc tests should be affected.
* All of the ni and nc tests are effected.
- [x] Update reference solutions.
___
Introduce this additionally for the:
* [x] kepsilon
* [x] low re kepsilon
* [x] one eq models
___
Fix failing kepsilon wall function test
* [x] fix kepsilon wall functions
relevant documentation:
https://www.afs.enea.it/project/neptunius/docs/fluent/html/th/node99.htm#eq6.3.8bc
___
- [x] Check, if it is necessary to implement the additional term (MOVED TO #951)
```math
- 2/3 \rho k \delta_{ij}
```
in the production term in the 2-eq models (see: Computational Fluid Dynamics, Versteeg& Malalasekera page 90)
``` math
\tau_{ij} = 2 \, \mu_t \, S_{ij} - \frac{2}{3}\rho k \delta_{ij}
```3.3Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2136[cmake] Require CMake 3.132020-06-02T07:58:17ZChristoph Grüninger[cmake] Require CMake 3.13Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2133Fix/staggered upwindfluxvars2020-05-19T10:07:36ZKilian WeishauptFix/staggered upwindfluxvars3.3Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2128Feature/navier stokes darcy convtest2020-05-27T06:39:21ZKilian WeishauptFeature/navier stokes darcy convtest3.3Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2127cleanup/staggeredupwindfluxvars ifconstexpr2020-05-19T08:57:25ZNed Coltmancleanup/staggeredupwindfluxvars ifconstexprWhile looking through the freeflow implementation again I noticed that the private functions in the `staggeredupwindfluxvariables.hh` header could be reduced using c++17 features.
This would reduce the code a good amount, and hopefully ...While looking through the freeflow implementation again I noticed that the private functions in the `staggeredupwindfluxvariables.hh` header could be reduced using c++17 features.
This would reduce the code a good amount, and hopefully make it easier to read through.
The commits are hopefully split up so that the review isn't too difficult. They can be squashed if need be. This is very low priority; it's just clean up.Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2119Cleanup rans tests with c++172020-05-08T05:37:55ZNed ColtmanCleanup rans tests with c++17This replaces the `enable_if` and `index_constant` logic used previously in the rans and ransnc tests with `if constexpr`.
This should be much shorter and slightly easier to read, thanks to use of c++17.
This is not high priority as...This replaces the `enable_if` and `index_constant` logic used previously in the rans and ransnc tests with `if constexpr`.
This should be much shorter and slightly easier to read, thanks to use of c++17.
This is not high priority as it is only clean up.
This could also be squashed if necessary, I separated the steps for easier reviewing. 3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2023[examples] Add images for examples on main example page2020-04-22T15:59:10ZTimo Kochtimokoch@math.uio.no[examples] Add images for examples on main example pageDennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1992[fluidmatrixinteraction] Use std::clamp for improved readability2020-04-18T14:09:30ZTimo Kochtimokoch@math.uio.no[fluidmatrixinteraction] Use std::clamp for improved readability3.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1991Feature/2d segment segment intersections2020-05-08T13:36:08ZDennis GläserFeature/2d segment segment intersectionsThis MR adds the intersection algorithm for segment-like intersections of two segments in 2d space.This MR adds the intersection algorithm for segment-like intersections of two segments in 2d space.3.3Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1977Feature/cleanup fvproblem dependencies2020-04-14T16:21:11ZTimo Kochtimokoch@math.uio.noFeature/cleanup fvproblem dependencies3.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1968Feature/remove deprecated2020-04-14T12:09:37ZTimo Kochtimokoch@math.uio.noFeature/remove deprecated3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1945Fix/headercheck2020-04-05T11:39:32ZDennis GläserFix/headercheck3.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1936Support newest version of opm-grid for cornerpoint grids2020-04-02T09:07:45ZMartin SchneiderSupport newest version of opm-grid for cornerpoint grids3.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1931[linearsolver] Only construct parallel helper if MPI was found2020-03-31T14:01:29ZTimo Kochtimokoch@math.uio.no[linearsolver] Only construct parallel helper if MPI was foundBug reported by @hanchuan who also tested this bugfix.Bug reported by @hanchuan who also tested this bugfix.3.2Kilian WeishauptKilian Weishaupt