dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-05-13T11:40:08Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3115Merge branch 'feature/remove-warnings-deprecations' into 'master'2022-05-13T11:40:08ZTimo Kochtimokoch@math.uio.noMerge branch 'feature/remove-warnings-deprecations' into 'master'Fix some compiler warnings
See merge request dumux-repositories/dumux!3103
(cherry picked from commit 26409a96770ed63cf1bd55dc1faea936d06609c9)
688fc288 [fix] use math.hh instead of power.hh
f51406bd [fix]remove warning in constructor...Fix some compiler warnings
See merge request dumux-repositories/dumux!3103
(cherry picked from commit 26409a96770ed63cf1bd55dc1faea936d06609c9)
688fc288 [fix] use math.hh instead of power.hh
f51406bd [fix]remove warning in constructor
017e443b [el2p] reuse CO2 table3.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3067Feature/parameterlist2022-05-15T13:33:28ZYue WangFeature/parameterlistFixes #1101Fixes #11013.5Yue WangYue Wanghttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3100[benchmark][richards] Add benchmark case on annulus with analytic solution2022-05-10T16:41:50ZTimo Kochtimokoch@math.uio.no[benchmark][richards] Add benchmark case on annulus with analytic solutionConvergence rates are fine (except for sand where the analytic solution is basically a sharp corner).
Onset match with the solutions presented in the paper https://doi.org/10.3389/fpls.2020.00316 after fixing the domain size as reported ...Convergence rates are fine (except for sand where the analytic solution is basically a sharp corner).
Onset match with the solutions presented in the paper https://doi.org/10.3389/fpls.2020.00316 after fixing the domain size as reported here: https://github.com/RSA-benchmarks/collaborative-comparison/blob/master/C1%20Coupled%20problem%2C%20static%20RSA/C1.1%20Single%20root/C1.1%20Benchmark%20problem.ipynb.
There is a readme describing the cases a bit.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2913Draft: Feature/geometry tolerance2022-02-23T08:55:17ZDennis GläserDraft: Feature/geometry toleranceIntroduces a central place for geometry tolerance definitions.Introduces a central place for geometry tolerance definitions.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2687WIP: Feature/metadata extraction2022-04-01T13:18:54ZTimo Kochtimokoch@math.uio.noWIP: Feature/metadata extractionFixes #885
- [ ] Use concepts
- [ ] Think about metadata collection for parallel runsFixes #885
- [ ] Use concepts
- [ ] Think about metadata collection for parallel runs3.6https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2565Draft: [examples] Feature/pnm non creeping upscaling2022-03-30T08:46:00ZMaziar VeyskaramiDraft: [examples] Feature/pnm non creeping upscalingUpscaling non-creeping flow (#997)Upscaling non-creeping flow (#997)3.6Maziar VeyskaramiMaziar Veyskaramihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2142WIP: Feature/freeflow outflow as neumann2022-03-28T09:32:23ZMartin SchneiderWIP: Feature/freeflow outflow as neumannInstead of outflow conditions we want to use Neumann conditions with convenience outflow functions provided in some fluxhelper class.
ToDos
- [x] Check turbulence models
- [ ] Check coupled models
- [ ] Deprecate outflow conditions
- [ ...Instead of outflow conditions we want to use Neumann conditions with convenience outflow functions provided in some fluxhelper class.
ToDos
- [x] Check turbulence models
- [ ] Check coupled models
- [ ] Deprecate outflow conditions
- [ ] Fix failing tests
- [ ] Documentation of helper classes3.6Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2113WIP: Feature/new istl linear solvers2022-03-28T09:30:14ZTimo Kochtimokoch@math.uio.noWIP: Feature/new istl linear solvers* [x] Revisit template arguments
* [x] Introduce linear algebra backend or similar to make usage simpler
* [x] Adapt all linear solvers to provide `norm`
* [x] In Newton call `linearSolver->norm(r)` if available otherwise call `assembler...* [x] Revisit template arguments
* [x] Introduce linear algebra backend or similar to make usage simpler
* [x] Adapt all linear solvers to provide `norm`
* [x] In Newton call `linearSolver->norm(r)` if available otherwise call `assembler->residualNorm();` (depends on !2311 to be merged)
* [x] Deprecate conversion of multitype matrices in Newton (do in solver instead if necessary)
Depends on !2310 to be merged.
The matrix and vector type now have to be known to construct the solver.
This was previously delayed until the solve call but made the structure kind of intransparent because it wasn't really clear which vector type has to come in but only specific types work anyway.
Hard coding the solver hopefully reduces compile times wrt the factory. Also the implementation should be
* more compact than the old backends
* have more runtime option due to parameter tree-based params
* work in parallel as well
If this works out, we would deprecated the old solver backends.3.6Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3081Draft: Fix/parallel adaptive2022-05-02T19:27:25ZTimo Kochtimokoch@math.uio.noDraft: Fix/parallel adaptiveRelated to #264Related to #2643.6https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3009Draft: Fix pc-snap-off in pore network to use the proper corner half angle2022-03-31T08:35:38ZMaziar VeyskaramiDraft: Fix pc-snap-off in pore network to use the proper corner half angleTo calculate the pc-snap-off, corner half angle of the throat is needed. It was so far just based on square cross section.To calculate the pc-snap-off, corner half angle of the throat is needed. It was so far just based on square cross section.3.6Maziar VeyskaramiMaziar Veyskaramihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2986WIP: Port compositional freeflow model and tests to new staggered2022-05-11T08:51:47ZNed ColtmanWIP: Port compositional freeflow model and tests to new staggeredpassing tests:
- [x] maxwellstefan (changed base epsilon)
- [ ] Add back the maxstefan gnuplot output
- [x] channelnc mole diffusion
- [x] channelnc mass diffusion
- [ ] channelnc advection
- [ ] channelnc advection nocaching
- [ ] chann...passing tests:
- [x] maxwellstefan (changed base epsilon)
- [ ] Add back the maxstefan gnuplot output
- [x] channelnc mole diffusion
- [x] channelnc mass diffusion
- [ ] channelnc advection
- [ ] channelnc advection nocaching
- [ ] channelncni advection
- [ ] channelncni diffusion
- [ ] density driven flow3.6Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2930WIP: New Staggered Rans (TwoEq)2022-03-28T09:06:24ZNed ColtmanWIP: New Staggered Rans (TwoEq)fixes #807
fixes #538
fixes #951
closes !1248 (becomes obsolete)
Todos (Updated):
- [ ] For the SST Model, update the Finner, Fouter interface and remove from volvars.
- [ ] Introduce more meaningful boundary conditions, includin...fixes #807
fixes #538
fixes #951
closes !1248 (becomes obsolete)
Todos (Updated):
- [ ] For the SST Model, update the Finner, Fouter interface and remove from volvars.
- [ ] Introduce more meaningful boundary conditions, including tke and dissipation constraints
- [ ] Update spatial params to fit to !2888 with !2984
- [ ] Make runtime call an enum
- [ ] Figure out any circular dependencies between the two problems
Next MRs:
- [ ] Introduce the Kepsilon model(s) again
- [ ] Introduce the Compositional models (Separate MR)
- [ ] Introduce the Zeroeq and oneeq models (Separate MR)3.6Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2926[WIP] [staggered] Higher Order V22022-03-30T08:19:13ZKilian Weishaupt[WIP] [staggered] Higher Order V2* Use local index mapping to find relevant scvs
__TODO__
- [ ] boundary handling: Dirichlet, slip velocity -> do we need higher order at boundaries?
- [ ] implement for lateral fluxes
- [ ] Add the kovasnay tests and review tests* Use local index mapping to find relevant scvs
__TODO__
- [ ] boundary handling: Dirichlet, slip velocity -> do we need higher order at boundaries?
- [ ] implement for lateral fluxes
- [ ] Add the kovasnay tests and review tests3.6https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1950WIP: Block-diagonal AMG in parallel2022-03-28T09:30:09ZBernd FlemischWIP: Block-diagonal AMG in parallelMake the `BlockDiagAMGBiCGSTABSolver` work in parallel.
On the user side, this requires passing argument and template tuples. For the currently working test in `multidomain/poroelastic/el1p`, this amounts to
```cpp
using GridGeometr...Make the `BlockDiagAMGBiCGSTABSolver` work in parallel.
On the user side, this requires passing argument and template tuples. For the currently working test in `multidomain/poroelastic/el1p`, this amounts to
```cpp
using GridGeometries = std::tuple<OnePFVGridGeometry, PoroMechFVGridGeometry>;
using LinearSolver = BlockDiagAMGBiCGSTABSolver<GridGeometries>;
auto views = std::make_tuple(std::cref(leafGridView), std::cref(leafGridView));
auto mappers = std::make_tuple(onePFvGridGeometry->dofMapper(), poroMechFvGridGeometry->dofMapper());
auto groups = std::make_tuple(std::string("OneP"), std::string("PoroElastic"));
auto linearSolver = std::make_shared<LinearSolver>(views, mappers, groups);
```
So far, only `YaspGrid` works.
1. [x] Make it work for [dumux-sediment](https://git.iws.uni-stuttgart.de/dumux-appl/dumux-sediment).
2. [x] Make it work for `UGGrid` and `ALUGrid`.
3. [x] Decide where to put what.3.6Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3051Draft: Feature/grid geometry observer2022-04-20T18:43:11ZDennis GläserDraft: Feature/grid geometry observerAllows observing grid geometries such that the observers can be notified in case the grid changesAllows observing grid geometries such that the observers can be notified in case the grid changesTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2628WIP [IMPES][test] Use analytical derivatives2021-05-20T17:47:37ZTimo Kochtimokoch@math.uio.noWIP [IMPES][test] Use analytical derivativesThis test results now in the same solution than the
old IMPES implementation, at least when gravity is neglected.
Related to #869This test results now in the same solution than the
old IMPES implementation, at least when gravity is neglected.
Related to #869https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2563[components] Add component SimplerH2O2021-04-20T14:56:33ZTimo Kochtimokoch@math.uio.no[components] Add component SimplerH2OFixes #1013
I hope this is consistent. Water vapor is modeled as an ideal gas. inner energy and vapor pressure are linearized around the reference state. The evaporation enthalpy should be automatically included now.
I added a new com...Fixes #1013
I hope this is consistent. Water vapor is modeled as an ideal gas. inner energy and vapor pressure are linearized around the reference state. The evaporation enthalpy should be automatically included now.
I added a new component as this implementation will probably yield different results than SimpleH2O.Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2496WIP: [linear] matrix converter with reordering2022-03-28T09:39:27ZTimo Kochtimokoch@math.uio.noWIP: [linear] matrix converter with reorderingWould be probably easier if the matrix converter would have a state.Would be probably easier if the matrix converter would have a state.Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2294WIP: Add Trilinos solvers2022-01-19T11:22:38ZBernd FlemischWIP: Add Trilinos solversAdd an optional dependency to Trilinos, https://github.com/trilinos/trilinos. Implement a linear solver backend that uses a solver from there.Add an optional dependency to Trilinos, https://github.com/trilinos/trilinos. Implement a linear solver backend that uses a solver from there.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2276WIP: [test][1p] Add 3d convergence test2020-10-07T09:26:12ZTimo Kochtimokoch@math.uio.noWIP: [test][1p] Add 3d convergence testAdds a 2d test on a sphere tet grid (`sphere.msh`). I also committed a `sphere_quad.msh` grid which has some nasty distorted quad elements.
Unfortunately I currently get for both grids:
```
Dune::InvalidStateException [decompose:/Users...Adds a 2d test on a sphere tet grid (`sphere.msh`). I also committed a `sphere_quad.msh` grid which has some nasty distorted quad elements.
Unfortunately I currently get for both grids:
```
Dune::InvalidStateException [decompose:/Users/pumbaa/dune-master/dumux/dumux/discretization/cellcentered/wmpfa/facedatahandle.hh:101]: CoNormal decomposition not found
```
although the tet version of the grid looks fairly nice.
I wanted to use this test to check if it works in 3D.
For now it's only Dirichlet but it should be relatively easy to try Neumann boundaries.Martin SchneiderMartin Schneider