Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 95
    • Issues 95
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 90
    • Merge requests 90
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Merge requests
  • !2831

[material] Add option to PengRobinson::computeMolarVolume

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timo Koch requested to merge feature/molarvolume-pengrobinson into master Sep 16, 2021
  • Overview 0
  • Commits 1
  • Changes 1
  • Ignoring the first two roots of the equation for Z in the smallest one is zero or negative. There was a comment documenting that behavior, but it was not implemented.

  • Throwing NumericalProblem if no positive Z has been found or the number of roots is 2 or more than 3 (no check was in place)

  • Throwing NumericalProblem if the found molar volume turned out to be zero, negative, or NaN. (Replacing assert)

  • Added handleUnphysicalPhase flag (true by default). If false, the single-root case is not checked for critical state of the fluid (otherwise, Michelsen test for a mix of hydrocarbons does not work).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/molarvolume-pengrobinson