Skip to content

FluxVarsCache: Check if throat is invaded to calculate WettingLayerArea

What this MR does / why does DuMux need it:

I see the following issue in the update function of the fluxvarscache:

  • if a theta function is present in the problem, it is not checked if the throat is invaded to calculate the wettingLayerArea. If the throat is not invaded a WettingLayerArea is calculated based on the curvatureRadius, contactAngle and cornerHalfAngles, which is lower than the total Area. This leads also to a positive throat cross-sectional area for the non wetting phase.

This merge request inserts a check if the throat is invaded to calculate the WettingLayerArea if a theta-function is used in the problem.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
  • (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
Edited by Theresa Schollenberger

Merge request reports