From 4efb4d92e0dafd3c42b141d5c4015cd76e587a85 Mon Sep 17 00:00:00 2001
From: Leon Keim <leon.keim@googlemail.com>
Date: Fri, 28 Jun 2024 07:17:10 +0000
Subject: [PATCH 1/7] [changelog] Add Pipeline updates, such as new 24.04
 schedule, Updated dependencies

---
 CHANGELOG.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 198c3b74c1..2f678ad3ee 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,7 +1,7 @@
 Differences Between DuMu<sup>x</sup> 3.9 and DuMu<sup>x</sup> 3.8
 =============================================
 
-- __Requirements__:
+- __Requirements__: DuMux requires Dune >=2.9 and CMake >= 3.16. It was successfully tested with dune-mmesh 1.4 and OPM 2023.10.
 
 ### General changes / structure
 
@@ -24,6 +24,8 @@ The function uses new spatial parameter interface implemented in the new `Brinkm
 - __CompositionalFluidState__: setRelativeHumidity was removed. Use the other setters. This setter was removed because it was very specific with a lot of specific prerequisites not fitting the general concept of the class. It was also outdated and not used in any example or test and didn't fit the index convention used in the fluid systems anymore.
 ### Deprecated properties/classes/functions/files, to be removed after 3.9:
 - __Periodic Map__: `periodicVertexMap()` has been deprecated. Use `periodicDofMap()` instead.
+- __Pipeline__: Variable docker image testing is now possible directly out of dumux. A weekly Ubuntu 24.04 pipeline is introduced for a smooth transition to 24.04 in the future.
+- __Dependencies__: Fieldcompare and Pylint have been upgraded to newer versions.
 
 Differences Between DuMu<sup>x</sup> 3.8 and DuMu<sup>x</sup> 3.7
 =============================================
-- 
GitLab


From f6c4d93ed074786456670c741573b9029d9bf3ee Mon Sep 17 00:00:00 2001
From: Anna Mareike Kostelecky <anmako96@web.de>
Date: Fri, 28 Jun 2024 10:42:37 +0200
Subject: [PATCH 2/7] [changelog] mention bug fix for pm 2pncmin ni test case

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2f678ad3ee..82c92a6956 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,6 +22,7 @@ The function uses new spatial parameter interface implemented in the new `Brinkm
 ### Immediate interface changes not allowing/requiring a deprecation period:
 - __RichardsNewtonSolver__: It is now possible to select the MPICommunicator used by the RichardsNewtonSolver (e.g., either real or dummy communicator)
 - __CompositionalFluidState__: setRelativeHumidity was removed. Use the other setters. This setter was removed because it was very specific with a lot of specific prerequisites not fitting the general concept of the class. It was also outdated and not used in any example or test and didn't fit the index convention used in the fluid systems anymore.
+- __Porous Medium Flow for 2pncmin__ Fixed a bug for the non-isothermal 2pncmin test to use the permeability of the current time and not the reference one as permeability can change over time
 ### Deprecated properties/classes/functions/files, to be removed after 3.9:
 - __Periodic Map__: `periodicVertexMap()` has been deprecated. Use `periodicDofMap()` instead.
 - __Pipeline__: Variable docker image testing is now possible directly out of dumux. A weekly Ubuntu 24.04 pipeline is introduced for a smooth transition to 24.04 in the future.
-- 
GitLab


From db0252a16943944f2c798d7f0953bb6885cc822e Mon Sep 17 00:00:00 2001
From: Leon Keim <leon.keim@googlemail.com>
Date: Fri, 28 Jun 2024 08:47:02 +0000
Subject: [PATCH 3/7] move improvement to correct place

---
 CHANGELOG.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 82c92a6956..ee0c50d27e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,14 +19,14 @@ The function uses new spatial parameter interface implemented in the new `Brinkm
 - __Components__: Added the new class `ShomateMethod` for calculating the heat capacity and enthalpy of components at specified temperatures. An example implementation can be found for methane (CH4).
 - __TPFA Dispersion__: Fixed the transmissibility calculation for tpfa dispersion fluxes.
 - __Energy Balance Implementation__: modify the energy balance implementation to correctly include the contribution of gravity.
+- __Pipeline__: Variable docker image testing is now possible directly out of dumux. A weekly Ubuntu 24.04 pipeline is introduced for a smooth transition to 24.04 in the future.
+- __Dependencies__: Fieldcompare and Pylint have been upgraded to newer versions.
 ### Immediate interface changes not allowing/requiring a deprecation period:
 - __RichardsNewtonSolver__: It is now possible to select the MPICommunicator used by the RichardsNewtonSolver (e.g., either real or dummy communicator)
 - __CompositionalFluidState__: setRelativeHumidity was removed. Use the other setters. This setter was removed because it was very specific with a lot of specific prerequisites not fitting the general concept of the class. It was also outdated and not used in any example or test and didn't fit the index convention used in the fluid systems anymore.
 - __Porous Medium Flow for 2pncmin__ Fixed a bug for the non-isothermal 2pncmin test to use the permeability of the current time and not the reference one as permeability can change over time
 ### Deprecated properties/classes/functions/files, to be removed after 3.9:
 - __Periodic Map__: `periodicVertexMap()` has been deprecated. Use `periodicDofMap()` instead.
-- __Pipeline__: Variable docker image testing is now possible directly out of dumux. A weekly Ubuntu 24.04 pipeline is introduced for a smooth transition to 24.04 in the future.
-- __Dependencies__: Fieldcompare and Pylint have been upgraded to newer versions.
 
 Differences Between DuMu<sup>x</sup> 3.8 and DuMu<sup>x</sup> 3.7
 =============================================
-- 
GitLab


From 7b3bdec015b376e81ed3a3cbcd12f8759adcb7d9 Mon Sep 17 00:00:00 2001
From: Leon Keim <leon.keim@googlemail.com>
Date: Fri, 28 Jun 2024 09:19:54 +0000
Subject: [PATCH 4/7] add depecrated interfaces

---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ee0c50d27e..a05a5655c4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,6 +25,8 @@ The function uses new spatial parameter interface implemented in the new `Brinkm
 - __RichardsNewtonSolver__: It is now possible to select the MPICommunicator used by the RichardsNewtonSolver (e.g., either real or dummy communicator)
 - __CompositionalFluidState__: setRelativeHumidity was removed. Use the other setters. This setter was removed because it was very specific with a lot of specific prerequisites not fitting the general concept of the class. It was also outdated and not used in any example or test and didn't fit the index convention used in the fluid systems anymore.
 - __Porous Medium Flow for 2pncmin__ Fixed a bug for the non-isothermal 2pncmin test to use the permeability of the current time and not the reference one as permeability can change over time
+- __porousmedium/nonisothermal/localresidual__: fluidPhaseStorage() now requires problem.
+- __porousmedium/nonequilibrium/thermal/localresidual__: fluidPhaseStorage() now requires problem.
 ### Deprecated properties/classes/functions/files, to be removed after 3.9:
 - __Periodic Map__: `periodicVertexMap()` has been deprecated. Use `periodicDofMap()` instead.
 
-- 
GitLab


From e5a12f00c58d23dae73edf141ea83f50b6ac4f0e Mon Sep 17 00:00:00 2001
From: Leon Keim <leon.keim@googlemail.com>
Date: Fri, 28 Jun 2024 09:20:31 +0000
Subject: [PATCH 5/7] add new test for simpleh2o

---
 CHANGELOG.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a05a5655c4..857947103e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,7 +7,7 @@ Differences Between DuMu<sup>x</sup> 3.9 and DuMu<sup>x</sup> 3.8
 
 ### Improvements and Enhancements
 
-- __SimpleH2O__: Fixed an issue where the function vaporizationEnthalpy returned the result in the wrong unit
+- __SimpleH2O__: Fixed an issue where the function vaporizationEnthalpy returned the result in the wrong unit, added new nonisothermal test.
 - __Face Centered Velocity Reconstrution__: For freeflow evaluation using the FC Staggered discretization, a reconstrution method has been implemented to collect the full velocity vector at the face center.
 - __Darcy-Brinkman Freeflow__: There is no a convenience function to add a Brinkman term to turn the Navier-Stokes model into the Darcy-Brinkman model. With this, a single domain can contain both free flow and flow through a porous medium.
 The term is added as a source term in the problem using the new helper function `addBrinkmanTerm`.
@@ -24,7 +24,7 @@ The function uses new spatial parameter interface implemented in the new `Brinkm
 ### Immediate interface changes not allowing/requiring a deprecation period:
 - __RichardsNewtonSolver__: It is now possible to select the MPICommunicator used by the RichardsNewtonSolver (e.g., either real or dummy communicator)
 - __CompositionalFluidState__: setRelativeHumidity was removed. Use the other setters. This setter was removed because it was very specific with a lot of specific prerequisites not fitting the general concept of the class. It was also outdated and not used in any example or test and didn't fit the index convention used in the fluid systems anymore.
-- __Porous Medium Flow for 2pncmin__ Fixed a bug for the non-isothermal 2pncmin test to use the permeability of the current time and not the reference one as permeability can change over time
+- __Porous Medium Flow for 2pncmin__ Fixed a bug for the non-isothermal 2pncmin test to use the permeability of the current time and not the reference one as permeability can change over time.
 - __porousmedium/nonisothermal/localresidual__: fluidPhaseStorage() now requires problem.
 - __porousmedium/nonequilibrium/thermal/localresidual__: fluidPhaseStorage() now requires problem.
 ### Deprecated properties/classes/functions/files, to be removed after 3.9:
-- 
GitLab


From df9e6158222705b456645d958c7996e43bdbb26c Mon Sep 17 00:00:00 2001
From: Leon Keim <leon.keim@googlemail.com>
Date: Fri, 28 Jun 2024 09:26:38 +0000
Subject: [PATCH 6/7] add deletion of old interfaces

---
 CHANGELOG.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 857947103e..09cdf53d38 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,8 +25,8 @@ The function uses new spatial parameter interface implemented in the new `Brinkm
 - __RichardsNewtonSolver__: It is now possible to select the MPICommunicator used by the RichardsNewtonSolver (e.g., either real or dummy communicator)
 - __CompositionalFluidState__: setRelativeHumidity was removed. Use the other setters. This setter was removed because it was very specific with a lot of specific prerequisites not fitting the general concept of the class. It was also outdated and not used in any example or test and didn't fit the index convention used in the fluid systems anymore.
 - __Porous Medium Flow for 2pncmin__ Fixed a bug for the non-isothermal 2pncmin test to use the permeability of the current time and not the reference one as permeability can change over time.
-- __porousmedium/nonisothermal/localresidual__: fluidPhaseStorage() now requires problem.
-- __porousmedium/nonequilibrium/thermal/localresidual__: fluidPhaseStorage() now requires problem.
+- __porousmedium/nonisothermal/localresidual__: fluidPhaseStorage() now requires problem. Old interface will be deleted after release 3.9.
+- __porousmedium/nonequilibrium/thermal/localresidual__: fluidPhaseStorage() now requires problem. Old interface will be deleted after release 3.9.
 ### Deprecated properties/classes/functions/files, to be removed after 3.9:
 - __Periodic Map__: `periodicVertexMap()` has been deprecated. Use `periodicDofMap()` instead.
 
-- 
GitLab


From 34fbc9634343c4f5b7d258464af014a447fcdca6 Mon Sep 17 00:00:00 2001
From: Leon Keim <leon.keim@googlemail.com>
Date: Fri, 28 Jun 2024 09:33:41 +0000
Subject: [PATCH 7/7] move bug fix to improvements and enhancements

---
 CHANGELOG.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 09cdf53d38..011cd56ec9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -21,10 +21,11 @@ The function uses new spatial parameter interface implemented in the new `Brinkm
 - __Energy Balance Implementation__: modify the energy balance implementation to correctly include the contribution of gravity.
 - __Pipeline__: Variable docker image testing is now possible directly out of dumux. A weekly Ubuntu 24.04 pipeline is introduced for a smooth transition to 24.04 in the future.
 - __Dependencies__: Fieldcompare and Pylint have been upgraded to newer versions.
+- __Porous Medium Flow for 2pncmin__ Fixed a bug for the non-isothermal 2pncmin test to use the permeability of the current time and not the reference one as permeability can change over time.
 ### Immediate interface changes not allowing/requiring a deprecation period:
 - __RichardsNewtonSolver__: It is now possible to select the MPICommunicator used by the RichardsNewtonSolver (e.g., either real or dummy communicator)
 - __CompositionalFluidState__: setRelativeHumidity was removed. Use the other setters. This setter was removed because it was very specific with a lot of specific prerequisites not fitting the general concept of the class. It was also outdated and not used in any example or test and didn't fit the index convention used in the fluid systems anymore.
-- __Porous Medium Flow for 2pncmin__ Fixed a bug for the non-isothermal 2pncmin test to use the permeability of the current time and not the reference one as permeability can change over time.
+
 - __porousmedium/nonisothermal/localresidual__: fluidPhaseStorage() now requires problem. Old interface will be deleted after release 3.9.
 - __porousmedium/nonequilibrium/thermal/localresidual__: fluidPhaseStorage() now requires problem. Old interface will be deleted after release 3.9.
 ### Deprecated properties/classes/functions/files, to be removed after 3.9:
-- 
GitLab