Skip to content

Include gravity impact on the pressure at the boundary

Maziar Veyskarami requested to merge fix/ff-bc-gravity-impact into master

What this MR does / why does DuMux need it:

If gravity needs to be included, assigning a fixed pressure at the outlet of the free-flow channel could lead to non-symmetrical velocity profile near the outlet and even back-flow. This problem is more obvious when the inlet velocity is low.

To fix it, we need to include the impact of the gravity as hydrostatic pressure and add it to the outlet pressure specified by user.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Maziar Veyskarami

Merge request reports

Loading