Skip to content

[pm][nc] Account for useMoles for compositional dispersion

Mathis Kelm requested to merge fix/compositional-dispersion-use-moles into master

What this MR does / why does DuMux need it:

Compositional dispersion didn't account for useMoles by scaling the mass/mole (based on reference system) fluxes with molar masses to obtain the required mass/mole flux (based on useMoles). The flux was only correct if the two were the same.

Notes for the reviewer

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Mathis Kelm

Merge request reports

Loading