Skip to content

[cleanup] Fix deprecation warning being emitted always

Timo Koch requested to merge fix/deprecation-warning-baselocalresidual into master

Fixes #1447 (closed)

Notes for the reviewer

If, for example, I add the patch

diff --git a/dumux/porousmediumflow/immiscible/localresidual.hh b/dumux/porousmediumflow/immiscible/localresidual.hh
index c7bc887780..077d58a6d7 100644
--- a/dumux/porousmediumflow/immiscible/localresidual.hh
+++ b/dumux/porousmediumflow/immiscible/localresidual.hh
@@ -26,10 +26,10 @@ namespace Dumux {
  */
 template<class TypeTag>
 class ImmiscibleLocalResidual
-: public DiscretizationDefaultLocalOperator<TypeTag>
+: public  GetPropType<TypeTag, Properties::BaseLocalResidual>
 {
     using ThisType = ImmiscibleLocalResidual<TypeTag>;
-    using ParentType = DiscretizationDefaultLocalOperator<TypeTag>;
+    using ParentType = GetPropType<TypeTag, Properties::BaseLocalResidual>;
     using Scalar = GetPropType<TypeTag, Properties::Scalar>;
     using Problem = GetPropType<TypeTag, Properties::Problem>;
     using NumEqVector = Dumux::NumEqVector<GetPropType<TypeTag, Properties::PrimaryVariables>>;

I get a deprecation warning for 1p_incompressible_box_numdiff otherwise not.

Edited by Timo Koch

Merge request reports

Loading