Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 86
    • Merge requests 86
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !953

Feature/improve ff boundary

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kilian Weishaupt requested to merge feature/improve-ff-boundary into master May 02, 2018
  • Overview 6
  • Commits 5
  • Pipelines 0
  • Changes 36

fixes #487 (closed)

  • move staggered gridVolVars to free flow sub folder
  • adapt indices in tests, if necessary

Some reference solutions had to be updated because there was a bug / logical error:

For inlet (e.g., in tests featuring a channel), a Dirichlet BC for velocity was set, combined with an outflow BC for pressure, which basically set the pressure of the virtual outer volVars to the one of inner volVars:

p_out = p_in

This is per se not bad and acutally the desired behavior.

However, in the fluxVars, the advective fluxes themselves checked for an outflow BC for each eqIdx and then always used the inner volVars if outflow for conti0EqIdx (== pressureIdx) was set. This means that for eqIdx == conti0EqIdx, an inflowing fluid would use p_in (which is good) but also T_in, x_in ect. which is actually wrong because user-specified Dirchlet values should be used for that instead.

The new implementation accounts for this.

Edited May 11, 2018 by Kilian Weishaupt
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/improve-ff-boundary