dumux issueshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues2018-05-22T08:57:16Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/497Contribution and style guide2018-05-22T08:57:16ZTimo Kochtimo.koch@iws.uni-stuttgart.deContribution and style guideWe should have a contribution guide (how to format commits, what we expect, e.g. that a new feature is tested),
and a style guide (naming conventions and formatting conventions).
GitLab recognized a `CONTRIBUTING.md` file and others can be linked in there. See !992.
We should extend !992 so that we have basic guidelines which can be extended.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/496Confusing phase numbering2018-05-23T20:28:25ZThomas FetzerConfusing phase numberingIn e.g. the 2p2c model, the phase numbering is a bit confusing. The formulation allows for p0s1 or p1s0, but the setState() function for the priVars allows firstPhaseOnly and secondPhaseOnly. In addition, it should be checked, if the privarsswitchnewton could print the phase's names instead of something like "First phase dissapears .... s0 < 0".3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/493Unify PorousMediumVolVars and FreeFlowVolVars2018-05-08T16:47:50ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deUnify PorousMediumVolVars and FreeFlowVolVarsAfter having introduced the solid system, both PM flow and free flow should be able to use the same base volVars3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/491Implement check for stationary/instationary grid variables in assembler2018-05-08T07:53:54ZTimo Kochtimo.koch@iws.uni-stuttgart.deImplement check for stationary/instationary grid variables in assemblerThere should an error thrown if an instationary assembler is instantiated with a stationary grid variables object.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/490Convergence rates for staggered free flow implementation2018-05-08T07:29:44ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deConvergence rates for staggered free flow implementationWe should have a discussion about the expected convergence rates for v and p and double check the currently implemented tests.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/489Generic CO2 Component2018-05-03T09:56:43ZSimon ScholzGeneric CO2 ComponentWe currently have a ``simpleco2.hh`` for when CO2 is used as an ideal gas and a ``co2.hh``, which uses the values from the CO2Tables.
We would like to have a CO2 component that chooses automatically between a "simple CO2" formulation (when used in the ideal gas regime) or the tabulated values from the CO2 tables (when used in the super-critical regime) or some interpolation between the two.
* [ ] Define/Look up regime for ideal gas and super-critical state
* [ ] Think of good and efficient interpolation
* [ ] implement all
**Discussion:**
Should we include the option to "force" the use of either one, in case you really want to use CO2-Tables or the ideal gas law all the time?3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/479[test] make geometry test fails2018-04-23T12:01:35ZTimo Kochtimo.koch@iws.uni-stuttgart.de[test] make geometry test fails```
testing for quadrilateral with normal in z direction
Dune::InvalidStateException [permutatePointsAndTest:/home/timok/dumux-course/dumux/test/common/geometry/test_makegeometry.cc:82]: Check for point inside geometry failed. Point 0.001 0.001 0 does not lie within the geometry!
```
This might be due to a bug in `intersectPointGeometry`.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/478Reuse gradN from the fluxvarcache in maxwell stefan law2018-04-22T07:40:07ZTimo Kochtimo.koch@iws.uni-stuttgart.deReuse gradN from the fluxvarcache in maxwell stefan lawCurrently maxwell stefan law computes the ansatz function derivative again, although it's cached in the box fluxvarcache.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/474[material][brine] Implement brine fluid system and brine pseudo component2018-04-20T17:12:13ZTimo Kochtimo.koch@iws.uni-stuttgart.de[material][brine] Implement brine fluid system and brine pseudo componentBrine is currently a pseudo component but extends the interface to be able to have variable salinity. A mixture with variable salinity is however a fluid system. We should implement both interface (brine as fluidsystem and brine as pseudocomponent with constant salinity) classes separately.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/469Compiler warnings2018-04-10T07:07:10ZThomas FetzerCompiler warningsWe should fix or at least discuss whether we want to fix the following compiler warnings (I am aware that DUNE prints a lot of this warnings, too).
* [ ] -Wshadow (shadowing of local variables, e.g. by lambda functions or if/for loops)
* [ ] -Wmissing-braces (initiliazation, e.g. object({}) vs object{{}} )
* [ ] -Wunused-result (e.g. #472)3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/462Changelog for 3.02018-04-17T09:16:08ZTimo Kochtimo.koch@iws.uni-stuttgart.deChangelog for 3.0This is supposed to be a collection of things that changed in version 3.0. We also planned to write a little guide on the newly introduced things concerning implementers of problem/spatialparams/mainfile/materiallaws.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/458[task] Reimplement restart facility2018-03-03T19:09:35ZTimo Kochtimo.koch@iws.uni-stuttgart.de[task] Reimplement restart facilityThe restart feature got lost in transition to 3.0. Think about how to reimplement in the new structure. Most main files still have left over restart code that doesn't do anything.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/450BrineAir Fluidsystem problems2018-04-17T09:16:33ZSimon ScholzBrineAir Fluidsystem problems* [ ] vaporPressure does not depend on osmotic potential anymore:
Vishal introduced it like this:
```
static Scalar vaporPressure_(Scalar T, Scalar x)
{
Scalar p_0 = H2O::vaporPressure(T);//Saturation vapor pressure for pure water
Scalar p_s = p_0; // modified saturation vapor pressure for saline water
// #if SALINIZATION
// Scalar vw = 18.0e-6;//[m3/mol] volume per unit mole of water
// Scalar R = 8.314;//[j/K mol] universal gas constant
// Scalar pi = (R * T * std::log(1- x))/vw;
// if (x > 0.26) // here we have hard coaded the solubility limit for NaCl
// pi = (R * T * std::log(0.74))/vw;
// p_s = p_0 * std::exp((pi*vw)/(R*T));// Kelvin's law for reduction in saturation vapor pressure due to osmotic potential
// #endif
return p_s;
}
```
Todo: Check if salinity has the desired influence where needed. Do always pass salinity, otherwise constantSalinity is used.3.0Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/447Multidomain module in 3.02018-02-14T16:43:43ZTimo Kochtimo.koch@iws.uni-stuttgart.deMultidomain module in 3.0* See !736 for module description.
* commit 57e85394c53563606c5356ab2bc2f6022ca79ed5 removed the old mixeddimension code on the next branch in case you need something for reference for the new implementation.
Here we can discuss further wishes and ideas.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/442Collection of not working tests / errors on buildbot2018-05-16T13:52:29ZSimon ScholzCollection of not working tests / errors on buildbotThis is a collection of problems we currently have on buildbot. It is collected here to help everyone in fixing the last tests.
The following fail:
**test flow
* [ ] test_2p_fracture_gravity_mpfa --> Data differs -> Dennis
* [ ] test_2p_fracture_gravity_tpfa --> Data differs in parameter: Sn, mobW, pc -> Dennis
* [ ] test_box3pwateroil -> was fixed but still fails on buildbot while passing on my notebook+desktop -> Bernd
3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/431Grid shouldn't be a singleton2018-04-12T12:26:46ZTimo Kochtimo.koch@iws.uni-stuttgart.deGrid shouldn't be a singletonThere is not just always one grid of a type, or one grid per typetag/problem. So the grid shouldn't be implemented as a singleton.
The gridcreator / gridwrapper needs to be available to problems (boundary conditions) and spatial params (params from dgf/msh) for parameters.
We could pass a shared_ptr to the problem / spatialparams in the constructor.
All occurances of `GridCreator::grid()` should be replaced by either `gridView.grid()` or using a grid object directly (adaptive).
see also !185 3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/427Improve staggered free flow model2018-05-14T12:25:14ZTimo Kochtimo.koch@iws.uni-stuttgart.deImprove staggered free flow model- [x] Account for extrusion factor (see !914)
- [x] fluxes
- [x] storage terms
- [x] Add 2D friction term to mimic 3D flow (see !925)
- [ ] Implement better tests (e.g. 3D, transient, backward-facing step, etc.) (see #415)
- [ ] Improve the documentation (help message) and appearance of the test provlems
- [x] Improve inheritance structure (especially for RANS models) (see !915)
- [x] Improve boundary conditions (#487)3.0Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/426BrineCO2 Fluidsystems uses wrong/misleading gasDensity_ calculation2018-02-19T13:48:47ZSimon ScholzBrineCO2 Fluidsystems uses wrong/misleading gasDensity_ calculationThe ``brineco2.hh`` fluidystems uses an incorrect gasDensity calculation in the private ``gasDensity_`` function. It returns the unchanged CO2 gas density, while the density function implies a lot more complex density calculation similar to the ``liquidDensity_``.
This seems to be like this from the very first commit on git, but e.g. in a ``biofluidsystem.hh`` that was derived from the brineco2.hh a long time ago by @hommel on dumux-devel there is a more complex gasDensity calculation using Dalton's law available. (see below)
I suggest we change/fix this once most tests pass, because this might change some results for the ``next`` branch.
I am not sure, what we should do about the master (or 2.12).
Additionally the normalization of some moleFractions etc. seems a little sketchy to me, but that might be necessary.
Additionally the second the brineco2.hh still uses the deprecated xl and xg naming. This should be changed, while fixing this.
` static Scalar gasDensity_(Scalar T,
Scalar pg,
Scalar xgH2O)
{
Scalar pH2O = xgH2O*pg; //Dalton' Law
Scalar pCO2 = pg - pH2O;
Scalar gasDensityCO2 = CO2::gasDensity(T, pCO2);
Scalar gasDensityH2O = H2O::gasDensity(T, pH2O);
Scalar gasDensity = gasDensityCO2 + gasDensityH2O;
return gasDensity;
}`3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/425unused headers2018-04-17T09:21:28ZBernd Flemischunused headersTest the following headers:
- common/reorderingdofmapper.hh
- common/quad.hh
- io/cpgridcreator.hh
- linear/scotchbackend.hh
- material/chemistry/electrochemistry/electrochemistryni.hh
- nonlinear/newtonconvergencewriter.hh3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/issues/415Implement better tests for freeflow2018-05-02T13:40:11ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deImplement better tests for freeflowThere is a myriad of benchmarks, numerical and analytical solutions for free-flow problems. We should incorporate more of them in our free-flow tests. Thomas and Christoph had some of them for their staggered grid implementation.
Currently, there are two test which come with an analytical solution:
`test_donea` and `test_kovasznay`
Here a some ideas what could be added:
- [ ] Analytical solution for simple stationary 2d channel test (test already exists)
- [ ] [Ghia 1982](https://ac.els-cdn.com/0021999182900584/1-s2.0-0021999182900584-main.pdf?_tid=e9f7486c-d67c-11e7-96b6-00000aab0f26&acdnat=1512121945_6871c2de3e7d5699f53ef718416dc341)
- [x] Transient flow field test with analytical solution
- [ ] Transient flow field test: lid driven cavity
- [ ] Analytical solution for diffusion (mass/energy) tests
- [ ] Ensure same results for mass and mole formulation (see !950)
More suggestions welcome!
- [ ] Improve the description of the tests and the help-message
Could be a job for a HiWi.3.0