FS#166 Unused methods primaryVarWeight
Metadata
Property | Value |
---|---|
Project | dumux |
Category | General |
Reported by | Bernd Flemisch (bernd@iws.uni-stuttgart.de) |
Reported at | Oct 2, 2012 14:04 |
Type | Bug Report |
Version | Git |
Last edited by | Bernd Flemisch (bernd@iws.uni-stuttgart.de) |
Last edited at | Oct 8, 2012 15:55 |
Closed by | Bernd Flemisch (bernd@iws.uni-stuttgart.de) |
Closed at | Oct 8, 2012 15:55 |
Closed in version | 2.2 |
Resolution | Implemented |
Description
Almost 1.5 years ago in commit 5998, the two lines
Scalar weight = asImp_().primaryVarWeight(vertexIdx, j); Scalar eqErr = std::abs(priVars1[j] - priVars2[j])*weight;
in BoxModel's relativeErrorVertex have been commented and replaced by
Scalar eqErr = std::abs(priVars1[j] - priVars2[j]); eqErr /= std::max(1.0, std::abs(priVars1[j] + priVars2[j])/2);
Since then, the methods primaryVarWeight of the individual box models (with a default in the base class) have not been used. Since we apparently live happy without these methods for 1.5 years, I would propose to mark them deprecated and delete them after 2.2.