dumux-repositories issueshttps://git.iws.uni-stuttgart.de/groups/dumux-repositories/-/issues2021-04-11T12:08:10Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/987[test] Extend tests for 1d3d intersection2021-04-11T12:08:10ZTim Jupe[test] Extend tests for 1d3d intersectionIntersection tests for line-hexahedron, line-pyramid and line-prism are missing.Intersection tests for line-hexahedron, line-pyramid and line-prism are missing.3.4Tim JupeTim Jupehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/997Add non-Darcy flow upscaling example2022-09-08T07:44:35ZTimo Kochtimokoch@math.uio.noAdd non-Darcy flow upscaling exampleThe following discussion from !2420 should be addressed:
- [x] @timok started a [discussion](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2420#note_54324): (+2 comments)
> I would be awesome to have a...The following discussion from !2420 should be addressed:
- [x] @timok started a [discussion](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2420#note_54324): (+2 comments)
> I would be awesome to have a test that computes permeability in one direction for a network e.g. extracted from the Berea sandstone sample for different pressure gradients. Then we could do at least a qualitative comparison with Muljadi et al. https://doi.org/10.1016/j.advwatres.2015.05.019 (essentially reproduce one of the plots of El-Zehairy et al. https://doi.org/10.1016/j.advwatres.2019.103378)3.6Maziar VeyskaramiMaziar Veyskaramihttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1028[CI] keep going when some targets can't be built2021-05-12T10:32:09ZTimo Kochtimokoch@math.uio.no[CI] keep going when some targets can't be builtCurrently builds stop on first failure. But it's usually good to get the full picture of failing tests.
We can add `-k`/`--keep-going` to `make`. I don't know if the number of failed target builds can be limited. With `ninja` this is po...Currently builds stop on first failure. But it's usually good to get the full picture of failing tests.
We can add `-k`/`--keep-going` to `make`. I don't know if the number of failed target builds can be limited. With `ninja` this is possible, e.g. stop after 20 targets couldn't be made because then there is something seriously wrong which is probably clear by then.Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1077Consistent naming in test/references2021-09-30T17:31:43ZTimo Kochtimokoch@math.uio.noConsistent naming in test/referencesMake sure the references
* [ ] start with `test_` and end with `-reference.*`
* other rules?Make sure the references
* [ ] start with `test_` and end with `-reference.*`
* other rules?3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1106[test][cleanup] Remove test description above problem/spatialparams/main (in-...2022-04-07T12:50:35ZTimo Kochtimokoch@math.uio.no[test][cleanup] Remove test description above problem/spatialparams/main (in-code doc)In many (system-)tests, we have a description of the scenario on top of the problem and sometimes running instructions. Such a description is only required for documented examples. In the test folder, it tends to easily become outdated o...In many (system-)tests, we have a description of the scenario on top of the problem and sometimes running instructions. Such a description is only required for documented examples. In the test folder, it tends to easily become outdated or it's often wrong in the first place due to copy and paste. Running the test is already documented by CMakeLists.txt and should be done through CTest anyways. The description easily becomes outdated if the test is extended or changes.
This suggests removing any such "documentation" in the test folder.3.5Mathis KelmMathis Kelmhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1126Add CO2 benchmark case?2023-12-13T11:13:09ZTimo Kochtimokoch@math.uio.noAdd CO2 benchmark case?Is it possible/feasible to add the benchmark case Holger Class et al , A benchmark study on problems related to CO2 storage in geologic formations, Computational Geosciences 13 (2009), no. 4, 409–434.
into the test suite?Is it possible/feasible to add the benchmark case Holger Class et al , A benchmark study on problems related to CO2 storage in geologic formations, Computational Geosciences 13 (2009), no. 4, 409–434.
into the test suite?https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1180New Compositional Staggered2023-10-26T08:13:30ZNed ColtmanNew Compositional Staggeredmentioned in #1115
Implementation and ported tests addressed in !2986 .
New Analytical solution and convergence test implemented in !3044 . Also implemented for old staggered in !3561 .
Troubleshooting branch: `feature/misc_naviersto...mentioned in #1115
Implementation and ported tests addressed in !2986 .
New Analytical solution and convergence test implemented in !3044 . Also implemented for old staggered in !3561 .
Troubleshooting branch: `feature/misc_navierstokesnc` .
Using this issue to collect all of the ideas and progress we have made (the MRs are not organized for this)3.8Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1209[cleanup] Use new ignore field feature of the test driver2023-03-14T18:01:36ZTimo Kochtimokoch@math.uio.no[cleanup] Use new ignore field feature of the test driverThe dumux test script https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/testing/runtest.py gets with !3353 an option to ignore fields (`--ignore "fielda" "fieldb"`). This can be used instead of setting a very hi...The dumux test script https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/testing/runtest.py gets with !3353 an option to ignore fields (`--ignore "fielda" "fieldb"`). This can be used instead of setting a very high zero threshold to make the intent clear.
Example: `rank` should be ignored when comparison parallel and sequential files.
Example implementation: `test/freeflow/shallowwater/dambreak/CMakeLists.txt`3.7Harsha Pallamharsha.pallam@iws.uni-stuttgart.deHarsha Pallamharsha.pallam@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1324[porousmediumflow][2pncmin][nonisothermal] Use mass fractions for diffusive N...2023-12-13T14:15:55ZSimon Grether[porousmediumflow][2pncmin][nonisothermal] Use mass fractions for diffusive Neumann fluxIn the [non-isothermal 2pncmin test](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/tree/master/test/porousmediumflow/2pncmin/nonisothermal?ref_type=heads) the mole fraction is used in the [problem](https://git.iws.uni-stutt...In the [non-isothermal 2pncmin test](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/tree/master/test/porousmediumflow/2pncmin/nonisothermal?ref_type=heads) the mole fraction is used in the [problem](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/test/porousmediumflow/2pncmin/nonisothermal/problem.hh?ref_type=heads) for calculating the diffusive Neumann flux of the evaporation rate. However, when using a mass-averaged reference system, the mass fraction should be used for the difference quotient of diffusive fluxes.
Therefore, I propose the following correction:
`static const Scalar massFracRefH2O = getParam("FreeFlow.RefMassFracH2O");`
`...`
`const Scalar massFracH2OInside = volVars.massFraction(gasPhaseIdx, H2OIdx);`
`...`
`if (massFracH2OInside - massFracRefH2O > 0)`
`...`
`* (massFracH2OInside - massFracRefH2O)`
`...`
`* (massFracH2OInside - massFracRefH2O)`
`...`
Moreover, the reference value for the free-flow in the [input-file](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/test/porousmediumflow/2pncmin/nonisothermal/params.input?ref_type=heads) should be converted into the mass fraction.Anna Mareike KosteleckyAnna Mareike Kosteleckyhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1325[porousmediumflow][2pncmin][nonisothermal] Use current permeability for Neuma...2024-01-10T08:34:05ZSimon Grether[porousmediumflow][2pncmin][nonisothermal] Use current permeability for Neumann gas fluxIn the [non-isothermal 2pncmin test](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/tree/master/test/porousmediumflow/2pncmin/nonisothermal?ref_type=heads) the reference permeability is used in the [problem](https://git.iws....In the [non-isothermal 2pncmin test](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/tree/master/test/porousmediumflow/2pncmin/nonisothermal?ref_type=heads) the reference permeability is used in the [problem](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/test/porousmediumflow/2pncmin/nonisothermal/problem.hh?ref_type=heads) for calculating the Neumann flux of the component air. However, the permeability changes during the simulation due to the precipitation of salt.
Therefore, I propose to use the current permeability here:
`...`
`*volVars.permeability()`
`...`
`*volVars.permeability()`
`...`Anna Mareike KosteleckyAnna Mareike Kostelecky