dumux-repositories issueshttps://git.iws.uni-stuttgart.de/groups/dumux-repositories/-/issues2018-11-22T21:08:44Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/601CakeGridCreator only works for 360 degrees2018-11-22T21:08:44ZMartin BeckCakeGridCreator only works for 360 degreesThe CakeGridCreator is implemented such that the last element shares its side face with the first element. This makes sense for a 360-degree-cake, but is unfortunately used for all cakes independent of the angle.The CakeGridCreator is implemented such that the last element shares its side face with the first element. This makes sense for a 360-degree-cake, but is unfortunately used for all cakes independent of the angle.3.0Martin BeckMartin Beckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/544Need for unit test for CheckPointTimeLoop2018-08-03T06:01:19ZTimo Kochtimokoch@math.uio.noNeed for unit test for CheckPointTimeLoopThe check pointing can be tricky with floating point operations. We should have a unit test testing corner cases, very small and very big time step size and so on.The check pointing can be tricky with floating point operations. We should have a unit test testing corner cases, very small and very big time step size and so on.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/481test solidsystems and solid components2018-05-24T13:48:09ZTimo Kochtimokoch@math.uio.notest solidsystems and solid componentsOnce we have solidsystem (!903) we should also have a solid system unit test.Once we have solidsystem (!903) we should also have a solid system unit test.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/465simplesteamaircao2h2.hh and steamn2cao2h2 are not tested at the moment2018-04-25T22:00:35ZSimon Emmertsimplesteamaircao2h2.hh and steamn2cao2h2 are not tested at the moment@heck and I realized while implementing molarDensities that ``simplesteamaircao2h2.hh`` and ``steamn2cao2h2.hh`` are not used in any tests we could find on master. Is that correct?
Should we still keep it? If yes, we propose to use it ...@heck and I realized while implementing molarDensities that ``simplesteamaircao2h2.hh`` and ``steamn2cao2h2.hh`` are not used in any tests we could find on master. Is that correct?
Should we still keep it? If yes, we propose to use it in a test and also implement the ``molarDensity()`` in ``simplesteamaircao2h2.hh`` as it is done in !498.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/442Collection of not working tests / errors on buildbot2018-08-28T12:56:57ZSimon EmmertCollection of not working tests / errors on buildbotThis is a collection of problems we currently have on buildbot. It is collected here to help everyone in fixing the last tests.
The following fail:
**test flow
* [ ] test_2p_fracture_gravity_mpfa --> Data differs -> Dennis
* [ ] tes...This is a collection of problems we currently have on buildbot. It is collected here to help everyone in fixing the last tests.
The following fail:
**test flow
* [ ] test_2p_fracture_gravity_mpfa --> Data differs -> Dennis
* [ ] test_2p_fracture_gravity_tpfa --> Data differs in parameter: Sn, mobW, pc -> Dennis
* [ ] test_box3pwateroil -> was fixed but still fails on buildbot while passing on my notebook+desktop -> Bernd
* [ ] test_3d2pfvadaptive -> Error from solvers.hh "abs(h) < EPSILON" (see !1038)3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/363[next] Reference files for mixeddimension tests2018-02-14T16:44:13ZTimo Kochtimokoch@math.uio.no[next] Reference files for mixeddimension testsMost mixeddimension tests need reference filesMost mixeddimension tests need reference files3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/599[test] Add a test to test chemical non-equilibrium only2019-04-26T15:22:34ZKatharina Heck[test] Add a test to test chemical non-equilibrium onlyFor non-equilibrium we currently only test thermal non-equilibrium and thermal + chemical non-equilibrium. We need a test for chemical non-equilibrium onlyFor non-equilibrium we currently only test thermal non-equilibrium and thermal + chemical non-equilibrium. We need a test for chemical non-equilibrium only3.1Katharina HeckKatharina Heckhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/595Add labels to tests2019-03-01T14:09:21ZTimo Kochtimokoch@math.uio.noAdd labels to testsEvery label creates a `build_<label>_tests` CMake target. Could be convenient to build e.g. all freeflow tests.
We should decide on labels. Tests can have multiple labels. !1235 introduces the "unit" test label for unit tests. !1289 adde...Every label creates a `build_<label>_tests` CMake target. Could be convenient to build e.g. all freeflow tests.
We should decide on labels. Tests can have multiple labels. !1235 introduces the "unit" test label for unit tests. !1289 added "multidomain" label for multidomain tests, !1291 introduces "freeflow" and "rans", while all "rans" test are also "freeflow".3.1https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/650[freeflow][rans] update gridvariables in main file necessary for all rans tests2019-02-07T07:13:02ZKatharina Heck[freeflow][rans] update gridvariables in main file necessary for all rans testsWhen gridvolumevariables caching is switched on it is necessary to update the gridvariables again in the main file of the tests after the dynamic wall properties are updated in each time.
This can be done with
`// update wall propert...When gridvolumevariables caching is switched on it is necessary to update the gridvariables again in the main file of the tests after the dynamic wall properties are updated in each time.
This can be done with
`// update wall properties`
`problem->updateDynamicWallProperties(sol);`
`assembler->updateGridVariables(sol);`
There might be also be a better solution for this problem but this was the first fix @kweis found. I did not test yet if that changes any reference solutions for the rans problems but it changed a lot in a coupled test we look at.
@nedc This is the fix for the problem we had before christmas in the coupled komega test.3.1Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/760Tests for flashs don't test anything2019-10-04T11:07:26ZBeatrix BeckerTests for flashs don't test anythingThey never fail, just print an error.They never fail, just print an error.3.1https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/739Unit test for compositional flash2019-10-04T09:42:27ZBeatrix BeckerUnit test for compositional flashThere is none currentlyThere is none currently3.1https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/646Tests: Replace problem functions postTimeStep/preTimeStep2019-02-27T13:52:59ZTimo Kochtimokoch@math.uio.noTests: Replace problem functions postTimeStep/preTimeStepFunctions with such names are due to the version 2 way of implementing simulation flow control. In version 3 such functions should not exist because
* the function name doesn't say anything about what the function does
* the functionali...Functions with such names are due to the version 2 way of implementing simulation flow control. In version 3 such functions should not exist because
* the function name doesn't say anything about what the function does
* the functionality in those functions probably doesn't belong in the problem
The function might be removed by moving the functionality into the main file, or renamed to some appropriate name if the functionality really belongs to the problem (connected to BC/IC/Sources or maybe an analytical solution).3.1https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/819Add parallel test with unstructured grid2020-03-17T21:13:31ZTimo Kochtimokoch@math.uio.noAdd parallel test with unstructured grid* We need a parallel test with an unstructured grid.
* Moreover, we adjust the Richards test or add a new test in a way the there is actually significant fluxes over the process boundary.
See also #817 and fix !1862 which wasn't caught ...* We need a parallel test with an unstructured grid.
* Moreover, we adjust the Richards test or add a new test in a way the there is actually significant fluxes over the process boundary.
See also #817 and fix !1862 which wasn't caught by the current test suite.3.2https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/813[test] Unit test for VanGenuchten / Brooks-Corey material laws missing2020-03-31T09:31:36ZTimo Kochtimokoch@math.uio.no[test] Unit test for VanGenuchten / Brooks-Corey material laws missingWe should test (for raw and regularized version):
* if derivatives match numerical derivatives
* unregularized same as regularized in the non-regularized range
* endPointPc() is the same as evaluation at Sw=1
* entryPressure is the same...We should test (for raw and regularized version):
* if derivatives match numerical derivatives
* unregularized same as regularized in the non-regularized range
* endPointPc() is the same as evaluation at Sw=1
* entryPressure is the same as evaluation at Sw=1
* test against some precomputed reference values (a good regression test)
* test eff to abs law
add more invariants that could be unit tested if you have an idea.3.2https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/682Test tabulation doesn't actually test anything2019-12-20T12:43:35ZTimo Kochtimokoch@math.uio.noTest tabulation doesn't actually test anythingNo matter if success is false or true the test always returns 0 exit code.No matter if success is false or true the test always returns 0 exit code.3.2Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/753[tests] Newon line search not tested in test suite2019-11-08T09:42:13ZTimo Kochtimokoch@math.uio.no[tests] Newon line search not tested in test suiteWe could just enable if for some test, ideally where it also improves convergence.We could just enable if for some test, ideally where it also improves convergence.3.2Roman WinterRoman Winterhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/752[test] Mpfa not tested in parallel2019-10-31T07:24:25ZTimo Kochtimokoch@math.uio.no[test] Mpfa not tested in parallelWe could add the richards parallel test for mpfa too. Solution should be identical to tpfa.We could add the richards parallel test for mpfa too. Solution should be identical to tpfa.3.2Roman WinterRoman Winterhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/751[test] Unit test intersectspointgeometry incomplete2020-04-04T18:09:54ZTimo Kochtimokoch@math.uio.no[test] Unit test intersectspointgeometry incompletepoint-tetrahedron and point-pyramid is not tested
Maybe a dedicated unit test for this header would be good and easy to implement.point-tetrahedron and point-pyramid is not tested
Maybe a dedicated unit test for this header would be good and easy to implement.3.2Tim JupeTim Jupehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/415Implement better tests for freeflow2020-03-25T14:54:40ZKilian WeishauptImplement better tests for freeflow__This isssue has been split into #839 #838 #837 and will be closed.__
There is a myriad of benchmarks, numerical and analytical solutions for free-flow problems. We should incorporate more of them in our free-flow tests. Thomas and ...__This isssue has been split into #839 #838 #837 and will be closed.__
There is a myriad of benchmarks, numerical and analytical solutions for free-flow problems. We should incorporate more of them in our free-flow tests. Thomas and Christoph had some of them for their staggered grid implementation.
Currently, there are two test which come with an analytical solution:
`test_donea` and `test_kovasznay`
Here a some ideas what could be added:
- [ ] Analytical solution for simple stationary 2d channel test (test already exists)
- [ ] [Ghia 1982](https://ac.els-cdn.com/0021999182900584/1-s2.0-0021999182900584-main.pdf?_tid=e9f7486c-d67c-11e7-96b6-00000aab0f26&acdnat=1512121945_6871c2de3e7d5699f53ef718416dc341)
- [x] Transient flow field test with analytical solution
- [ ] Transient flow field test: lid driven cavity
- [ ] Analytical solution for diffusion (mass/energy) tests
- [x] Ensure same results for mass and mole formulation (see !950)
More suggestions welcome!
- [ ] Improve the description of the tests and the help-message
Could be a job for a HiWi.3.2Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/915[test][cleanup] Remove or reduce exception handlers2020-10-02T08:12:11ZTimo Kochtimokoch@math.uio.no[test][cleanup] Remove or reduce exception handlersWe usually have a list of exception handlers like this at the end of each main file
```cpp
catch (Dumux::ParameterException &e)
{
std::cerr << std::endl << e << " ---> Abort!" << std::endl;
return 1;
}
catch (Dune::DGFException ...We usually have a list of exception handlers like this at the end of each main file
```cpp
catch (Dumux::ParameterException &e)
{
std::cerr << std::endl << e << " ---> Abort!" << std::endl;
return 1;
}
catch (Dune::DGFException & e)
{
std::cerr << "DGF exception thrown (" << e <<
"). Most likely, the DGF file name is wrong "
"or the DGF file is corrupted, "
"e.g. missing hash at end of file or wrong number (dimensions) of entries."
<< " ---> Abort!" << std::endl;
return 2;
}
catch (Dune::Exception &e)
{
std::cerr << "Dune reported error: " << e << " ---> Abort!" << std::endl;
return 3;
}
catch (...)
{
std::cerr << "Unknown exception thrown! ---> Abort!" << std::endl;
return 4;
}
```
Small cleanup point:
* Catch all exceptions as `const&`
Actual discussion points:
* The default terminate handler usually provides the exception message as well so manually catching exception is not necessary
* In case of the `Dune::DGFException` we actually add more information so that is a sensible use of the exception handler. However not every test will have the chance to throw a `Dune::DGFException` because not every test uses DGF mesh files.
* In the other cases we just print the exception message which is what the default handler does anyway on most system AFAIK
* Catching `(...)` suppresses the exception message completely. This is a code smell. When such an exception occurs you have to manually remove the line to be able to read the exception message.
Suggestions:
* Try what is printed when we remove exception handlers completely (probably we don't need handlers at all for tests)
* Think about how to reduce handlers to a minimum
* Remove default catch case `(...)`
Note:
These comments are specifically for tests. If you have some Dumux application you might want to add exception handlers to gracefully exit out of an exception situation.3.3Mathis KelmMathis Kelm