dumux-repositories issueshttps://git.iws.uni-stuttgart.de/groups/dumux-repositories/-/issues2018-11-27T08:06:33Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/582`1pnc` disregards `useMoles` in the choice of primary variables2018-11-27T08:06:33ZBernd Flemisch`1pnc` disregards `useMoles` in the choice of primary variablesThe `1pnc` model uses mole fractions as primary variables regardless of the value of `useMoles`. So if `useMoles` is set to `false`, one has to set Dirichlet conditions still in terms of moles, while sources and fluxes expect masses.
Sh...The `1pnc` model uses mole fractions as primary variables regardless of the value of `useMoles`. So if `useMoles` is set to `false`, one has to set Dirichlet conditions still in terms of moles, while sources and fluxes expect masses.
Should we drop the `useMoles` switch or implement it properly?3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/907[1p][test] Anisotropic convergence test on unstructured grid2020-08-19T09:08:52ZMartin Schneider[1p][test] Anisotropic convergence test on unstructured gridIt seems that there is no 1p test that checks the convergence rates on unstructured grids and for full tensors. When implementing new schemes, it would be nice to have such a test.It seems that there is no 1p test that checks the convergence rates on unstructured grids and for full tensors. When implementing new schemes, it would be nice to have such a test.3.4https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/5222p1c primary variable switch and mixed wettability concept not consistent wit...2018-08-16T08:54:19ZTimo Kochtimokoch@math.uio.no2p1c primary variable switch and mixed wettability concept not consistent with other 2p compositional modelsThe 2p1c model is not adapted (at least in some parts) to the new mixed-wettability concept for two-phase flow.The 2p1c model is not adapted (at least in some parts) to the new mixed-wettability concept for two-phase flow.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/488[2p2c] Remove useKelvoneq from modeltraits2018-05-08T10:40:22ZTimo Kochtimokoch@math.uio.no[2p2c] Remove useKelvoneq from modeltraitsThis is now directly set for the fluid system, and should be unused in the volvarsThis is now directly set for the fluid system, and should be unused in the volvars3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/7092p2c water-air and fuelcell/remediation tests fail due to !16152019-05-28T08:54:20ZSimon Emmert2p2c water-air and fuelcell/remediation tests fail due to !1615The following tests fail on buildbot due to the changes in the viscosity calculation from !1615
dumux (some have a singular matrix and do not converge at all)
```
119 - test_2p2cni_waterair_box (Failed)
120 - test_2p2cni_waterair_buoyan...The following tests fail on buildbot due to the changes in the viscosity calculation from !1615
dumux (some have a singular matrix and do not converge at all)
```
119 - test_2p2cni_waterair_box (Failed)
120 - test_2p2cni_waterair_buoyancy_box (Failed)
121 - test_2p2cni_waterair_tpfa (Failed)
```
dumux-lecture (here only the reference solution does not match anymore)
```
11 - fuelcell (Failed)
22 - remediationscenariosexercise (Failed)
```https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/7862p incompressible box test doesn't work in parallel2019-11-13T16:47:45ZBernd Flemisch2p incompressible box test doesn't work in parallelThe Newton solver doesn't converge when running on two processes.The Newton solver doesn't converge when running on two processes.3.2Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/658[2pncmin] precipitation of NaCl from the gas phase2019-03-27T15:43:22ZTheresa Schollenberger[2pncmin] precipitation of NaCl from the gas phaseA value is set for the source term of precipitated salt in gas, which is not physical. The suggestion is that this should balance out a fugacity of NaCl which was original nonequal to zero. However, the fugacity of NaCl was set to zero i...A value is set for the source term of precipitated salt in gas, which is not physical. The suggestion is that this should balance out a fugacity of NaCl which was original nonequal to zero. However, the fugacity of NaCl was set to zero in commit:9925d2d3 so this part of the source term has to be removed now.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/4943p immiscible fluid system has dune throw in constexpr function2018-05-16T13:21:25ZTimo Kochtimokoch@math.uio.no3p immiscible fluid system has dune throw in constexpr function3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/437!734 Introduces bug for adaptive grids2018-02-05T11:56:47ZTimo Kochtimokoch@math.uio.no!734 Introduces bug for adaptive gridsThen stencil sizes are fixed since this merge and all adaptive tests run into segfaults because the maximum sizes are not big enough anymore..Then stencil sizes are fixed since this merge and all adaptive tests run into segfaults because the maximum sizes are not big enough anymore..3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/711Access to problem quantities (like thermal conductivity) model dependent2020-03-26T18:18:55ZAlexander JaustAccess to problem quantities (like thermal conductivity) model dependentI observed that it is problem-/model-dependent how to obtain the thermal conductivity. This make it hard to reuse some of my functions with different problems/models.
- Would it be possible to unify the interface?
- Is there a (smart) ...I observed that it is problem-/model-dependent how to obtain the thermal conductivity. This make it hard to reuse some of my functions with different problems/models.
- Would it be possible to unify the interface?
- Is there a (smart) way to generalize functions that should work for different problems/models?
## Short description
The interface to obtain model properties is not unique. Obtaining the thermal conductivity `lambda` looks different for different types of problems used.
- Using `SolidEnergy` model: `lambda = ThermalConductivityModel::effectiveThermalConductivity(volVars,problem.spatialParams(),element,fvGeometry,scv)`
- Using `NavierStokesNI` model: `lambda = volVars.effectiveThermalConductivity()`
In my case, this makes is hard to reuse an already implemented function. Moreover, it does not feel intuitive that the interface to obtain the conductivity differs (that much) between two physical models.
## Longer description
Kilian and me have been recently worked on a routine that constructs the temperature on a boundary. It basically gets a heat flux `Q` on the face of an element and the temperature `T_cc` at the cell center. Together with the thermal conductivity `lambda` and the distance from the cell center to the face `distance` obtain the temperature on the face `T_face` from the following formula:
```
Q = - lambda ( T_face - T_center ) / distance
=> T_face = - Q * distance / lambda + T_center
```
It has been implement once for a heat equation problem that inherits from `SolidEnergy`. In this case heat conductivity is obtained via `ThermalConductivityModel::effectiveThermalConductivity`. In my particular case it looks like that:
```c++
const Scalar lambda = ThermalConductivityModel::effectiveThermalConductivity(volVars,
problem.spatialParams(),
element,
fvGeometry,
scv);
```
Now, I wanted to reuse the function for a Navier-Stokes based problem that inherits `NavierStokesNI`. I tried reuse the function we had already written, but this fails since the heat conductivity has to be obtained via the `effectiveThermalConductivity` member function of an object of type `ElementVolumeVariables`. In my case it looks like:
```c++
const Scalar insideLambda = volVars.effectiveThermalConductivity();
```
Due to that I had to implement the same function twice which I would like to avoid3.2Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux-website/-/issues/30Adapt design of mailing list page2020-06-25T10:28:39ZKilian WeishauptAdapt design of mailing list pagehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux-lecture/-/issues/21Adapt new spatial params interface2020-11-05T16:51:29ZKilian WeishauptAdapt new spatial params interfaceSee https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1607
Remove deprecation warnings
* [x] efm_1p2c
* [x] efm_2p
* [x] mhs_groundwater
* [x] mm_co2plume
* [x] mm_columnxylene
* [x] mm_convectivemixing
* [x] m...See https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1607
Remove deprecation warnings
* [x] efm_1p2c
* [x] efm_2p
* [x] mhs_groundwater
* [x] mm_co2plume
* [x] mm_columnxylene
* [x] mm_convectivemixing
* [x] mm_fractures
* [x] mm_sagd
* [x] mm_sagd_cyc
* [x] mm_sagd_cyc_hyst
* [x] mm_naplinfiltration_3p
* [x] mm_naplinfiltration_3p3c
* [x] mm_remediationscenarios
* [x] mm_henryproblem
* [x] mm_heatpipe
* [x] mm_buckleyleverett
* [x] mm_mcwhorter
* [x] mm_fuelcell3.3Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux-website/-/issues/8Add a demonstrater web-app on the website2020-09-10T21:29:11ZTimo Kochtimokoch@math.uio.noAdd a demonstrater web-app on the websiteTo be developed within the SusI project.To be developed within the SusI project.https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/836Add assert in chem. non-equilibrium that it only works for numPhases > 12020-03-26T19:06:52ZTimo Kochtimokoch@math.uio.noAdd assert in chem. non-equilibrium that it only works for numPhases > 13.2Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux-website/-/issues/15Add badges for better visibility2020-06-30T11:03:47ZTimo Kochtimokoch@math.uio.noAdd badges for better visibilityMany software related thing can be made accessible with badges, see e.g. ![](https://img.shields.io/badge/license-GPL%20%3E%3D%203-green.svg) `https://img.shields.io/badge/license-GPL%20%3E%3D%203-green.svg`Many software related thing can be made accessible with badges, see e.g. ![](https://img.shields.io/badge/license-GPL%20%3E%3D%203-green.svg) `https://img.shields.io/badge/license-GPL%20%3E%3D%203-green.svg`https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/668Add brief description of staggered higher order feature to changelog2019-04-30T13:28:20ZTimo Kochtimokoch@math.uio.noAdd brief description of staggered higher order feature to changelogprobably after #663 #664 have been addressedprobably after #663 #664 have been addressed3.1Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1007Add changelog entry for gasviscosity update2021-04-06T14:07:34ZTimo Kochtimokoch@math.uio.noAdd changelog entry for gasviscosity updateIt slightly changes results so we should mention this in the changelog, maybe with a remark in which ranges we expect a better approximation now.It slightly changes results so we should mention this in the changelog, maybe with a remark in which ranges we expect a better approximation now.3.4https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/549Add comparisons to analytical solutions for Richards model2021-02-25T20:50:52ZTimo Kochtimokoch@math.uio.noAdd comparisons to analytical solutions for Richards modelThere are some contributed Richards benchmark in dumux-appl/dumux-rootgrowth.
I would be nice to add the analytical solutions (which are not in C++ now) and add tests to dumux.There are some contributed Richards benchmark in dumux-appl/dumux-rootgrowth.
I would be nice to add the analytical solutions (which are not in C++ now) and add tests to dumux.3.4https://git.iws.uni-stuttgart.de/dumux-repositories/dumux-website/-/issues/49Add documentation on website on how to install external dependencies so that ...2022-03-30T07:33:06ZTimo Kochtimokoch@math.uio.noAdd documentation on website on how to install external dependencies so that Dune finds themSome explanations on build system, how to work with dunecontrol, on the website would be nice.Some explanations on build system, how to work with dunecontrol, on the website would be nice.3.5Leopold StadlerLeopold Stadlerhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1100Add documentation on website on how to install external dependencies so that ...2022-02-23T18:20:51ZTimo Kochtimokoch@math.uio.noAdd documentation on website on how to install external dependencies so that Dune finds themSome explanations on build system, how to work with dunecontrol, on the website would be nice.Some explanations on build system, how to work with dunecontrol, on the website would be nice.3.5Leopold StadlerLeopold Stadler