frackit issueshttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues2020-10-27T09:20:01Zhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/6Add support for polygons2020-10-27T09:20:01ZDennis GläserAdd support for polygonsThe strategy in the `QuadrilateralSampler` could/should be improved, as currently, non-convex quadrilaterals can result from sampling. This can cause the `Line-PlanarGeometry` algorithm to fail, as it expects convex planar geometries.
1...The strategy in the `QuadrilateralSampler` could/should be improved, as currently, non-convex quadrilaterals can result from sampling. This can cause the `Line-PlanarGeometry` algorithm to fail, as it expects convex planar geometries.
1. We could substitute the algorithm in `QuadrilateralSampler` by a generic algorithm to sample convex polygons. Quadrilaterals could then be a special case of polygon.
2. We should either support non-convex planar geometries, or rename the function and/or variables such that it is clear that the algorithm is for convex shapes.Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/14Restructure modules in python bindings2020-11-05T11:58:59ZDennis GläserRestructure modules in python bindingsWithin the c++ core of `frackit`, distribution of these functionalities over different folders seems justified, especially because the geometry folder is already quite full. In the Python bindings, however, it seems better to not have to...Within the c++ core of `frackit`, distribution of these functionalities over different folders seems justified, especially because the geometry folder is already quite full. In the Python bindings, however, it seems better to not have to write:
```python
from frackit.geometry import Cylinder
from frackit.magnitude import computeMagnitude
cyl = Cylinder(0.5, 1.0)
cylVol = computeMagnitude(cyl)
```
Since length/area/volume computation is an operation on geometries, within python I guess it is nicer to write:
```python
from frackit.geometry import Cylinder, computeMagnitude
cyl = Cylinder(0.5, 1.0)
cylVol = computeMagnitude(cyl)
```
That is, the geometry module contains the functions on magnitude computation. The "drawback" is, that `computeMagnitude` also works on wrappers around OpenCascade shapes, but these wrappers are not part of the `geometry` module yet -> they are part of `occutilities`. `intersection` is currently also its own module.
The organization of the python modules should be rethought, either intersection stuff should also be moved to geometry, or `magnitude`, `area`, `volume`, `length`, 'distance` etc should be collected in another module.1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/7Add example for alternative way of network generation2020-11-06T19:06:53ZDennis GläserAdd example for alternative way of network generationWith the tools at hand, one can also incrementally generate a network instead of the way that is currently part of the examples. We should add an example application for such an approach and possible extend the paper (if not accepted yet).With the tools at hand, one can also incrementally generate a network instead of the way that is currently part of the examples. We should add an example application for such an approach and possible extend the paper (if not accepted yet).1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/9add example using `PolygonSampler`2020-11-06T19:06:53ZDennis Gläseradd example using `PolygonSampler`1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/16Let status have multiple rejected counters2020-12-02T21:23:19ZDennis GläserLet status have multiple rejected countersIt could be nice if the rejected counters of `SamplingStatus` could be increased with a given tag or some type of information. This could be useful to print a comprehensive message after network generation, containing statistics on which...It could be nice if the rejected counters of `SamplingStatus` could be increased with a given tag or some type of information. This could be useful to print a comprehensive message after network generation, containing statistics on which type of rejections occurred.1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/22Make `SamplingStatus` work without target number of entities2020-12-10T15:55:50ZDennis GläserMake `SamplingStatus` work without target number of entitiesThe `SamplingStatus` class currently expects a target number of entities to be defined, otherwise the status output contains `nan`s. This should be made more generic in case a user wants to define a custom stopping criterion.The `SamplingStatus` class currently expects a target number of entities to be defined, otherwise the status output contains `nan`s. This should be made more generic in case a user wants to define a custom stopping criterion.1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/17Mesh size definition per sub-domain2020-12-10T16:10:30ZDennis GläserMesh size definition per sub-domainThe `GmshWriter` could be improved with respect to the mesh sizes used. It would be good if one could use different mesh sizes in different volumes, maybe even on individual entities...The question then is in which order the definitions ...The `GmshWriter` could be improved with respect to the mesh sizes used. It would be good if one could use different mesh sizes in different volumes, maybe even on individual entities...The question then is in which order the definitions are executed, as there will be overlapping points...1.2Dennis GläserDennis Gläser