frackit issueshttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues2020-12-10T15:35:16Zhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/25Add short unit tests for iterators2020-12-10T15:35:16ZDennis GläserAdd short unit tests for iterators1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/24Add junit output to test pipelines2020-12-10T08:16:22ZDennis GläserAdd junit output to test pipelines1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/23Introduce graph data structures and algorithms2020-12-10T08:16:43ZDennis GläserIntroduce graph data structures and algorithmsTranslation of entity networks into graphs would be useful for efficient analysis of the network characteristics based on algorithms on graphs.Translation of entity networks into graphs would be useful for efficient analysis of the network characteristics based on algorithms on graphs.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/21box class constructor allows misuse2020-12-10T08:16:56ZDennis Gläserbox class constructor allows misuseInstead of providing the min/max coordinates, it would be better to require the minimum coordinates and the dx, dy, dz values. In this case, the checks for degenerated boxes would become obsolete in the constructor, and would not allow m...Instead of providing the min/max coordinates, it would be better to require the minimum coordinates and the dx, dy, dz values. In this case, the checks for degenerated boxes would become obsolete in the constructor, and would not allow misuse of the class.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/20generalize box class2020-12-10T08:17:04ZDennis Gläsergeneralize box classThe `Box` class is currently actually a bounding box. In addition, a `BoundingBox` type exists which is only an alias for `Box`. The `Box` class should be generalized such that it can be oriented arbitrarily in space, while `BoundingBox`...The `Box` class is currently actually a bounding box. In addition, a `BoundingBox` type exists which is only an alias for `Box`. The `Box` class should be generalized such that it can be oriented arbitrarily in space, while `BoundingBox` implements the current `Box`.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/19add geothermal example application2020-12-10T08:17:12ZDennis Gläseradd geothermal example applicationIt would be nice to have an example application with injection & extraction wells and a fracture network in between them.It would be nice to have an example application with injection & extraction wells and a fracture network in between them.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/18unify style of geometric algorithms2020-12-10T08:17:20ZDennis Gläserunify style of geometric algorithmsFor intersection angle computations, there is the `IntersectionAngle` class which contains the algorithms, while for `computeMagnitude` and `computeDistance` they are inside the free functions. This should probably be unified.
The advan...For intersection angle computations, there is the `IntersectionAngle` class which contains the algorithms, while for `computeMagnitude` and `computeDistance` they are inside the free functions. This should probably be unified.
The advantage of an "algorithm class" is that it can be used as driver in some other place, and is thus modifiable by inheritance and modification of specific details.
One solution could be to add a free function
```cpp
template<class Geo1, class Geo2, class Intersection, class AngleEngine = IntersectionAngle>
ctype computeAngle(const Geo1& geo1, const Geo2& geo2, const Intersection& is)
{ return AngleEngine()(geo1, geo2, is); }
```
where the engine defaults to the standard engine. Similarly, we could put `computeMagnitude` etc, also in "algorithm classes" and let the free functions have an additional template argument for the driver, with default.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/15Collect intersection traits2020-12-10T08:17:29ZDennis GläserCollect intersection traitsSeveral algorithms for geometry pairs forward to the same basic algorithm, e.g., `quad-quad` forwards to `planarGeometry-planarGeometry`. SHould there be corresponding intersection traits from which the traits for those pairs that will u...Several algorithms for geometry pairs forward to the same basic algorithm, e.g., `quad-quad` forwards to `planarGeometry-planarGeometry`. SHould there be corresponding intersection traits from which the traits for those pairs that will use the algorithm inherit?
Moreover, currently `Quad-Disk` and `Quad-Quad` return the same variant of intersections, describing face intersections by `TopoDS_Face`. However, for linear geometries the result is a `Polygon` and can be described more detailed by the internal geometry. Then, this would mean different traits and the algorithms would have to be split, or, it would have to be made flexible enough to handle both cases somehow...1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/13flag `-march=native` leads to less precision and failing of `test_box`2020-11-04T17:42:59ZDennis Gläserflag `-march=native` leads to less precision and failing of `test_box`The test `test_box` fails since !145 due to the introduction of the compiler flag `-march=native`. What fails is the volume comparison of two boxes that are constructed with different arguments (min/max coords vs lowerLeft/upperRight cor...The test `test_box` fails since !145 due to the introduction of the compiler flag `-march=native`. What fails is the volume comparison of two boxes that are constructed with different arguments (min/max coords vs lowerLeft/upperRight corners), but yield the same box.
Checking equality of the resulting volumes leads to a precision of `1e-15`, but the epsilon is the default epsilon^3, and thus, in the order of `1e-24`. Maybe the precision is ok, but then the question is how to choose adequate epsilons for volumes...Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/10Introduce test suite for Python bindings2020-12-10T08:18:33ZDennis GläserIntroduce test suite for Python bindings1.3