frackit issueshttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues2021-06-10T05:15:40Zhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/26No rule to make target "build_example_applications"2021-06-10T05:15:40ZRanjeetNo rule to make target "build_example_applications"Hi,
I am trying to use frackit through docker but I am getting this error:
![image](/uploads/0a11909214609547862a8249beb6cd46/image.png)
![image](/uploads/e7dc210f66c3077d427ae2a3b196e3c8/image.png)
Would you tell me how to fix this?Hi,
I am trying to use frackit through docker but I am getting this error:
![image](/uploads/0a11909214609547862a8249beb6cd46/image.png)
![image](/uploads/e7dc210f66c3077d427ae2a3b196e3c8/image.png)
Would you tell me how to fix this?https://git.iws.uni-stuttgart.de/tools/frackit/-/issues/25Add short unit tests for iterators2020-12-10T15:35:16ZDennis GläserAdd short unit tests for iterators1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/24Add junit output to test pipelines2020-12-10T08:16:22ZDennis GläserAdd junit output to test pipelines1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/23Introduce graph data structures and algorithms2020-12-10T08:16:43ZDennis GläserIntroduce graph data structures and algorithmsTranslation of entity networks into graphs would be useful for efficient analysis of the network characteristics based on algorithms on graphs.Translation of entity networks into graphs would be useful for efficient analysis of the network characteristics based on algorithms on graphs.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/22Make `SamplingStatus` work without target number of entities2020-12-10T15:55:50ZDennis GläserMake `SamplingStatus` work without target number of entitiesThe `SamplingStatus` class currently expects a target number of entities to be defined, otherwise the status output contains `nan`s. This should be made more generic in case a user wants to define a custom stopping criterion.The `SamplingStatus` class currently expects a target number of entities to be defined, otherwise the status output contains `nan`s. This should be made more generic in case a user wants to define a custom stopping criterion.1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/21box class constructor allows misuse2020-12-10T08:16:56ZDennis Gläserbox class constructor allows misuseInstead of providing the min/max coordinates, it would be better to require the minimum coordinates and the dx, dy, dz values. In this case, the checks for degenerated boxes would become obsolete in the constructor, and would not allow m...Instead of providing the min/max coordinates, it would be better to require the minimum coordinates and the dx, dy, dz values. In this case, the checks for degenerated boxes would become obsolete in the constructor, and would not allow misuse of the class.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/20generalize box class2020-12-10T08:17:04ZDennis Gläsergeneralize box classThe `Box` class is currently actually a bounding box. In addition, a `BoundingBox` type exists which is only an alias for `Box`. The `Box` class should be generalized such that it can be oriented arbitrarily in space, while `BoundingBox`...The `Box` class is currently actually a bounding box. In addition, a `BoundingBox` type exists which is only an alias for `Box`. The `Box` class should be generalized such that it can be oriented arbitrarily in space, while `BoundingBox` implements the current `Box`.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/19add geothermal example application2020-12-10T08:17:12ZDennis Gläseradd geothermal example applicationIt would be nice to have an example application with injection & extraction wells and a fracture network in between them.It would be nice to have an example application with injection & extraction wells and a fracture network in between them.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/18unify style of geometric algorithms2020-12-10T08:17:20ZDennis Gläserunify style of geometric algorithmsFor intersection angle computations, there is the `IntersectionAngle` class which contains the algorithms, while for `computeMagnitude` and `computeDistance` they are inside the free functions. This should probably be unified.
The advan...For intersection angle computations, there is the `IntersectionAngle` class which contains the algorithms, while for `computeMagnitude` and `computeDistance` they are inside the free functions. This should probably be unified.
The advantage of an "algorithm class" is that it can be used as driver in some other place, and is thus modifiable by inheritance and modification of specific details.
One solution could be to add a free function
```cpp
template<class Geo1, class Geo2, class Intersection, class AngleEngine = IntersectionAngle>
ctype computeAngle(const Geo1& geo1, const Geo2& geo2, const Intersection& is)
{ return AngleEngine()(geo1, geo2, is); }
```
where the engine defaults to the standard engine. Similarly, we could put `computeMagnitude` etc, also in "algorithm classes" and let the free functions have an additional template argument for the driver, with default.1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/17Mesh size definition per sub-domain2020-12-10T16:10:30ZDennis GläserMesh size definition per sub-domainThe `GmshWriter` could be improved with respect to the mesh sizes used. It would be good if one could use different mesh sizes in different volumes, maybe even on individual entities...The question then is in which order the definitions ...The `GmshWriter` could be improved with respect to the mesh sizes used. It would be good if one could use different mesh sizes in different volumes, maybe even on individual entities...The question then is in which order the definitions are executed, as there will be overlapping points...1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/16Let status have multiple rejected counters2020-12-02T21:23:19ZDennis GläserLet status have multiple rejected countersIt could be nice if the rejected counters of `SamplingStatus` could be increased with a given tag or some type of information. This could be useful to print a comprehensive message after network generation, containing statistics on which...It could be nice if the rejected counters of `SamplingStatus` could be increased with a given tag or some type of information. This could be useful to print a comprehensive message after network generation, containing statistics on which type of rejections occurred.1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/15Collect intersection traits2020-12-10T08:17:29ZDennis GläserCollect intersection traitsSeveral algorithms for geometry pairs forward to the same basic algorithm, e.g., `quad-quad` forwards to `planarGeometry-planarGeometry`. SHould there be corresponding intersection traits from which the traits for those pairs that will u...Several algorithms for geometry pairs forward to the same basic algorithm, e.g., `quad-quad` forwards to `planarGeometry-planarGeometry`. SHould there be corresponding intersection traits from which the traits for those pairs that will use the algorithm inherit?
Moreover, currently `Quad-Disk` and `Quad-Quad` return the same variant of intersections, describing face intersections by `TopoDS_Face`. However, for linear geometries the result is a `Polygon` and can be described more detailed by the internal geometry. Then, this would mean different traits and the algorithms would have to be split, or, it would have to be made flexible enough to handle both cases somehow...1.3Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/14Restructure modules in python bindings2020-11-05T11:58:59ZDennis GläserRestructure modules in python bindingsWithin the c++ core of `frackit`, distribution of these functionalities over different folders seems justified, especially because the geometry folder is already quite full. In the Python bindings, however, it seems better to not have to...Within the c++ core of `frackit`, distribution of these functionalities over different folders seems justified, especially because the geometry folder is already quite full. In the Python bindings, however, it seems better to not have to write:
```python
from frackit.geometry import Cylinder
from frackit.magnitude import computeMagnitude
cyl = Cylinder(0.5, 1.0)
cylVol = computeMagnitude(cyl)
```
Since length/area/volume computation is an operation on geometries, within python I guess it is nicer to write:
```python
from frackit.geometry import Cylinder, computeMagnitude
cyl = Cylinder(0.5, 1.0)
cylVol = computeMagnitude(cyl)
```
That is, the geometry module contains the functions on magnitude computation. The "drawback" is, that `computeMagnitude` also works on wrappers around OpenCascade shapes, but these wrappers are not part of the `geometry` module yet -> they are part of `occutilities`. `intersection` is currently also its own module.
The organization of the python modules should be rethought, either intersection stuff should also be moved to geometry, or `magnitude`, `area`, `volume`, `length`, 'distance` etc should be collected in another module.1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/13flag `-march=native` leads to less precision and failing of `test_box`2020-11-04T17:42:59ZDennis Gläserflag `-march=native` leads to less precision and failing of `test_box`The test `test_box` fails since !145 due to the introduction of the compiler flag `-march=native`. What fails is the volume comparison of two boxes that are constructed with different arguments (min/max coords vs lowerLeft/upperRight cor...The test `test_box` fails since !145 due to the introduction of the compiler flag `-march=native`. What fails is the volume comparison of two boxes that are constructed with different arguments (min/max coords vs lowerLeft/upperRight corners), but yield the same box.
Checking equality of the resulting volumes leads to a precision of `1e-15`, but the epsilon is the default epsilon^3, and thus, in the order of `1e-24`. Maybe the precision is ok, but then the question is how to choose adequate epsilons for volumes...Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/12Let constraints return some structure that allows to check which constraint w...2020-12-02T21:23:19ZDennis GläserLet constraints return some structure that allows to check which constraint was violated1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/11move dimension and ctype helper structs into folder geometryutilities2020-11-05T19:47:01ZDennis Gläsermove dimension and ctype helper structs into folder geometryutilities1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/10Introduce test suite for Python bindings2020-12-10T08:18:33ZDennis GläserIntroduce test suite for Python bindings1.3https://git.iws.uni-stuttgart.de/tools/frackit/-/issues/9add example using `PolygonSampler`2020-11-06T19:06:53ZDennis Gläseradd example using `PolygonSampler`1.2Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/8Avoid use of deprecated `QuadrilateralSampler` in examples and change explana...2020-10-27T13:38:26ZDennis GläserAvoid use of deprecated `QuadrilateralSampler` in examples and change explanations in readmes accordinglyDennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/tools/frackit/-/issues/7Add example for alternative way of network generation2020-11-06T19:06:53ZDennis GläserAdd example for alternative way of network generationWith the tools at hand, one can also incrementally generate a network instead of the way that is currently part of the examples. We should add an example application for such an approach and possible extend the paper (if not accepted yet).With the tools at hand, one can also incrementally generate a network instead of the way that is currently part of the examples. We should add an example application for such an approach and possible extend the paper (if not accepted yet).1.2Dennis GläserDennis Gläser