Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux-course dumux-course
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumux-coursedumux-course
  • Merge requests
  • !77

Towards a more consistent DUMUX course for version 3.1

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Johannes Hommel requested to merge fix/towardsAMoreConsistentDumuxCourseFor3.1 into master Sep 18, 2019
  • Overview 2
  • Commits 12
  • Pipelines 0
  • Changes 107

All issues that came up during the dumux course in Tunis or which I noticed:

  • exercises-properties: A "TODO" component might be added in neumann() to be consistent with other exercises

  • exercises-runtimeparams: update Readme.md. The default input file is now params.input, not "executablename.input", or more correctly, both are working by default.

  • exercise-coupling-ff-pm general: Many of the files do not contain "TODO" comments where changes need to be made in the fashion of the other exercises.

  • exercise-coupling-ff-pm (a: interface and b,c): warning about neumannFlux being deprecated, probably should be updated.

  • exercise-coupling-ff-pm interface: I guess that the tasks in the Readme.md should include removing the initial velocity field in initialAtPos().

  • exercise-coupling-ff-pm (b: models): the 2p2c model's indices.hh is referenced in the Readme.md. However, this does not seem to exist.

  • exercise-biomineralization: The line numbers in Readme.md do not match the current code. eps_ is added both for the upper and lower injection area boundary. A comment in Readme.md should be added that NH4 is ignored in the simplified biomineralization model and thus also the chemistry.

  • general comment: there is always the "property macro deprecation warning" when compiling any of the course exercises. Are the exercises free of the property macros?

  • general comment: The names of the exercises' executables could be more consistent, e.g.: ex_coupling_* vs exercisebiomin

  • general comment: deprecation warnings for gravity

Resolves #21 (closed)

Edited Oct 02, 2019 by Katharina Heck
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/towardsAMoreConsistentDumuxCourseFor3.1