Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
dumux
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
dumux-repositories
dumux
Commits
12492916
Commit
12492916
authored
6 years ago
by
Simon Emmert
Browse files
Options
Downloads
Patches
Plain Diff
[fluidsystem] fix h2oheavyoil henryCoefficient, doxygen, remove deprecated swrx in spatialparams
parent
aba17f95
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!1111
Fix/h2oheavyoil
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
dumux/material/fluidsystems/h2oheavyoil.hh
+22
-15
22 additions, 15 deletions
dumux/material/fluidsystems/h2oheavyoil.hh
test/porousmediumflow/3pwateroil/implicit/3pwateroilsagdspatialparams.hh
+0
-2
0 additions, 2 deletions
...umflow/3pwateroil/implicit/3pwateroilsagdspatialparams.hh
with
22 additions
and
17 deletions
dumux/material/fluidsystems/h2oheavyoil.hh
+
22
−
15
View file @
12492916
...
@@ -37,8 +37,9 @@ namespace Dumux {
...
@@ -37,8 +37,9 @@ namespace Dumux {
namespace
FluidSystems
{
namespace
FluidSystems
{
/*!
/*!
* \brief A compositional fluid with water and heavy oil
* \ingroup Fluidsystems
* components in both, the liquid and the gas phase.
* \brief A compositional fluid system with water and heavy oil
* components in both the liquid and the gas phase.
*/
*/
template
<
class
Scalar
,
template
<
class
Scalar
,
class
H2OType
=
Dumux
::
Components
::
TabulatedComponent
<
Dumux
::
Components
::
H2O
<
Scalar
>
>
>
class
H2OType
=
Dumux
::
Components
::
TabulatedComponent
<
Dumux
::
Components
::
H2O
<
Scalar
>
>
>
...
@@ -355,7 +356,8 @@ public:
...
@@ -355,7 +356,8 @@ public:
DUNE_THROW
(
Dune
::
InvalidStateException
,
"non-existent diffusion coefficient for phase index "
<<
phaseIdx
);
DUNE_THROW
(
Dune
::
InvalidStateException
,
"non-existent diffusion coefficient for phase index "
<<
phaseIdx
);
}
}
/* Henry coefficients
/*!
* \brief Henry coefficients \f$[N/m^2]\f$ of a component in a phase.
*/
*/
template
<
class
FluidState
>
template
<
class
FluidState
>
static
Scalar
henryCoefficient
(
const
FluidState
&
fluidState
,
static
Scalar
henryCoefficient
(
const
FluidState
&
fluidState
,
...
@@ -366,20 +368,20 @@ public:
...
@@ -366,20 +368,20 @@ public:
assert
(
0
<=
compIdx
&&
compIdx
<
numComponents
);
assert
(
0
<=
compIdx
&&
compIdx
<
numComponents
);
const
Scalar
T
=
fluidState
.
temperature
(
phaseIdx
);
const
Scalar
T
=
fluidState
.
temperature
(
phaseIdx
);
const
Scalar
p
=
fluidState
.
pressure
(
phaseIdx
);
if
(
compIdx
==
NAPLIdx
&&
phaseIdx
==
wPhaseIdx
)
if
(
compIdx
==
NAPLIdx
&&
phaseIdx
==
wPhaseIdx
)
return
Dumux
::
BinaryCoeff
::
H2O_HeavyOil
::
henryOilInWater
(
T
)
/
p
;
return
Dumux
::
BinaryCoeff
::
H2O_HeavyOil
::
henryOilInWater
(
T
);
else
if
(
phaseIdx
==
nPhaseIdx
&&
compIdx
==
H2OIdx
)
else
if
(
phaseIdx
==
nPhaseIdx
&&
compIdx
==
H2OIdx
)
return
Dumux
::
BinaryCoeff
::
H2O_HeavyOil
::
henryWaterInOil
(
T
)
/
p
;
return
Dumux
::
BinaryCoeff
::
H2O_HeavyOil
::
henryWaterInOil
(
T
);
else
else
DUNE_THROW
(
Dune
::
InvalidStateException
,
"non-existent henry coefficient for phase index "
<<
phaseIdx
DUNE_THROW
(
Dune
::
InvalidStateException
,
"non-existent henry coefficient for phase index "
<<
phaseIdx
<<
" and component index "
<<
compIdx
);
<<
" and component index "
<<
compIdx
);
}
}
/* partial pressures in the gas phase, taken from saturation vapor pressures
/*!
* \brief Partial pressures in the gas phase, taken from saturation vapor pressures.
*/
*/
template
<
class
FluidState
>
template
<
class
FluidState
>
static
Scalar
partialPressureGas
(
const
FluidState
&
fluidState
,
int
phaseIdx
,
static
Scalar
partialPressureGas
(
const
FluidState
&
fluidState
,
int
phaseIdx
,
...
@@ -396,7 +398,8 @@ public:
...
@@ -396,7 +398,8 @@ public:
DUNE_THROW
(
Dune
::
InvalidStateException
,
"non-existent component index "
<<
compIdx
);
DUNE_THROW
(
Dune
::
InvalidStateException
,
"non-existent component index "
<<
compIdx
);
}
}
/* inverse vapor pressures, taken from inverse saturation vapor pressures
/*!
* \brief Inverse vapor pressures, taken from inverse saturation vapor pressures
*/
*/
template
<
class
FluidState
>
template
<
class
FluidState
>
static
Scalar
inverseVaporPressureCurve
(
const
FluidState
&
fluidState
,
static
Scalar
inverseVaporPressureCurve
(
const
FluidState
&
fluidState
,
...
@@ -418,11 +421,10 @@ public:
...
@@ -418,11 +421,10 @@ public:
/*!
/*!
* \brief Given all mole fractions in a phase, return the specific
* \brief Given all mole fractions in a phase, return the specific
* phase enthalpy [J/kg].
* phase enthalpy\f$\mathrm{[J/kg]}\f$.
*/
/*!
* \todo This system neglects the contribution of gas-molecules in the liquid phase.
* \todo This system neglects the contribution of gas-molecules in the liquid phase.
* This contribution is probably not big. Somebody would have to find out the enthalpy of solution for this system. ...
* This contribution is probably not big.
* Somebody would have to find out the enthalpy of solution for this system. ...
*/
*/
using
Base
::
enthalpy
;
using
Base
::
enthalpy
;
template
<
class
FluidState
>
template
<
class
FluidState
>
...
@@ -458,6 +460,14 @@ public:
...
@@ -458,6 +460,14 @@ public:
DUNE_THROW
(
Dune
::
NotImplemented
,
"FluidSystems::H2ONAPL::heatCapacity()"
);
DUNE_THROW
(
Dune
::
NotImplemented
,
"FluidSystems::H2ONAPL::heatCapacity()"
);
}
}
/*!
* \brief Thermal conductivity of a fluid phase \f$\mathrm{[W/(m K)]}\f$.
*
* Use the conductivity of water (wPhase and gPhase) and oil (nPhase) as a first approximation.
*
* \param fluidState An arbitrary fluid state
* \param phaseIdx The index of the fluid phase to consider
*/
using
Base
::
thermalConductivity
;
using
Base
::
thermalConductivity
;
template
<
class
FluidState
>
template
<
class
FluidState
>
static
Scalar
thermalConductivity
(
const
FluidState
&
fluidState
,
static
Scalar
thermalConductivity
(
const
FluidState
&
fluidState
,
...
@@ -480,10 +490,7 @@ public:
...
@@ -480,10 +490,7 @@ public:
DUNE_THROW
(
Dune
::
InvalidStateException
,
"Invalid phase index "
<<
phaseIdx
);
DUNE_THROW
(
Dune
::
InvalidStateException
,
"Invalid phase index "
<<
phaseIdx
);
}
}
private
:
};
};
}
// end namespace FluidSystems
}
// end namespace FluidSystems
}
// end namespace Dumux
}
// end namespace Dumux
...
...
This diff is collapsed.
Click to expand it.
test/porousmediumflow/3pwateroil/implicit/3pwateroilsagdspatialparams.hh
+
0
−
2
View file @
12492916
...
@@ -87,11 +87,9 @@ public:
...
@@ -87,11 +87,9 @@ public:
// residual saturations
// residual saturations
fineMaterialParams_
.
setSwr
(
0.1
);
fineMaterialParams_
.
setSwr
(
0.1
);
fineMaterialParams_
.
setSwrx
(
0.12
);
//Total liquid Residual Saturation
fineMaterialParams_
.
setSnr
(
0.09
);
//Residual of NAPL if there is no water
fineMaterialParams_
.
setSnr
(
0.09
);
//Residual of NAPL if there is no water
fineMaterialParams_
.
setSgr
(
0.01
);
fineMaterialParams_
.
setSgr
(
0.01
);
coarseMaterialParams_
.
setSwr
(
0.1
);
coarseMaterialParams_
.
setSwr
(
0.1
);
coarseMaterialParams_
.
setSwrx
(
0.12
);
coarseMaterialParams_
.
setSnr
(
0.09
);
coarseMaterialParams_
.
setSnr
(
0.09
);
coarseMaterialParams_
.
setSgr
(
0.01
);
coarseMaterialParams_
.
setSgr
(
0.01
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment